Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.
fix: replace os.system with subprocess.run in unsafe mode pip install
Rip&Tear9acb327d9fd5
diff --git a/lib/crewai-tools/src/crewai_tools/tools/code_interpreter_tool/code_interpreter_tool.py b/lib/crewai-tools/src/crewai_tools/tools/code_interpreter_tool/code_interpreter_tool.pyindex 351f30d6b..977cc0fb4 100644--- a/lib/crewai-tools/src/crewai_tools/tools/code_interpreter_tool/code_interpreter_tool.py+++ b/lib/crewai-tools/src/crewai_tools/tools/code_interpreter_tool/code_interpreter_tool.py@@ -8,6 +8,7 @@ potentially unsafe operations and importing restricted modules.import importlib.utilimport osimport subprocess+import sysfrom types import ModuleTypefrom typing import Any, ClassVar, TypedDict@@ -321,7 +322,7 @@ class CodeInterpreterTool(BaseTool):"""if self._check_docker_available():return self.run_code_in_docker(code, libraries_used)-+error_msg = ("Docker is required for safe code execution but is not available. ""The restricted sandbox fallback has been removed due to security vulnerabilities "@@ -411,7 +412,7 @@ class CodeInterpreterTool(BaseTool):Printer.print("WARNING: Running code in unsafe mode", color="bold_magenta")# Install libraries on the host machinefor library in libraries_used:- os.system(f"pip install {library}") # noqa: S605+ subprocess.run([sys.executable, "-m", "pip", "install", library], check=False) # noqa: S603# Execute the codetry:diff --git a/lib/crewai-tools/tests/tools/test_code_interpreter_tool.py b/lib/crewai-tools/tests/tools/test_code_interpreter_tool.pyindex ea54fb587..5b0144790 100644--- a/lib/crewai-tools/tests/tools/test_code_interpreter_tool.py+++ b/lib/crewai-tools/tests/tools/test_code_interpreter_tool.py@@ -1,3 +1,4 @@+import sysfrom unittest.mock import patchfrom crewai_tools.tools.code_interpreter_tool.code_interpreter_tool import (@@ -152,6 +153,44 @@ x = 10assert result == "No result variable found."+@patch("crewai_tools.tools.code_interpreter_tool.code_interpreter_tool.subprocess.run")+def test_unsafe_mode_installs_libraries_without_shell(+ subprocess_run_mock, printer_mock, docker_unavailable_mock+):+ """Test that library installation uses subprocess.run with shell=False, not os.system."""+ tool = CodeInterpreterTool(unsafe_mode=True)+ code = "result = 1"+ libraries_used = ["numpy", "pandas"]++ tool.run(code=code, libraries_used=libraries_used)++ assert subprocess_run_mock.call_count == 2+ for call, library in zip(subprocess_run_mock.call_args_list, libraries_used):+ args, kwargs = call+ # Must be list form (no shell expansion possible)+ assert args[0] == [sys.executable, "-m", "pip", "install", library]+ # shell= must not be True (defaults to False)+ assert kwargs.get("shell", False) is False+++@patch("crewai_tools.tools.code_interpreter_tool.code_interpreter_tool.subprocess.run")+def test_unsafe_mode_library_name_with_shell_metacharacters_does_not_invoke_shell(+ subprocess_run_mock, printer_mock, docker_unavailable_mock+):+ """Test that a malicious library name cannot inject shell commands."""+ tool = CodeInterpreterTool(unsafe_mode=True)+ code = "result = 1"+ malicious_library = "numpy; rm -rf /"++ tool.run(code=code, libraries_used=[malicious_library])++ subprocess_run_mock.assert_called_once()+ args, kwargs = subprocess_run_mock.call_args+ # The entire malicious string is passed as a single argument — no shell parsing+ assert args[0] == [sys.executable, "-m", "pip", "install", malicious_library]+ assert kwargs.get("shell", False) is False++def test_unsafe_mode_running_unsafe_code(printer_mock, docker_unavailable_mock):"""Test behavior when no result variable is set."""tool = CodeInterpreterTool(unsafe_mode=True)