Skip to content

Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.

fix(crew): let a hierarchical crew run more than once (#8369)

Subhash Polisetti9f791dbfdad9
diff --git a/lib/crewai/src/crewai/crew.py b/lib/crewai/src/crewai/crew.py
index e3ebae7ae..ecab6d596 100644
--- a/lib/crewai/src/crewai/crew.py
+++ b/lib/crewai/src/crewai/crew.py
@@ -119,6 +119,7 @@ from crewai.task import Task
from crewai.tasks.conditional_task import ConditionalTask
from crewai.tasks.task_output import TaskOutput
from crewai.tools.agent_tools.agent_tools import AgentTools
+from crewai.tools.agent_tools.base_agent_tools import BaseAgentTool
from crewai.tools.agent_tools.read_file_tool import ReadFileTool
from crewai.tools.base_tool import BaseTool
from crewai.tools.tool_failure import ToolFailurePolicy
@@ -1533,7 +1534,11 @@ class Crew(FlowTrackable, BaseModel):
if self.manager_agent is not None:
self.manager_agent.allow_delegation = True
manager = self.manager_agent
- if manager.tools is not None and len(manager.tools) > 0:
+ # Delegation tools are the crew's own: a manager built from
+ # manager_llm keeps them on the next kickoff, copy() or train().
+ if manager.tools is not None and any(
+ not isinstance(tool, BaseAgentTool) for tool in manager.tools
+ ):
self._logger.log(
"warning",
"Manager agent should not have tools",
@@ -1868,7 +1873,9 @@ class Crew(FlowTrackable, BaseModel):
self, task: Task, tools: list[BaseTool]
) -> list[BaseTool]:
if self.manager_agent:
- if task.agent:
+ # A previous run leaves the manager assigned to the task; that is
+ # not a worker to delegate to.
+ if task.agent and task.agent is not self.manager_agent:
tools = self._inject_delegation_tools(tools, task.agent, [task.agent])
else:
tools = self._inject_delegation_tools(
diff --git a/lib/crewai/tests/test_crew.py b/lib/crewai/tests/test_crew.py
index 5d3c2e546..1205fae83 100644
--- a/lib/crewai/tests/test_crew.py
+++ b/lib/crewai/tests/test_crew.py
@@ -1,5 +1,6 @@
"""Test Agent creation and execution basic functionality."""
+import asyncio
from io import StringIO
import json
import threading
@@ -38,6 +39,7 @@ from crewai.flow import Flow, start
from crewai.knowledge.knowledge import Knowledge
from crewai.knowledge.source.string_knowledge_source import StringKnowledgeSource
from crewai.llm import LLM
+from crewai.llms.base_llm import BaseLLM
from crewai.memory.unified_memory import Memory
from crewai.process import Process
from crewai.project import CrewBase, agent, before_kickoff, crew, task
@@ -2911,6 +2913,61 @@ def test_manager_agent_with_tools_raises_exception(researcher, writer):
crew.kickoff()
+class _ScriptedReActLLM(BaseLLM):
+ def __init__(self, *replies: str) -> None:
+ super().__init__(model="offline")
+ self.replies = replies
+ self.calls = 0
+
+ def supports_function_calling(self) -> bool:
+ return False
+
+ def call(self, messages: Any, **kwargs: Any) -> str:
+ reply = self.replies[self.calls % len(self.replies)]
+ self.calls += 1
+ return reply
+
+ async def acall(self, messages: Any, **kwargs: Any) -> str:
+ return self.call(messages, **kwargs)
+
+
[email protected]("async_entry", [False, True], ids=["sync", "async"])
[email protected]("manager", ["manager_llm", "manager_agent"])
+def test_hierarchical_crew_delegates_to_workers_on_every_kickoff(
+ manager, async_entry
+):
+ delegate = json.dumps(
+ {"task": "Write a word", "context": "None", "coworker": "Writer"}
+ )
+ manager_llm = _ScriptedReActLLM(
+ f"Thought: Delegate\nAction: Delegate work to coworker\nAction Input: {delegate}",
+ "Thought: Done\nFinal Answer: hello",
+ )
+ worker_llm = _ScriptedReActLLM("Thought: Done\nFinal Answer: hello")
+ writer = Agent(role="Writer", goal="Write", backstory="Writes", llm=worker_llm)
+ task = Task(description="Get a word", expected_output="A word")
+ if manager == "manager_llm":
+ crew = Crew(
+ agents=[writer],
+ tasks=[task],
+ process=Process.hierarchical,
+ manager_llm=manager_llm,
+ )
+ else:
+ boss = Agent(role="Boss", goal="Manage", backstory="Manages", llm=manager_llm)
+ crew = Crew(
+ agents=[writer],
+ tasks=[task],
+ process=Process.hierarchical,
+ manager_agent=boss,
+ )
+
+ for run in (1, 2):
+ result = asyncio.run(crew.akickoff()) if async_entry else crew.kickoff()
+ assert result.raw == "hello"
+ assert worker_llm.calls == run
+
+
@pytest.mark.vcr()
def test_crew_train_success(researcher, writer, monkeypatch):
task = Task(