Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.
fix(telemetry): skip signal handler registration in non-main threads
Giulio Leoneb76022c1e785
diff --git a/lib/crewai/src/crewai/telemetry/telemetry.py b/lib/crewai/src/crewai/telemetry/telemetry.pyindex 04303fc3d..136a7d7d0 100644--- a/lib/crewai/src/crewai/telemetry/telemetry.py+++ b/lib/crewai/src/crewai/telemetry/telemetry.py@@ -173,6 +173,12 @@ class Telemetry:self._original_handlers: dict[int, Any] = {}+ if threading.current_thread() is not threading.main_thread():+ logger.debug(+ "Skipping signal handler registration: not running in main thread"+ )+ return+self._register_signal_handler(signal.SIGTERM, SigTermEvent, shutdown=True)self._register_signal_handler(signal.SIGINT, SigIntEvent, shutdown=True)if hasattr(signal, "SIGHUP"):diff --git a/lib/crewai/tests/telemetry/test_telemetry.py b/lib/crewai/tests/telemetry/test_telemetry.pyindex 8f7f5fc70..d0564982d 100644--- a/lib/crewai/tests/telemetry/test_telemetry.py+++ b/lib/crewai/tests/telemetry/test_telemetry.py@@ -121,3 +121,41 @@ def test_telemetry_singleton_pattern():thread.join()assert all(instance is telemetry1 for instance in instances)+++def test_no_signal_handler_traceback_in_non_main_thread():+ """Signal handler registration should be silently skipped in non-main threads.++ Regression test for https://github.com/crewAIInc/crewAI/issues/4289+ """+ errors: list[Exception] = []+ mock_holder: dict = {}++ def init_in_thread():+ try:+ Telemetry._instance = None+ with (+ patch.dict(+ os.environ,+ {"CREWAI_DISABLE_TELEMETRY": "false", "OTEL_SDK_DISABLED": "false"},+ ),+ patch("crewai.telemetry.telemetry.TracerProvider"),+ patch("signal.signal") as mock_signal,+ patch("crewai.telemetry.telemetry.logger") as mock_logger,+ ):+ Telemetry()+ mock_holder["signal"] = mock_signal+ mock_holder["logger"] = mock_logger+ except Exception as exc:+ errors.append(exc)++ thread = threading.Thread(target=init_in_thread)+ thread.start()+ thread.join()++ assert not errors, f"Unexpected error: {errors}"+ assert mock_holder, "Thread did not execute"+ mock_holder["signal"].assert_not_called()+ mock_holder["logger"].debug.assert_any_call(+ "Skipping signal handler registration: not running in main thread"+ )