Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.
fix: use __router_paths__ for listener+router methods in FlowMeta (#5064)
alex-clawdb890ac0dd0d6
diff --git a/lib/crewai/src/crewai/flow/flow.py b/lib/crewai/src/crewai/flow/flow.pyindex 48bf887c4..1c1aa90b5 100644--- a/lib/crewai/src/crewai/flow/flow.py+++ b/lib/crewai/src/crewai/flow/flow.py@@ -778,11 +778,19 @@ class FlowMeta(type):and attr_value.__is_router__):routers.add(attr_name)- possible_returns = get_possible_return_constants(attr_value)- if possible_returns:- router_paths[attr_name] = possible_returns+ # First check for explicit __router_paths__ (set by @human_feedback(emit=[...]))+ if (+ hasattr(attr_value, "__router_paths__")+ and attr_value.__router_paths__+ ):+ router_paths[attr_name] = attr_value.__router_paths__else:- router_paths[attr_name] = []+ # Fall back to source code analysis for @router methods+ possible_returns = get_possible_return_constants(attr_value)+ if possible_returns:+ router_paths[attr_name] = possible_returns+ else:+ router_paths[attr_name] = []# Handle start methods that are also routers (e.g., @human_feedback with emit)if (diff --git a/lib/crewai/tests/test_flow_serializer.py b/lib/crewai/tests/test_flow_serializer.pyindex 952325deb..53d935e95 100644--- a/lib/crewai/tests/test_flow_serializer.py+++ b/lib/crewai/tests/test_flow_serializer.py@@ -224,6 +224,58 @@ class TestHumanFeedbackMethods:assert method_map["handle_approved"]["has_human_feedback"] is Falseassert method_map["handle_rejected"]["has_human_feedback"] is False+ def test_listen_plus_human_feedback_router_edges(self):+ """Test that @listen + @human_feedback(emit=...) generates router edges.++ This is the pattern used in the whitepaper generator:+ a listener method that also acts as a router via @human_feedback(emit=[...]).+ The serializer must generate edges from this method to listeners of its emit paths.+ """++ class ReviewFlow(Flow):+ @start()+ def generate(self):+ return "content"++ @listen(generate)+ @human_feedback(+ message="Review this:",+ emit=["approved", "needs_changes", "cancelled"],+ llm="gpt-4o-mini",+ )+ def review(self):+ return "review result"++ @listen("approved")+ def handle_approved(self):+ return "done"++ @listen("needs_changes")+ def handle_changes(self):+ return "regenerating"++ @listen("cancelled")+ def handle_cancelled(self):+ return "cancelled"++ structure = flow_structure(ReviewFlow)++ method_map = {m["name"]: m for m in structure["methods"]}+ edge_set = {(e["from_method"], e["to_method"], e.get("condition")) for e in structure["edges"]}++ # review should be detected as a router with the emit paths+ assert method_map["review"]["type"] == "router"+ assert set(method_map["review"]["router_paths"]) == {"approved", "needs_changes", "cancelled"}+ assert method_map["review"]["has_human_feedback"] is True++ # Should have listen edge: generate -> review+ assert ("generate", "review", None) in edge_set++ # Should have route edges from review to each listener+ assert ("review", "handle_approved", "approved") in edge_set+ assert ("review", "handle_changes", "needs_changes") in edge_set+ assert ("review", "handle_cancelled", "cancelled") in edge_set+class TestCrewReferences:"""Test detection of Crew references in method bodies."""