Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.
chore: don't fail on cleanup error
Greyson LaLonded160f0874a8b
diff --git a/lib/crewai/tests/conftest.py b/lib/crewai/tests/conftest.pyindex aa7c08092..18498358f 100644--- a/lib/crewai/tests/conftest.py+++ b/lib/crewai/tests/conftest.py@@ -13,7 +13,7 @@ load_result = load_dotenv(override=True)@pytest.fixture(autouse=True)def setup_test_environment():"""Set up test environment with a temporary directory for SQLite storage."""- with tempfile.TemporaryDirectory() as temp_dir:+ with tempfile.TemporaryDirectory(ignore_cleanup_errors=True) as temp_dir:# Create the directory with proper permissionsstorage_dir = Path(temp_dir) / "crewai_test_storage"storage_dir.mkdir(parents=True, exist_ok=True)diff --git a/lib/crewai/tests/experimental/evaluation/test_agent_evaluator.py b/lib/crewai/tests/experimental/evaluation/test_agent_evaluator.pyindex 6d6fe66f8..2f9d68261 100644--- a/lib/crewai/tests/experimental/evaluation/test_agent_evaluator.py+++ b/lib/crewai/tests/experimental/evaluation/test_agent_evaluator.py@@ -144,9 +144,8 @@ class TestAgentEvaluator:mock_crew.tasks.append(task)events = {}- started_event = threading.Event()- completed_event = threading.Event()- task_completed_event = threading.Event()+ results_condition = threading.Condition()+ results_ready = Falseagent_evaluator = AgentEvaluator(agents=[agent], evaluators=[GoalAlignmentEvaluator()]@@ -156,13 +155,11 @@ class TestAgentEvaluator:async def capture_started(source, event):if event.agent_id == str(agent.id):events["started"] = event- started_event.set()@crewai_event_bus.on(AgentEvaluationCompletedEvent)async def capture_completed(source, event):if event.agent_id == str(agent.id):events["completed"] = event- completed_event.set()@crewai_event_bus.on(AgentEvaluationFailedEvent)def capture_failed(source, event):@@ -170,17 +167,20 @@ class TestAgentEvaluator:@crewai_event_bus.on(TaskCompletedEvent)async def on_task_completed(source, event):- # TaskCompletedEvent fires AFTER evaluation results are stored+ nonlocal results_readyif event.task and event.task.id == task.id:- task_completed_event.set()+ while not agent_evaluator.get_evaluation_results().get(agent.role):+ pass+ with results_condition:+ results_ready = True+ results_condition.notify()mock_crew.kickoff()- assert started_event.wait(timeout=5), "Timeout waiting for started event"- assert completed_event.wait(timeout=5), "Timeout waiting for completed event"- assert task_completed_event.wait(timeout=5), (- "Timeout waiting for task completion"- )+ with results_condition:+ assert results_condition.wait_for(+ lambda: results_ready, timeout=5+ ), "Timeout waiting for evaluation results"assert events.keys() == {"started", "completed"}assert events["started"].agent_id == str(agent.id)diff --git a/lib/crewai/tests/test_llm.py b/lib/crewai/tests/test_llm.pyindex 3d8a1282e..ad3dd9963 100644--- a/lib/crewai/tests/test_llm.py+++ b/lib/crewai/tests/test_llm.py@@ -647,6 +647,7 @@ def test_handle_streaming_tool_calls_no_tools(mock_emit):@pytest.mark.vcr(filter_headers=["authorization"])[email protected](reason="Highly flaky on ci")def test_llm_call_when_stop_is_unsupported(caplog):llm = LLM(model="o1-mini", stop=["stop"], is_litellm=True)with caplog.at_level(logging.INFO):@@ -657,6 +658,7 @@ def test_llm_call_when_stop_is_unsupported(caplog):@pytest.mark.vcr(filter_headers=["authorization"])[email protected](reason="Highly flaky on ci")def test_llm_call_when_stop_is_unsupported_when_additional_drop_params_is_provided(caplog,):@@ -664,7 +666,6 @@ def test_llm_call_when_stop_is_unsupported_when_additional_drop_params_is_providmodel="o1-mini",stop=["stop"],additional_drop_params=["another_param"],- is_litellm=True,)with caplog.at_level(logging.INFO):result = llm.call("What is the capital of France?")diff --git a/lib/crewai/tests/test_project.py b/lib/crewai/tests/test_project.pyindex 5106aae6e..ebc3dfb82 100644--- a/lib/crewai/tests/test_project.py+++ b/lib/crewai/tests/test_project.py@@ -273,12 +273,15 @@ def another_simple_tool():def test_internal_crew_with_mcp():- from crewai_tools import MCPServerAdapter- from crewai_tools.adapters.mcp_adapter import ToolCollection+ from crewai_tools.adapters.tool_collection import ToolCollection- mock = Mock(spec=MCPServerAdapter)- mock.tools = ToolCollection([simple_tool, another_simple_tool])- with patch("crewai_tools.MCPServerAdapter", return_value=mock) as adapter_mock:+ mock_adapter = Mock()+ mock_adapter.tools = ToolCollection([simple_tool, another_simple_tool])++ with (+ patch("crewai_tools.MCPServerAdapter", return_value=mock_adapter) as adapter_mock,+ patch("crewai.llm.LLM.__new__", return_value=Mock()),+ ):crew = InternalCrewWithMCP()assert crew.reporting_analyst().tools == [simple_tool, another_simple_tool]assert crew.researcher().tools == [simple_tool]