Comp AI CRM is an open source, CRM designed for AI agents. Agentic-first CRM.
TypeScript
feat(app): copy the tracking snippet for the selected install method (#128)
github-actions[bot]30e013777815
diff --git a/apps/api/src/tracking/tracking.controller.ts b/apps/api/src/tracking/tracking.controller.tsindex 70a3db88..1c96016c 100644--- a/apps/api/src/tracking/tracking.controller.ts+++ b/apps/api/src/tracking/tracking.controller.ts@@ -15,10 +15,12 @@ import {Param,Post,Req,+ Res,ServiceUnavailableException,} from "@nestjs/common";import { ConfigService } from "@nestjs/config";import { AllowAnonymous } from "@thallesp/nestjs-better-auth";+import type { Response } from "express";import type { EnvironmentVariables } from "../config/env.validation";import { InjectDatabase } from "../database/database.constants";import { TrackingConfigService } from "./tracking-config.service";@@ -59,9 +61,12 @@ export class TrackingController {@HttpCode(204)async collect(@Req() request: IncomingMessage,+ @Res({ passthrough: true }) response: Response,@Headers("origin") origin?: string,@Headers("user-agent") userAgent?: string,): Promise<void> {+ response.setHeader("cross-origin-resource-policy", "cross-origin");+const raw = await read(request, MAX_BODY_BYTES);if (!raw) return;diff --git a/apps/api/test/tracking-collector.spec.ts b/apps/api/test/tracking-collector.spec.tsnew file mode 100644index 00000000..8432faf8--- /dev/null+++ b/apps/api/test/tracking-collector.spec.ts@@ -0,0 +1,31 @@+import { afterAll, beforeAll, describe, expect, it } from "bun:test";+import type { INestApplication } from "@nestjs/common";+import request from "supertest";++describe("Tracking collector", () => {+ let app: INestApplication;++ beforeAll(async () => {+ const { createApp } = await import("../src/create-app");++ app = await createApp();+ await app.init();+ });++ afterAll(async () => {+ await app.close();+ });++ it("answers a beacon from another origin with a cross-origin CORP", async () => {+ const response = await request(app.getHttpServer())+ .post("/api/t/e")+ .set("origin", "https://example.com")+ .set("content-type", "text/plain")+ .send(JSON.stringify({ siteId: "cmp_unknown", events: [] }));++ expect(response.status).toBe(204);+ expect(response.headers["cross-origin-resource-policy"]).toBe(+ "cross-origin",+ );+ });+});diff --git a/apps/app/app/(app)/[slug]/settings/tracking/tracking-script.tsx b/apps/app/app/(app)/[slug]/settings/tracking/tracking-script.tsxindex b349b44d..4311e825 100644--- a/apps/app/app/(app)/[slug]/settings/tracking/tracking-script.tsx+++ b/apps/app/app/(app)/[slug]/settings/tracking/tracking-script.tsx@@ -33,6 +33,7 @@ import { Label } from "@crm/ui/components/label";import { StatusIndicator } from "@crm/ui/components/status-indicator";import { Switch } from "@crm/ui/components/switch";import { useMutation, useQuery } from "@tanstack/react-query";+import { useState } from "react";import { toast } from "sonner";import { useCrmCache } from "@/lib/trpc/cache";import { useTRPC } from "@/lib/trpc/client";@@ -41,6 +42,7 @@ export function TrackingScript() {const trpc = useTRPC();const cache = useCrmCache();const tracking = useQuery(trpc.tracking.settings.queryOptions());+ const [section, setSection] = useState("html");const setFlag = useMutation(trpc.tracking.setFlag.mutationOptions({@@ -116,7 +118,13 @@ export function TrackingScript() {</CardDescription><CardAction>- <Button size="sm" onClick={() => copy(snippet)} type="button">+ <Button+ size="sm"+ onClick={() =>+ copy(section === "gtm" ? tagManagerSnippet : snippet)+ }+ type="button"+ ><Icon icon={Copy} data-icon="inline-start" />Copy</Button>@@ -124,10 +132,15 @@ export function TrackingScript() {</CardHeader><CardContent>- <Accordion type="single" collapsible defaultValue="html">+ <Accordion+ type="single"+ collapsible+ value={section}+ onValueChange={setSection}+ ><AccordionItem value="html"><AccordionTrigger>Paste it into your HTML</AccordionTrigger>- <AccordionContent>+ <AccordionContent className="flex flex-col gap-4"><pre className="overflow-x-auto rounded-md border bg-muted p-4 font-mono text-code-foreground text-xs/5"><span className="text-code-accent">{"<script"}</span>{"\n src="}@@ -149,7 +162,7 @@ export function TrackingScript() {<AccordionTrigger>Add it through Google Tag Manager</AccordionTrigger>- <AccordionContent>+ <AccordionContent className="flex flex-col gap-4"><pre className="overflow-x-auto rounded-md border bg-muted p-4 font-mono text-code-foreground text-xs/5"><span className="text-code-accent">{"<script"}</span>{"\n src="}@@ -168,23 +181,12 @@ export function TrackingScript() {off any consent-blocked category you do not need.</li></ol>- <div className="flex items-center justify-between gap-4">- <p className="text-muted-foreground text-xs/relaxed">- Tag Manager drops a{" "}- <span className="font-mono text-foreground">data-site</span>{" "}- attribute when it injects a script, so this form carries the- site ID in the URL instead.- </p>- <Button- size="xs"- variant="outline"- type="button"- onClick={() => copy(tagManagerSnippet)}- >- <Icon icon={Copy} data-icon="inline-start" />- Copy- </Button>- </div>+ <p className="text-muted-foreground text-xs/relaxed">+ Tag Manager drops a{" "}+ <span className="font-mono text-foreground">data-site</span>{" "}+ attribute when it injects a script, so this form carries the+ site ID in the URL instead.+ </p></AccordionContent></AccordionItem></Accordion>diff --git a/docs/tracking.md b/docs/tracking.mdindex bfa2a514..f4e8ecb7 100644--- a/docs/tracking.md+++ b/docs/tracking.md@@ -65,6 +65,14 @@ somebody else's page. That imposes rules nothing else in this repo has:`POST /api/t/e`, anonymous, 204, in `TrackingController`. It answers nothing: atracker that could read a response is a tracker whose failures a stranger can probe.+**It is the one route that sets `Cross-Origin-Resource-Policy: cross-origin`**, and+it must. `helmet()` puts `same-origin` on every response, which is right for an API+only its own app calls — but this one is called by a `no-cors` beacon on somebody+else's marketing site, so Chrome blocks the reply with+`ERR_BLOCKED_BY_RESPONSE.NotSameOrigin` and logs a failure under every page view.+The header is set on the response, not switched off in `helmet`, so the exception+stays with the route that needs it.+The gauntlet, in order, in `TrackingIngestService.accept`:1. **User agent** — the `BOT` pattern.