Skip to content

3D engine that AI agents drive

Outline the touch stick ring and knob so they read on light and dark floors (#2148)

Nguyen Xuan An542bbf6dd9e2
diff --git a/scripts/smoke-game-web.mjs b/scripts/smoke-game-web.mjs
index 56828964..9cbd08f9 100644
--- a/scripts/smoke-game-web.mjs
+++ b/scripts/smoke-game-web.mjs
@@ -287,6 +287,13 @@ async function expectStickUnderFinger(page, landed, dragged) {
assert.equal(drawn.ringWidth, 120);
const stillPath = process.env.GAME_SMOKE_TOUCH_STILL;
if (stillPath) await page.screenshot({ path: stillPath });
+ // GAME_SMOKE_TOUCH_STILL_DARK keeps a second still with the scene dimmed, to see the stick over a dark picture.
+ const darkStillPath = process.env.GAME_SMOKE_TOUCH_STILL_DARK;
+ if (darkStillPath) {
+ await page.evaluate(() => { document.getElementById('game').style.filter = 'brightness(0.3)'; });
+ await page.screenshot({ path: darkStillPath });
+ await page.evaluate(() => { document.getElementById('game').style.filter = ''; });
+ }
}
// Real touch events through the DevTools protocol: finger 1 presses in the left half and drags up past the stick radius (60 px),
diff --git a/src/touch-stick-overlay.js b/src/touch-stick-overlay.js
index f83eb369..a926cf60 100644
--- a/src/touch-stick-overlay.js
+++ b/src/touch-stick-overlay.js
@@ -118,9 +118,9 @@ export function createTouchStickOverlay({ parent, source, fadeMilliseconds = TOU
function elementsFor(name, radius) {
if (drawn.has(name)) return drawn.get(name);
const ring = documentOwner.createElement('div');
- ring.style.cssText = circleStyle(radius * 2, 'border:3px solid rgba(255,255,255,.85);background:rgba(255,255,255,.18);box-shadow:0 0 0 1px rgba(0,0,0,.45),inset 0 0 0 1px rgba(0,0,0,.25)');
+ ring.style.cssText = circleStyle(radius * 2, 'border:4px solid #fff;background:rgba(15,18,28,.3);box-shadow:0 0 0 2px rgba(0,0,0,.65),inset 0 0 0 2px rgba(0,0,0,.5),0 0 16px rgba(0,0,0,.4)');
const knob = documentOwner.createElement('div');
- knob.style.cssText = circleStyle(radius * 2 * KNOB_DIAMETER_OVER_RING_DIAMETER, 'background:rgba(255,255,255,.92);box-shadow:0 0 0 1px rgba(0,0,0,.5),0 2px 6px rgba(0,0,0,.45)');
+ knob.style.cssText = circleStyle(radius * 2 * KNOB_DIAMETER_OVER_RING_DIAMETER, 'background:#fff;box-shadow:0 0 0 2px rgba(0,0,0,.65),0 3px 8px rgba(0,0,0,.5)');
container.appendChild(ring);
container.appendChild(knob);
const elements = { ring, knob };