Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

fix(cua-driver): validate Windows capture handles (#4333)

Anvit Devadiga029379139cf9
diff --git a/libs/cua-driver/rust/crates/platform-windows/src/capture.rs b/libs/cua-driver/rust/crates/platform-windows/src/capture.rs
index 2941adb5ac..ed8a92c98b 100644
--- a/libs/cua-driver/rust/crates/platform-windows/src/capture.rs
+++ b/libs/cua-driver/rust/crates/platform-windows/src/capture.rs
@@ -254,9 +254,27 @@ unsafe fn screenshot_via_screen_region(hwnd: HWND) -> Result<(Vec<u8>, i32, i32,
let h = geometry.height;
let screen_dc = GetDC(HWND(std::ptr::null_mut())); // NULL HWND → desktop DC
+ if screen_dc.is_invalid() {
+ bail!("screen-region fallback: GetDC(NULL) returned an invalid desktop DC");
+ }
let mem_dc = CreateCompatibleDC(screen_dc);
+ if mem_dc.is_invalid() {
+ ReleaseDC(HWND(std::ptr::null_mut()), screen_dc);
+ bail!("screen-region fallback: CreateCompatibleDC returned an invalid memory DC");
+ }
let bitmap = CreateCompatibleBitmap(screen_dc, w, h);
+ if bitmap.is_invalid() {
+ let _ = DeleteDC(mem_dc);
+ ReleaseDC(HWND(std::ptr::null_mut()), screen_dc);
+ bail!("screen-region fallback: CreateCompatibleBitmap returned an invalid bitmap");
+ }
let old_bitmap = SelectObject(mem_dc, bitmap);
+ if old_bitmap.is_invalid() {
+ let _ = DeleteObject(bitmap);
+ let _ = DeleteDC(mem_dc);
+ ReleaseDC(HWND(std::ptr::null_mut()), screen_dc);
+ bail!("screen-region fallback: SelectObject failed to select the capture bitmap");
+ }
// Copy from physical screen coords into our memory DC at (0, 0).
let blt_ok = BitBlt(
@@ -704,10 +722,28 @@ pub fn screenshot_display_bytes() -> Result<Vec<u8>> {
bail!("Could not get screen metrics");
}
let screen_dc = GetDC(HWND::default());
+ if screen_dc.is_invalid() {
+ bail!("GetDC(NULL) returned an invalid desktop DC");
+ }
let mem_dc = CreateCompatibleDC(screen_dc);
+ if mem_dc.is_invalid() {
+ ReleaseDC(HWND::default(), screen_dc);
+ bail!("CreateCompatibleDC returned an invalid memory DC");
+ }
let bitmap = CreateCompatibleBitmap(screen_dc, w, h);
+ if bitmap.is_invalid() {
+ let _ = DeleteDC(mem_dc);
+ ReleaseDC(HWND::default(), screen_dc);
+ bail!("CreateCompatibleBitmap returned an invalid bitmap");
+ }
let old_bitmap = SelectObject(mem_dc, bitmap);
- BitBlt(mem_dc, 0, 0, w, h, screen_dc, 0, 0, SRCCOPY)?;
+ if old_bitmap.is_invalid() {
+ let _ = DeleteObject(bitmap);
+ let _ = DeleteDC(mem_dc);
+ ReleaseDC(HWND::default(), screen_dc);
+ bail!("SelectObject failed to select the capture bitmap");
+ }
+ let blt_result = BitBlt(mem_dc, 0, 0, w, h, screen_dc, 0, 0, SRCCOPY);
let mut bmi = BITMAPINFO {
bmiHeader: BITMAPINFOHEADER {
biSize: std::mem::size_of::<BITMAPINFOHEADER>() as u32,
@@ -735,6 +771,9 @@ pub fn screenshot_display_bytes() -> Result<Vec<u8>> {
let _ = DeleteObject(bitmap);
let _ = DeleteDC(mem_dc);
ReleaseDC(HWND::default(), screen_dc);
+ if let Err(error) = blt_result {
+ bail!("desktop capture: BitBlt failed: {error}");
+ }
if ok == 0 {
bail!("GetDIBits returned 0");
}