Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

fix(lume): MCP server lume_get_vm should show provisioning status (#855)

Francesco Bonacci048413695fe7
diff --git a/libs/lume/src/Server/Handlers.swift b/libs/lume/src/Server/Handlers.swift
index 1a5e7f47da..6b7726afa5 100644
--- a/libs/lume/src/Server/Handlers.swift
+++ b/libs/lume/src/Server/Handlers.swift
@@ -26,47 +26,12 @@ extension Server {
// Record telemetry
TelemetryClient.shared.record(event: TelemetryEvent.apiVMGet)
- print("Getting VM details: name=\(name), storage=\(String(describing: storage))")
-
do {
let vmController = LumeController()
- print("Created VM controller, attempting to get VM")
- let vm = try vmController.get(name: name, storage: storage)
- print("Successfully retrieved VM")
-
- // Check for nil values that might cause crashes
- if vm.vmDirContext.config.macAddress == nil {
- print("ERROR: VM has nil macAddress")
- return .badRequest(message: "VM configuration is invalid (nil macAddress)")
- }
- print("MacAddress check passed")
-
- // Log that we're about to access details
- print("Preparing VM details response")
-
- // Print the full details object for debugging
- let details = vm.details
- print("VM DETAILS: \(details)")
- print(" name: \(details.name)")
- print(" os: \(details.os)")
- print(" cpuCount: \(details.cpuCount)")
- print(" memorySize: \(details.memorySize)")
- print(" diskSize: \(details.diskSize)")
- print(" display: \(details.display)")
- print(" status: \(details.status)")
- print(" vncUrl: \(String(describing: details.vncUrl))")
- print(" ipAddress: \(String(describing: details.ipAddress))")
- print(" locationName: \(details.locationName)")
-
- // Serialize the VM details
- print("About to serialize VM details")
- let response = try HTTPResponse.json(vm.details)
- print("Successfully serialized VM details")
- return response
-
+ // Use getDetails() for consistent status including provisioning state
+ let details = try vmController.getDetails(name: name, storage: storage)
+ return try HTTPResponse.json(details)
} catch {
- // This will catch errors from both vmController.get and the json serialization
- print("ERROR: Failed to get VM details: \(error.localizedDescription)")
return .badRequest(message: error.localizedDescription)
}
}
diff --git a/libs/lume/src/Server/MCPServer.swift b/libs/lume/src/Server/MCPServer.swift
index c3ed30f95f..4bb7ed21d5 100644
--- a/libs/lume/src/Server/MCPServer.swift
+++ b/libs/lume/src/Server/MCPServer.swift
@@ -550,10 +550,11 @@ final class LumeMCPServer {
}
let storage = args?["storage"]?.stringValue
- let vm = try controller.get(name: name, storage: storage)
+ // Use getDetails() for consistent status including provisioning state
+ let vmDetails = try controller.getDetails(name: name, storage: storage)
let encoder = JSONEncoder()
encoder.outputFormatting = [.prettyPrinted, .sortedKeys]
- let json = try encoder.encode(vm.details)
+ let json = try encoder.encode(vmDetails)
return CallTool.Result(content: [.text(String(data: json, encoding: .utf8) ?? "{}")])
}