Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

Clarify onboarding sign-in benefits and make Skip secondary (#5014)

injaneity0a10f6964b72
diff --git a/apps/cua-spaces-macos/Sources/CuaSpacesMacKit/Views/OnboardingView.swift b/apps/cua-spaces-macos/Sources/CuaSpacesMacKit/Views/OnboardingView.swift
index 7dd86f77d5..e42437bf6a 100644
--- a/apps/cua-spaces-macos/Sources/CuaSpacesMacKit/Views/OnboardingView.swift
+++ b/apps/cua-spaces-macos/Sources/CuaSpacesMacKit/Views/OnboardingView.swift
@@ -466,6 +466,7 @@ public struct OnboardingView: View {
} else {
if skipShows(v) {
Button(onboarding.copy.skip) { skip(v.step) }
+ .buttonStyle(.borderless)
.accessibilityIdentifier("onboarding-skip")
}
primary(v)
diff --git a/apps/cua-spaces-macos/UITests/CuaSpacesMacUITests.swift b/apps/cua-spaces-macos/UITests/CuaSpacesMacUITests.swift
index d3953a0604..75f45a6d8b 100644
--- a/apps/cua-spaces-macos/UITests/CuaSpacesMacUITests.swift
+++ b/apps/cua-spaces-macos/UITests/CuaSpacesMacUITests.swift
@@ -48,7 +48,7 @@ final class CuaSpacesMacUITests: XCTestCase {
XCTAssertTrue(app.staticTexts["Welcome to Cua Spaces"].waitForExistence(timeout: 10))
app.buttons["Get started"].click()
// First run no longer has a Command line page: Sign in follows Welcome.
- XCTAssertTrue(app.staticTexts["Connect your machines and your team."].waitForExistence(timeout: 5))
+ XCTAssertTrue(app.staticTexts["Sign in for account-based access to your machines and Spaces across devices; skip to continue without it."].waitForExistence(timeout: 5))
}
func testSpaceDetailShowsFactsAndTheDropWell() {
diff --git a/apps/cua-spaces-web/src/bridge/__tests__/onboarding.test.tsx b/apps/cua-spaces-web/src/bridge/__tests__/onboarding.test.tsx
index 7e30e3a3fd..fca1e68ccc 100644
--- a/apps/cua-spaces-web/src/bridge/__tests__/onboarding.test.tsx
+++ b/apps/cua-spaces-web/src/bridge/__tests__/onboarding.test.tsx
@@ -37,6 +37,7 @@ describe.each([
s = onboardingReduce(core, s, { type: "start" }, ctx);
expect(s.step).toBe("signin");
expect(onboardingView(core, s).canSkip).toBe(true);
+ expect(onboardingView(core, s).lede).toBe("Sign in for account-based access to your machines and Spaces across devices; skip to continue without it.");
s = onboardingReduce(core, s, { type: "signin-done" }, ctx);
expect(s.step).toBe("agents");
s = onboardingReduce(core, s, { type: "agents-done", configured: ["Codex"] }, ctx);
diff --git a/apps/cua-spaces-web/src/bridge/onboarding.ts b/apps/cua-spaces-web/src/bridge/onboarding.ts
index 6ddcfc3ce4..ff6dc3a954 100644
--- a/apps/cua-spaces-web/src/bridge/onboarding.ts
+++ b/apps/cua-spaces-web/src/bridge/onboarding.ts
@@ -208,7 +208,7 @@ function fallbackReduce(s: OnboardingFlowState, a: OnboardingAction): Onboarding
function fallbackView(s: OnboardingFlowState, os: HostOs): OnboardingView {
const pages: Partial<Record<OnboardingStep, [string, string, string]>> = {
welcome: ["Welcome to Cua Spaces", "Computers for you and your agents.", "Get started"],
- signin: ["Sign in", "Connect your machines and your team.", "Continue"],
+ signin: ["Sign in", "Sign in for account-based access to your machines and Spaces across devices; skip to continue without it.", "Continue"],
mode: ["How will you use this machine?", "You can change this later.", "Continue"],
done: ["You're all set", os === "macos" ? "Cua Spaces is in your menu bar." : "Cua Spaces is in your system tray.", "Start using Cua Spaces"],
};
diff --git a/libs/cua/crates/cua-spaces-app-core/parity/golden/main-window.json b/libs/cua/crates/cua-spaces-app-core/parity/golden/main-window.json
index f53309df99..9edf4b3f23 100644
--- a/libs/cua/crates/cua-spaces-app-core/parity/golden/main-window.json
+++ b/libs/cua/crates/cua-spaces-app-core/parity/golden/main-window.json
@@ -787,7 +787,7 @@
"dots": "Welcome,*Sign in,AI agents,Menu bar,This machine,Done",
"drive": null,
"driveStorage": null,
- "lede": "Connect your machines and your team.",
+ "lede": "Sign in for account-based access to your machines and Spaces across devices; skip to continue without it.",
"notice": null,
"noticeLink": null,
"presentations": [],
@@ -809,7 +809,7 @@
"dots": "Welcome,*Sign in,AI agents,Menu bar,This machine,Done",
"drive": null,
"driveStorage": null,
- "lede": "Connect your machines and your team.",
+ "lede": "Sign in for account-based access to your machines and Spaces across devices; skip to continue without it.",
"notice": null,
"noticeLink": null,
"presentations": [],
diff --git a/libs/cua/crates/cua-spaces-app-core/src/onboarding.rs b/libs/cua/crates/cua-spaces-app-core/src/onboarding.rs
index 4d68aed59f..9cdef58f9f 100644
--- a/libs/cua/crates/cua-spaces-app-core/src/onboarding.rs
+++ b/libs/cua/crates/cua-spaces-app-core/src/onboarding.rs
@@ -1100,7 +1100,7 @@ pub fn view_on(s: &OnboardingState, os: SpaceOs) -> OnboardingView {
),
Signin => (
"Sign in",
- "Connect your machines and your team.",
+ "Sign in for account-based access to your machines and Spaces across devices; skip to continue without it.",
"Continue",
),
Agents => (
@@ -1307,6 +1307,24 @@ mod tests {
}
}
+ #[test]
+ fn signin_explains_account_access_and_allows_skipping() {
+ let s = reduce(&initial(None, None), &OnboardingAction::Start);
+ for os in [SpaceOs::Macos, SpaceOs::Windows, SpaceOs::Linux] {
+ let v = view_on(&s, os);
+ assert_eq!(v.title, "Sign in");
+ assert_eq!(
+ v.lede,
+ "Sign in for account-based access to your machines and Spaces across devices; skip to continue without it."
+ );
+ assert!(v.can_skip);
+ }
+ assert_eq!(
+ reduce(&s, &OnboardingAction::SigninDone).step,
+ OnboardingStep::Agents
+ );
+ }
+
/// Cua Volume off (the default): no Volume page, dot, Done line or
/// promise in Done's launch-at-login line; turning it off on its page
/// moves on.