Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.
Rust agentai-agentapplecomputer-usecomputer-use-agentcontainerizationcuadesktop-automationhacktoberfestlumemacosmanusoperatorswiftvirtualizationvirtualization-frameworkwindowswindows-sandbox
fix(spaces): This Mac tasks open the task page, not the unlisted relay Space (#6363) (#6371)
cua-agents[bot]1e23148bb337
diff --git a/apps/cua-spaces-web/src/__tests__/ask-first-start-failed.test.tsx b/apps/cua-spaces-web/src/__tests__/ask-first-start-failed.test.tsxindex 87b5e6ad25..6c0d75e6c2 100644--- a/apps/cua-spaces-web/src/__tests__/ask-first-start-failed.test.tsx+++ b/apps/cua-spaces-web/src/__tests__/ask-first-start-failed.test.tsx@@ -67,6 +67,18 @@ describe.skipIf(!wasmBuilt)("This Mac as a task's computer (real routes, wasm coawait waitFor(() => expect(askTask(id)).toMatchObject({ spaceId: HOST_SPACE, onHost: true, error: null }), { timeout: 5000 });});+ it("opens the task's own page, never the unlisted relay Space (trycua/cua#6363)", async () => {+ setThisMacConfirmed(true);+ await mountApp("/home", HOST);+ await screen.findByText("What do you want to do?");+ await pickThisMac();+ await startJob("hi");+ const id = askTasks()[0]!.id;+ await waitFor(() => expect(askTask(id)).toMatchObject({ spaceId: HOST_SPACE, onHost: true }), { timeout: 5000 });+ expect(screen.queryByText("This Space isn't here")).toBeNull();+ expect(screen.getAllByText("This Mac").length).toBeGreaterThan(0);+ });+it("Pick another keeps the default and reopens the picker", async () => {await mountApp("/home", HOST);await screen.findByText("What do you want to do?");diff --git a/apps/cua-spaces-web/src/components/ask-first/use-start-task.ts b/apps/cua-spaces-web/src/components/ask-first/use-start-task.tsindex 1e35ffdf63..16f7fee7b7 100644--- a/apps/cua-spaces-web/src/components/ask-first/use-start-task.ts+++ b/apps/cua-spaces-web/src/components/ask-first/use-start-task.ts@@ -55,7 +55,7 @@ export function useStartTask(): {return true;};- const run = (id: string, target: TaskTarget, place?: { pendingId?: string; queued?: boolean; onSpace?: (spaceId: string) => void; onCreated?: (spaceId: string) => void; onNoSpace?: () => void }) =>+ const run = (id: string, target: TaskTarget, place?: { pendingId?: string; queued?: boolean; onCreated?: (spaceId: string) => void }) =>void (async () => {try {let spaceId = target.kind === "space" ? target.spaceId : null;@@ -64,7 +64,6 @@ export function useStartTask(): {spaceId = hostSpaceId(status);if (!spaceId) throw new Error(HOST_NOT_SHARED);updateAskTask(id, { spaceId, onHost: true });- place?.onSpace?.(spaceId);}if (!spaceId) {const os = target.kind === "create" ? target.os : "linux";@@ -98,8 +97,6 @@ export function useStartTask(): {updateAskTask(id, { runId: started.run_id });} catch (e) {updateAskTask(id, { error: e instanceof Error ? e.message : String(e), pendingId: null });- // No Space to show it in (this Mac isn't shared): its conversation page says why.- if (!askTask(id)?.spaceId) place?.onNoSpace?.();}})();@@ -108,7 +105,7 @@ export function useStartTask(): {const target = taskTarget(where);const task = addAskTask({ prompt: prompt.trim(), agent, os: whereOs(where), spaceId: target.kind === "space" ? target.spaceId : null, onHost: target.kind === "host" });record("ask_first_task_started");- // Straight to the Space: the one picked, the one being made (its page follows the create), or this Mac's.+ // Straight to the Space: the one picked or the one being made (its page follows the create); this Mac opens the task's page.const go = (spaceId: string) => void navigate({ to: "/spaces/$spaceId", params: { spaceId } });if (target.kind === "space") {run(task.id, target, {});@@ -125,7 +122,13 @@ export function useStartTask(): {run(task.id, target, { pendingId, onCreated, queued: Boolean(first?.handle) });go(pendingId);} else {- run(task.id, target, { onSpace: go, onNoSpace: () => void navigate({ to: "/home/$taskId", params: { taskId: task.id } }) });+ // This Mac's own Space id (`relay:<machine>`) is not in the Spaces list: the roster+ // swaps it for the `this-mac` row, so `/spaces/relay:<machine>` says "This Space isn't+ // here" (trycua/cua#6363). The task's page is where this Mac's conversation lives, and+ // it also says why when the start fails. No `place`: nothing summons in a Space page+ // the person can't open; the run starts straight from the task.+ run(task.id, target);+ void navigate({ to: "/home/$taskId", params: { taskId: task.id } });}},retry: (task, where) => {