Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

fix(cua-driver): preserve embedded telemetry preference (#3277)

injaneity2c8fa2a73d87
diff --git a/libs/cua-driver/rust/crates/cua-driver-sdk/src/embedded.rs b/libs/cua-driver/rust/crates/cua-driver-sdk/src/embedded.rs
index aa1aa8d307..c205a53680 100644
--- a/libs/cua-driver/rust/crates/cua-driver-sdk/src/embedded.rs
+++ b/libs/cua-driver/rust/crates/cua-driver-sdk/src/embedded.rs
@@ -852,6 +852,8 @@ pub(crate) fn allowed_environment_name(name: &str) -> bool {
| "DBUS_SESSION_BUS_ADDRESS"
| "XAUTHORITY"
| "CUA_LOG"
+ | "CUA_DRIVER_RS_TELEMETRY_ENABLED"
+ | "CUA_TELEMETRY_ENABLED"
)
}
@@ -1196,6 +1198,45 @@ mod tests {
assert!(!allowed_environment_name("NODE_OPTIONS"));
}
+ #[test]
+ fn telemetry_preferences_are_inherited_and_overridable() {
+ assert!(allowed_environment_name("CUA_DRIVER_RS_TELEMETRY_ENABLED"));
+ assert!(allowed_environment_name("cua_telemetry_enabled"));
+
+ let inherited = [
+ ("CUA_DRIVER_RS_TELEMETRY_ENABLED".into(), "1".into()),
+ ("CUA_TELEMETRY_ENABLED".into(), "true".into()),
+ ];
+ let values = merge_safe_environment(inherited.clone(), &[]);
+ assert!(values.iter().any(|variable| {
+ variable.name == "CUA_DRIVER_RS_TELEMETRY_ENABLED" && variable.value == "1"
+ }));
+ assert!(values.iter().any(|variable| {
+ variable.name == "CUA_TELEMETRY_ENABLED" && variable.value == "true"
+ }));
+
+ let values = merge_safe_environment(
+ inherited,
+ &[
+ EmbeddedEnvironmentVariable {
+ name: "CUA_DRIVER_RS_TELEMETRY_ENABLED".into(),
+ value: "0".into(),
+ },
+ EmbeddedEnvironmentVariable {
+ name: "CUA_TELEMETRY_ENABLED".into(),
+ value: "false".into(),
+ },
+ ],
+ );
+
+ assert!(values.iter().any(|variable| {
+ variable.name == "CUA_DRIVER_RS_TELEMETRY_ENABLED" && variable.value == "0"
+ }));
+ assert!(values.iter().any(|variable| {
+ variable.name == "CUA_TELEMETRY_ENABLED" && variable.value == "false"
+ }));
+ }
+
#[test]
fn managed_environment_is_inherited_case_insensitively_but_never_overridden() {
assert!(inherited_managed_environment_name(