Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.
Rust agentai-agentapplecomputer-usecomputer-use-agentcontainerizationcuadesktop-automationhacktoberfestlumemacosmanusoperatorswiftvirtualizationvirtualization-frameworkwindowswindows-sandbox
fix(sandbox): sync httpx client timeout with server-side timeout (#1355)
r33drichards9fbfa8bc38ac
diff --git a/libs/python/cua-sandbox/cua_sandbox/sandbox.py b/libs/python/cua-sandbox/cua_sandbox/sandbox.pyindex 147fff6342..76043b17fa 100644--- a/libs/python/cua-sandbox/cua_sandbox/sandbox.py+++ b/libs/python/cua-sandbox/cua_sandbox/sandbox.py@@ -408,6 +408,7 @@ class Sandbox:disk_gb: Optional[int] = None,region: str = "us-east-1",time_to_start: Optional[float] = None,+ request_timeout: Optional[float] = None,telemetry_enabled: bool = True,) -> "Sandbox":"""Provision a new persistent sandbox and return it connected.@@ -428,6 +429,10 @@ class Sandbox:region: Cloud region (default ``"us-east-1"``).time_to_start: Max seconds to wait for the VM to become reachable(default 600). Only applies to cloud sandboxes.+ request_timeout: Default HTTP request timeout in seconds for+ commands sent to the computer-server (default 30, cloud only).+ Individual commands with a server-side timeout automatically+ extend the client timeout to match.telemetry_enabled: Set to False to disable telemetry for this instance.Example::@@ -449,6 +454,7 @@ class Sandbox:disk_gb=disk_gb,region=region,time_to_start=time_to_start,+ request_timeout=request_timeout,telemetry_enabled=telemetry_enabled,)@@ -526,6 +532,7 @@ class Sandbox:disk_gb: Optional[int] = None,region: str = "us-east-1",time_to_start: Optional[float] = None,+ request_timeout: Optional[float] = None,telemetry_enabled: bool = True,) -> AsyncIterator["Sandbox"]:"""Create an ephemeral sandbox that is automatically destroyed on exit.@@ -542,6 +549,10 @@ class Sandbox:region: Cloud region (default ``"us-east-1"``).time_to_start: Max seconds to wait for the VM to become reachable(default 600). Only applies to cloud sandboxes.+ request_timeout: Default HTTP request timeout in seconds for+ commands sent to the computer-server (default 30, cloud only).+ Individual commands with a server-side timeout automatically+ extend the client timeout to match.Example::@@ -561,6 +572,7 @@ class Sandbox:disk_gb=disk_gb,region=region,time_to_start=time_to_start,+ request_timeout=request_timeout,telemetry_enabled=telemetry_enabled,)try:@@ -975,6 +987,7 @@ class Sandbox:disk_gb: Optional[int] = None,region: str = "us-east-1",time_to_start: Optional[float] = None,+ request_timeout: Optional[float] = None,telemetry_enabled: bool = True,) -> "Sandbox":"""Internal workhorse — all public factories delegate here."""@@ -1041,6 +1054,7 @@ class Sandbox:disk_gb=disk_gb,region=region,time_to_start=time_to_start,+ request_timeout=request_timeout,)sb = cls(transport, name=name, _ephemeral=ephemeral, _telemetry_enabled=telemetry_enableddiff --git a/libs/python/cua-sandbox/cua_sandbox/transport/cloud.py b/libs/python/cua-sandbox/cua_sandbox/transport/cloud.pyindex 9bd3fdb7fe..8ba6f0a0ce 100644--- a/libs/python/cua-sandbox/cua_sandbox/transport/cloud.py+++ b/libs/python/cua-sandbox/cua_sandbox/transport/cloud.py@@ -42,6 +42,7 @@ class CloudTransport(Transport):disk_gb: Optional[int] = None,region: str = "us-east-1",time_to_start: Optional[float] = None,+ request_timeout: Optional[float] = None,):self._name = nameself._api_key_override = api_key@@ -52,6 +53,7 @@ class CloudTransport(Transport):self._disk_gb = disk_gbself._region = regionself._time_to_start = time_to_start if time_to_start is not None else _POLL_TIMEOUT+ self._request_timeout = request_timeout if request_timeout is not None else 30.0self._inner: Optional[HTTPTransport] = Noneself._api_client: Optional[httpx.AsyncClient] = None@@ -136,7 +138,9 @@ class CloudTransport(Transport):# snapshot, so auth must use the source instance name.snap_source = getattr(self._image, "_snapshot_source", None) if self._image else Noneauth_name = snap_source["instance"] if snap_source else self._name- self._inner = HTTPTransport(cs_url, api_key=api_key, container_name=auth_name)+ self._inner = HTTPTransport(+ cs_url, api_key=api_key, container_name=auth_name, timeout=self._request_timeout+ )await self._inner.connect()await self._wait_for_server_ready()diff --git a/libs/python/cua-sandbox/cua_sandbox/transport/http.py b/libs/python/cua-sandbox/cua_sandbox/transport/http.pyindex 22c98f1492..121c591b05 100644--- a/libs/python/cua-sandbox/cua_sandbox/transport/http.py+++ b/libs/python/cua-sandbox/cua_sandbox/transport/http.py@@ -62,7 +62,17 @@ class HTTPTransport(Transport):body = {"command": command}if params:body["params"] = params- resp = await self._client.post("/cmd", json=body)+ # When the caller passes a server-side timeout (e.g. push_timeout for+ # write_bytes, or timeout for run_command), the server may legitimately+ # take that long to respond. Set the httpx read timeout to match so the+ # client doesn't drop the connection before the server finishes.+ server_timeout = (params or {}).get("timeout")+ if server_timeout is not None:+ # Add 10s headroom so the server timeout fires before the client one+ req_timeout = httpx.Timeout(self._timeout, read=float(server_timeout) + 10)+ else:+ req_timeout = None # use client default+ resp = await self._client.post("/cmd", json=body, timeout=req_timeout)resp.raise_for_status()return self._parse_sse(resp.text)