Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

ci: close silent-pass gaps in pinning and Session 0 checks (#4096)

Francesco Bonaccia7ec17af816b
diff --git a/.github/scripts/tests/test_cua_perception_review_pipeline.py b/.github/scripts/tests/test_cua_perception_review_pipeline.py
index 63279d7b83..0c3ee0f696 100644
--- a/.github/scripts/tests/test_cua_perception_review_pipeline.py
+++ b/.github/scripts/tests/test_cua_perception_review_pipeline.py
@@ -40,7 +40,7 @@ def test_review_pipeline_is_valid_pinned_and_nonpublishing() -> None:
}
assert all(access != "write" for access in parsed["permissions"].values())
assert "contents: write" not in text
- uses = re.findall(r"^\s*uses:\s*([^\s#]+)", text, flags=re.MULTILINE)
+ uses = re.findall(r"^\s*(?:-\s+)?uses:\s*([^\s#]+)", text, flags=re.MULTILINE)
assert uses
assert all(re.fullmatch(r"[^@]+@[0-9a-f]{40}", use) for use in uses)
lowered = text.lower()
diff --git a/.github/workflows/ci-cua-driver-contract-clients.yml b/.github/workflows/ci-cua-driver-contract-clients.yml
index 9468a7d58f..90c13c9a56 100644
--- a/.github/workflows/ci-cua-driver-contract-clients.yml
+++ b/.github/workflows/ci-cua-driver-contract-clients.yml
@@ -189,8 +189,9 @@ jobs:
run: |
cargo test --locked -p platform-windows diagnostics::tests:: --lib
if ($LASTEXITCODE -ne 0) { throw "Windows diagnostics tests failed with exit $LASTEXITCODE" }
- cargo test --locked -p cua-driver-sdk session_zero_refuses_runtime_creation_before_platform_dispatch --lib
+ cargo test --locked -p cua-driver-sdk session_zero_refuses_runtime_creation_before_platform_dispatch --lib | Tee-Object -Variable sessionZeroLog
if ($LASTEXITCODE -ne 0) { throw "Session 0 refusal test failed with exit $LASTEXITCODE" }
+ if (-not ($sessionZeroLog -match 'test result: ok\. 1 passed')) { throw "Session 0 refusal filter matched no test" }
cargo run --locked -p cua-driver -- list-tools | Out-Null
if ($LASTEXITCODE -ne 0) { throw "Session 0 list-tools failed with exit $LASTEXITCODE" }
cargo run --locked -p cua-driver -- describe click | Out-Null
diff --git a/.github/workflows/ci-rust-windows.yml b/.github/workflows/ci-rust-windows.yml
index 53009e10a2..2aa97c0a63 100644
--- a/.github/workflows/ci-rust-windows.yml
+++ b/.github/workflows/ci-rust-windows.yml
@@ -168,7 +168,11 @@ jobs:
- name: Prove Session 0 refusal
if: steps.runner-session.outputs.session_id == '0'
working-directory: libs/cua-driver/rust
- run: cargo test -p cua-driver-sdk session_zero_refuses_runtime_creation_before_platform_dispatch --lib --locked
+ shell: pwsh
+ run: |
+ cargo test -p cua-driver-sdk session_zero_refuses_runtime_creation_before_platform_dispatch --lib --locked | Tee-Object -Variable sessionZeroLog
+ if ($LASTEXITCODE -ne 0) { throw "Session 0 refusal test failed with exit $LASTEXITCODE" }
+ if (-not ($sessionZeroLog -match 'test result: ok\. 1 passed')) { throw "Session 0 refusal filter matched no test" }
- name: Prove metadata commands remain desktop-free
working-directory: libs/cua-driver/rust
run: |
diff --git a/libs/cua-driver/examples/jev-use/python/tests/test_authorized_workflow.py b/libs/cua-driver/examples/jev-use/python/tests/test_authorized_workflow.py
index 7370f4d357..db6bce75ae 100644
--- a/libs/cua-driver/examples/jev-use/python/tests/test_authorized_workflow.py
+++ b/libs/cua-driver/examples/jev-use/python/tests/test_authorized_workflow.py
@@ -14,7 +14,7 @@ class AuthorizedWorkflowTest(unittest.TestCase):
).read_text(encoding="utf-8")
def test_actions_are_pinned_to_commits(self) -> None:
- action_refs = re.findall(r"^\s*- uses: [^@\s]+@([^\s]+)", self.workflow, re.MULTILINE)
+ action_refs = re.findall(r"^\s*(?:-\s+)?uses:\s*[^@\s]+@([^\s]+)", self.workflow, re.MULTILINE)
self.assertTrue(action_refs)
self.assertTrue(all(re.fullmatch(r"[0-9a-f]{40}", ref) for ref in action_refs))