Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

fix(cua-driver): stage current skill pack on Windows local installs (#3083)

Francesco Bonaccib4bc58a3a262
diff --git a/libs/cua-driver/scripts/_install-local-rust.sh b/libs/cua-driver/scripts/_install-local-rust.sh
index f59ec78afc..7f9dd6fdfd 100755
--- a/libs/cua-driver/scripts/_install-local-rust.sh
+++ b/libs/cua-driver/scripts/_install-local-rust.sh
@@ -522,7 +522,7 @@ unset _daemon_bin
# Agent skill pack symlinks: NOT auto-created. Run
# `cua-driver skills install --local` to symlink agent dirs to the
-# staged copy at $VERSIONED_DIR/Skills/cua-driver-rs above.
+# staged copy at $VERSIONED_DIR/Skills/cua-driver above.
echo ""
# --- Autostart (optional) ----------------------------------------------
diff --git a/libs/cua-driver/scripts/install-local.ps1 b/libs/cua-driver/scripts/install-local.ps1
index 16e87477cc..8c2738e3c4 100644
--- a/libs/cua-driver/scripts/install-local.ps1
+++ b/libs/cua-driver/scripts/install-local.ps1
@@ -246,12 +246,12 @@ if (Test-Path -LiteralPath $BuiltUiaBinary) {
$installedBinary = $DestBinary
# Stage the skill pack alongside the binary. install-local mirrors what
-# install.ps1 does from a release zip — copies Skills/cua-driver-rs/ from
+# install.ps1 does from a release zip — copies Skills/cua-driver/ from
# the repo into the versioned dir so the `current` junction below
# transparently exposes it to agents.
-$SourceSkills = Join-Path $RepoRoot "Skills\cua-driver-rs"
+$SourceSkills = Join-Path $RepoRoot "Skills\cua-driver"
if (Test-Path -LiteralPath $SourceSkills) {
- $StagedSkills = Join-Path $VersionedDir "Skills\cua-driver-rs"
+ $StagedSkills = Join-Path $VersionedDir "Skills\cua-driver"
if (Test-Path -LiteralPath $StagedSkills) {
Remove-Item -LiteralPath $StagedSkills -Recurse -Force
}
diff --git a/libs/cua-driver/scripts/tests/test_install_local.py b/libs/cua-driver/scripts/tests/test_install_local.py
index 9de244dcf1..2ab5f3303c 100644
--- a/libs/cua-driver/scripts/tests/test_install_local.py
+++ b/libs/cua-driver/scripts/tests/test_install_local.py
@@ -11,6 +11,24 @@ import pytest
INSTALL_LOCAL = Path(__file__).resolve().parents[1] / "_install-local-rust.sh"
LOCAL_SIGNING = INSTALL_LOCAL.with_name("_local-signing.sh")
DISPATCHER = INSTALL_LOCAL.with_name("install-local.sh")
+WINDOWS_INSTALL_LOCAL = INSTALL_LOCAL.with_name("install-local.ps1")
+SKILL_PACK = INSTALL_LOCAL.parents[1] / "rust/Skills/cua-driver"
+
+
+def test_local_installers_stage_the_canonical_skill_pack() -> None:
+ windows = WINDOWS_INSTALL_LOCAL.read_text(encoding="utf-8")
+
+ assert 'Join-Path $RepoRoot "Skills\\cua-driver"' in windows
+ assert 'Join-Path $VersionedDir "Skills\\cua-driver"' in windows
+ assert "Skills\\cua-driver-rs" not in windows
+ assert "Skills/cua-driver-rs" not in INSTALL_LOCAL.read_text(encoding="utf-8")
+ assert {path.name for path in SKILL_PACK.iterdir()} >= {
+ "SKILL.md",
+ "BROWSER.md",
+ "MACOS.md",
+ "WINDOWS.md",
+ "LINUX.md",
+ }
def _write_executable(path: Path, body: str) -> None: