Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

fix(cyclops-cs): stop forcing image pull secret (#7313)

r33drichardsbafe015c9acb
diff --git a/libs/fleet/e2e/sdk-builders.spec.ts b/libs/fleet/e2e/sdk-builders.spec.ts
index d32b455b11..a89c6639fb 100644
--- a/libs/fleet/e2e/sdk-builders.spec.ts
+++ b/libs/fleet/e2e/sdk-builders.spec.ts
@@ -96,7 +96,8 @@ test.describe("SDK builders", () => {
namespace: template.namespace,
name: template.name,
image: template.spec.vmTemplate.containerDiskImage,
- secret: template.spec.vmTemplate.imagePullSecret,
+ imagePullSecretUnset:
+ template.spec.vmTemplate.imagePullSecret === undefined,
firmwareIsEfi: template.spec.vmTemplate.firmware === Firmware.Efi,
services: template.spec.vmTemplate.services?.map(service => ({
name: service.name,
@@ -118,7 +119,7 @@ test.describe("SDK builders", () => {
namespace: "demo-pool",
name: "demo-pool-template",
image: "registry.example/cyclops:v1",
- secret: "ecr-credentials",
+ imagePullSecretUnset: true,
firmwareIsEfi: true,
services: [
{ name: "ssh", targetPort: 22, udp: false },
diff --git a/libs/fleet/src/fleet/pools.ts b/libs/fleet/src/fleet/pools.ts
index 457c01652c..ea191382f8 100644
--- a/libs/fleet/src/fleet/pools.ts
+++ b/libs/fleet/src/fleet/pools.ts
@@ -223,7 +223,6 @@ export function buildTemplateRequest(
): CreateTemplateRequest {
let vmBuilder: VmTemplateBuilderLike = new VmTemplateBuilder()
.containerDiskImage(values.ociImage)
- .imagePullSecret("ecr-credentials")
.cpuCores(values.cpu)
.memory(values.ram)
if (values.firmware === "efi") vmBuilder = vmBuilder.firmware(Firmware.Efi)