Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

fix(cua-driver): stop worker and embedded processes launching Orca on GNOME (#5179)

injaneityc2a42eaaf723
diff --git a/libs/cua-driver/rust/crates/cua-driver-sdk/src/embedded.rs b/libs/cua-driver/rust/crates/cua-driver-sdk/src/embedded.rs
index 373d63cc04..abd692c362 100644
--- a/libs/cua-driver/rust/crates/cua-driver-sdk/src/embedded.rs
+++ b/libs/cua-driver/rust/crates/cua-driver-sdk/src/embedded.rs
@@ -866,6 +866,12 @@ pub(crate) fn allowed_environment_name(name: &str) -> bool {
| "XDG_RUNTIME_DIR"
| "XDG_SESSION_TYPE"
| "DBUS_SESSION_BUS_ADDRESS"
+ | "XDG_CURRENT_DESKTOP"
+ | "XDG_SESSION_DESKTOP"
+ | "DESKTOP_SESSION"
+ | "NO_AT_BRIDGE"
+ | "CUA_DRIVER_RS_DISABLE_A11Y_ADVERTISE"
+ | "CUA_DRIVER_RS_A11Y_ADVERTISE_MODE"
| "XAUTHORITY"
| "CUA_LOG"
| "CUA_DRIVER_RS_HOME"
@@ -1435,6 +1441,39 @@ mod tests {
.any(|variable| variable.name == "AT_SPI_BUS_ADDRESS"));
}
+ #[test]
+ fn desktop_identity_and_accessibility_controls_reach_the_child() {
+ for name in [
+ "XDG_CURRENT_DESKTOP",
+ "XDG_SESSION_DESKTOP",
+ "DESKTOP_SESSION",
+ "NO_AT_BRIDGE",
+ "CUA_DRIVER_RS_DISABLE_A11Y_ADVERTISE",
+ "CUA_DRIVER_RS_A11Y_ADVERTISE_MODE",
+ ] {
+ let inherited = [(name.to_owned(), "inherited".to_owned())];
+ let host = EmbeddedEnvironmentVariable {
+ name: name.into(),
+ value: "host".into(),
+ };
+ for (values, expected) in [
+ (merge_safe_environment(inherited.clone(), &[]), "inherited"),
+ (
+ merge_safe_environment(std::iter::empty(), &[host.clone()]),
+ "host",
+ ),
+ (merge_safe_environment(inherited, &[host]), "host"),
+ ] {
+ let reached: Vec<_> = values
+ .iter()
+ .filter(|variable| variable.name == name)
+ .map(|variable| variable.value.as_str())
+ .collect();
+ assert_eq!(reached, [expected], "{name}");
+ }
+ }
+ }
+
#[test]
fn metadata_validation_requires_same_process_and_contract() {
let metadata = DaemonMetadata {