Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

fix(cua-driver): scope codesign --strict to symlinks in isolated-launch check (#4059)

tylerbrevardd4585e865241
diff --git a/libs/cua-driver/rust/crates/platform-macos/src/browser/platform.rs b/libs/cua-driver/rust/crates/platform-macos/src/browser/platform.rs
index af8cc134ec..4e45e6ba4e 100644
--- a/libs/cua-driver/rust/crates/platform-macos/src/browser/platform.rs
+++ b/libs/cua-driver/rust/crates/platform-macos/src/browser/platform.rs
@@ -293,6 +293,21 @@ fn codesign_identity_matches(details: &str, identifier: &str, team_identifier: &
observed_identifier == Some(identifier) && observed_team == Some(team_identifier)
}
+fn codesign_verification_args(requirement: &str) -> [&str; 4] {
+ // The explicit requirement already pins the Apple anchor, vendor team, and
+ // bundle identifier. Bare `--strict` also enables the `sideband` check,
+ // which rejects Finder/resource-fork metadata, including the
+ // non-removable `com.apple.provenance` attribute that newer macOS releases
+ // attach to stock vendor-signed browsers (#4058). Retain sealed-symlink
+ // validation without requiring sideband hygiene.
+ [
+ "--verify",
+ "--strict=symlinks",
+ "--test-requirement",
+ requirement,
+ ]
+}
+
fn has_trusted_codesign_identity(
executable: &std::path::Path,
identifier: &str,
@@ -302,7 +317,7 @@ fn has_trusted_codesign_identity(
"=anchor apple generic and certificate leaf[subject.OU] = \"{team_identifier}\" and identifier \"{identifier}\""
);
let verified = std::process::Command::new("/usr/bin/codesign")
- .args(["--verify", "--strict", "--test-requirement", &requirement])
+ .args(codesign_verification_args(&requirement))
.arg(executable)
.stdin(Stdio::null())
.stdout(Stdio::null())
@@ -1485,6 +1500,21 @@ mod tests {
));
}
+ #[test]
+ fn vendor_verification_does_not_require_filesystem_metadata_hygiene() {
+ let requirement = "=anchor apple generic and identifier \"com.example.Browser\"";
+ assert_eq!(
+ codesign_verification_args(requirement),
+ [
+ "--verify",
+ "--strict=symlinks",
+ "--test-requirement",
+ requirement
+ ]
+ );
+ assert!(!codesign_verification_args(requirement).contains(&"--strict"));
+ }
+
fn window(window_id: u32, pid: i32, title: &str) -> crate::windows::WindowInfo {
crate::windows::WindowInfo {
window_id,