Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

Fix package build error handling and certificate verification

f-trycuadad7d4c30393
diff --git a/.github/workflows/publish-lume.yml b/.github/workflows/publish-lume.yml
index 3b2311eea5..d90df18e46 100644
--- a/.github/workflows/publish-lume.yml
+++ b/.github/workflows/publish-lume.yml
@@ -114,9 +114,22 @@ jobs:
# Allow codesign to access the certificates (minimal output)
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$KEYCHAIN_PASSWORD" build.keychain > /dev/null 2>&1
- # Verify certificates were imported but only show count, not details
- echo "Verifying signing identity (showing count only)..."
- security find-identity -v -p codesigning | grep -c "valid identities found" || true
+ # Verify certificates were imported
+ echo "Verifying signing identities..."
+ security find-identity -v -p codesigning build.keychain
+
+ # Verify specific certificates exist
+ if ! security find-identity -v -p codesigning build.keychain | grep -q "Developer ID Application: ${{ secrets.DEVELOPER_NAME }}"; then
+ echo "Error: Developer ID Application certificate not found"
+ exit 1
+ fi
+
+ if ! security find-identity -v -p codesigning build.keychain | grep -q "Developer ID Installer: ${{ secrets.DEVELOPER_NAME }}"; then
+ echo "Error: Developer ID Installer certificate not found"
+ exit 1
+ fi
+
+ echo "All required certificates verified successfully"
# Clean up certificate files
rm application.p12 installer.p12
diff --git a/libs/lume/scripts/build/build-release-notarized.sh b/libs/lume/scripts/build/build-release-notarized.sh
index 018570b203..603446b790 100755
--- a/libs/lume/scripts/build/build-release-notarized.sh
+++ b/libs/lume/scripts/build/build-release-notarized.sh
@@ -72,12 +72,23 @@ cp -f .build/release/lume "$TEMP_ROOT/usr/local/bin/"
# Build the installer package
log "essential" "Building installer package..."
-pkgbuild --root "$TEMP_ROOT" \
+if ! pkgbuild --root "$TEMP_ROOT" \
--identifier "com.trycua.lume" \
--version "1.0" \
--install-location "/" \
--sign "$CERT_INSTALLER_NAME" \
- ./.release/lume.pkg 2> /dev/null
+ ./.release/lume.pkg; then
+ log "error" "Failed to build installer package"
+ exit 1
+fi
+
+# Verify the package was created
+if [ ! -f "./.release/lume.pkg" ]; then
+ log "error" "Package file ./.release/lume.pkg was not created"
+ exit 1
+fi
+
+log "essential" "Package created successfully"
# Submit for notarization using stored credentials
log "essential" "Submitting for notarization..."