Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

fix(cua-driver): keep list_windows valid when macOS reports non-finite window bounds (#5125)

injaneitye1091afef672
diff --git a/libs/cua-driver/rust/crates/platform-macos/src/windows.rs b/libs/cua-driver/rust/crates/platform-macos/src/windows.rs
index 461228dfc3..ba6f3943ea 100644
--- a/libs/cua-driver/rust/crates/platform-macos/src/windows.rs
+++ b/libs/cua-driver/rust/crates/platform-macos/src/windows.rs
@@ -315,6 +315,7 @@ fn get_bounds_num(
None
}
})
+ .filter(|v| v.is_finite())
.unwrap_or(0.0)
}
@@ -523,6 +524,39 @@ fn poll_until_no_menu(
mod tests {
use super::*;
+ #[test]
+ fn bounds_numbers_preserve_finite_values_and_default_non_finite_or_missing_values() {
+ use core_foundation::{
+ base::TCFType, dictionary::CFDictionary, number::CFNumber, string::CFString,
+ };
+
+ let bounds = CFDictionary::from_CFType_pairs(&[
+ (
+ CFString::new("X").as_CFType(),
+ CFNumber::from(12.5).as_CFType(),
+ ),
+ (
+ CFString::new("Y").as_CFType(),
+ CFNumber::from(f64::INFINITY).as_CFType(),
+ ),
+ (
+ CFString::new("Width").as_CFType(),
+ CFNumber::from(f64::NAN).as_CFType(),
+ ),
+ (
+ CFString::new("Height").as_CFType(),
+ CFNumber::from(f64::NEG_INFINITY).as_CFType(),
+ ),
+ ]);
+ let bounds = unsafe { CFDictionary::wrap_under_get_rule(bounds.as_concrete_TypeRef()) };
+
+ assert_eq!(get_bounds_num(&bounds, "X"), 12.5);
+ assert_eq!(get_bounds_num(&bounds, "Y"), 0.0);
+ assert_eq!(get_bounds_num(&bounds, "Width"), 0.0);
+ assert_eq!(get_bounds_num(&bounds, "Height"), 0.0);
+ assert_eq!(get_bounds_num(&bounds, "Missing"), 0.0);
+ }
+
#[test]
fn space_membership_checks_all_spaces_for_a_window() {
assert_eq!(window_on_current_space(Some(&[2, 4]), Some(4)), Some(true));