Skip to content

armgit / cua

Public Imported from GitHub
0

Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.

ci: stop superseded release-metadata runs from failing validate (#4530)

ddupontf0e20e852e32
diff --git a/.github/scripts/tests/test_cua_driver_release_wiring.py b/.github/scripts/tests/test_cua_driver_release_wiring.py
index ef0625af2f..e446fde8bd 100644
--- a/.github/scripts/tests/test_cua_driver_release_wiring.py
+++ b/.github/scripts/tests/test_cua_driver_release_wiring.py
@@ -1098,6 +1098,19 @@ fi
release_metadata,
)
+ def test_installer_compatibility_never_cancels_a_superseded_caller(
+ self,
+ ) -> None:
+ # A cancelled call fails the caller's required `validate` check, and
+ # a failed duplicate on the same head commit blocks the merge.
+ for path in (
+ ".github/workflows/ci-cua-driver-installer-compat.yml",
+ ".github/workflows/ci-release-metadata.yml",
+ ):
+ workflow = self.read(path)
+ self.assertNotIn("\nconcurrency:", workflow, path)
+ self.assertNotIn("cancel-in-progress: true", workflow, path)
+
def test_lume_uses_the_same_draft_finalizer(self) -> None:
workflow = self.read(".github/workflows/cd-swift-lume.yml")
diff --git a/.github/workflows/ci-cua-driver-installer-compat.yml b/.github/workflows/ci-cua-driver-installer-compat.yml
index c91739da98..c117adf683 100644
--- a/.github/workflows/ci-cua-driver-installer-compat.yml
+++ b/.github/workflows/ci-cua-driver-installer-compat.yml
@@ -21,11 +21,13 @@ permissions:
contents: read
pull-requests: read
-# In a reusable call, github.workflow names the caller, so each caller keeps
-# its own group.
-concurrency:
- group: cua-driver-installer-compat-${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.ref || github.run_id }}
- cancel-in-progress: true
+# No concurrency group. In a reusable call the group would belong to the
+# caller's run, and "CI: Release metadata" starts several runs for one pull
+# request at once (opened, labeled, edited, synchronize). Cancelling the older
+# ones made each superseded run's `validate` see `cancelled` and fail, and that
+# failed `validate` check on the head commit blocked the merge even after the
+# newest run passed. Every run now finishes. For most pull requests the scope
+# job skips the installer matrix, so duplicates cost little.
jobs:
scope: