Scale computer-use 2.0 with open-source drivers, cross-OS sandboxes, and benchmarks for training, evaluation, and data generation.
Rust agentai-agentapplecomputer-usecomputer-use-agentcontainerizationcuadesktop-automationhacktoberfestlumemacosmanusoperatorswiftvirtualizationvirtualization-frameworkwindowswindows-sandbox
fix(lume): preserve legacy multipart disk bytes during assembly (#4714)
injaneityffaa073ad9a2
diff --git a/libs/lume/src/ContainerRegistry/ImageContainerRegistry.swift b/libs/lume/src/ContainerRegistry/ImageContainerRegistry.swiftindex fb18c8e348..8cae1cd20c 100644--- a/libs/lume/src/ContainerRegistry/ImageContainerRegistry.swift+++ b/libs/lume/src/ContainerRegistry/ImageContainerRegistry.swift@@ -1912,7 +1912,7 @@ class ImageContainerRegistry: ImageRegistry, @unchecked Sendable {"Cache pull simulation completed successfully with partition table preservation")}- private func copyFromCache(manifest: Manifest, manifestId: String, to destination: URL)+ func copyFromCache(manifest: Manifest, manifestId: String, to destination: URL)async throws{Logger.debug("Copying from cache...")@@ -2203,15 +2203,6 @@ class ImageContainerRegistry: ImageRegistry, @unchecked Sendable {// Finalize progress, close handle (done by defer)reassemblyProgressLogger.logProgress(current: 1.0, context: "Reassembly Complete")- // Add test patterns at the beginning and end of the file- Logger.info("Writing test patterns to sparse file to verify integrity...")- let testPattern = "LUME_TEST_PATTERN".data(using: .utf8)!- try outputHandle.seek(toOffset: 0)- try outputHandle.write(contentsOf: testPattern)- try outputHandle.seek(toOffset: sizeForTruncate - UInt64(testPattern.count))- try outputHandle.write(contentsOf: testPattern)- try outputHandle.synchronize()-// Ensure handle is properly synchronized before closingtry outputHandle.synchronize()diff --git a/libs/lume/tests/LegacyDiskAssemblyTests.swift b/libs/lume/tests/LegacyDiskAssemblyTests.swiftnew file mode 100644index 0000000000..9749aa3c7d--- /dev/null+++ b/libs/lume/tests/LegacyDiskAssemblyTests.swift@@ -0,0 +1,80 @@+import Foundation+import Testing++@testable import lume++struct LegacyDiskAssemblyTests {+ @Test("legacy LZ4 assembly preserves disk bytes and cached output",+ arguments: [false, true], [false, true])+ func preservesBytes(cachingEnabled: Bool, trailingZeroChunk: Bool) async throws {+ let root = FileManager.default.temporaryDirectory+ .appendingPathComponent("lume-legacy-assembly-\(UUID().uuidString)")+ try FileManager.default.createDirectory(at: root, withIntermediateDirectories: true)+ defer { try? FileManager.default.removeItem(at: root) }++ let cache = root.appendingPathComponent("cache")+ let registry = ImageContainerRegistry(+ registry: "unused.invalid", organization: "fixture",+ cacheDirectory: cache, cachingEnabled: cachingEnabled)+ let manifestId = "legacy-lz4-fixture"+ let first = Data((0..<64).map { UInt8($0 + 1) })+ let last = trailingZeroChunk+ ? Data(count: 4 * 1024 * 1024)+ : Data((0..<73).map { UInt8(255 - $0) })+ let expected = first + last+ var layers: [Layer] = []+ for (index, bytes) in [first, last].enumerated() {+ let compressed = try (bytes as NSData).compressed(using: .lz4) as Data+ let layer = Layer(+ mediaType: "application/octet-stream+lz4", digest: "sha256:part-\(index)",+ size: compressed.count, annotations: nil)+ let path = registry.getCachedLayerPath(manifestId: manifestId, digest: layer.digest)+ try FileManager.default.createDirectory(+ at: path.deletingLastPathComponent(), withIntermediateDirectories: true)+ try compressed.write(to: path)+ layers.append(layer)+ }+ let config = try JSONSerialization.data(withJSONObject: [+ "annotations": ["com.trycua.lume.disk.uncompressed_size": String(expected.count)]+ ])+ let configLayer = Layer(+ mediaType: "application/vnd.oci.image.config.v1+json", digest: "sha256:config",+ size: config.count, annotations: nil)+ try config.write(to: registry.getCachedLayerPath(+ manifestId: manifestId, digest: configLayer.digest))+ layers.append(configLayer)+ let manifest = Manifest(+ layers: layers, config: configLayer,+ mediaType: "application/vnd.oci.image.manifest.v1+json",+ schemaVersion: 2, annotations: nil)++ let cold = root.appendingPathComponent("cold")+ try FileManager.default.createDirectory(at: cold, withIntermediateDirectories: true)+ try await registry.copyFromCache(manifest: manifest, manifestId: manifestId, to: cold)+ try assertDisk(cold.appendingPathComponent("disk.img"), equals: expected)++ let assembled = registry.getCachedLayerPath(manifestId: manifestId, digest: "unused")+ .deletingLastPathComponent().appendingPathComponent("disk.img.reassembled")+ #expect(FileManager.default.fileExists(atPath: assembled.path) == cachingEnabled)+ if cachingEnabled {+ try assertDisk(assembled, equals: expected)+ // The warm path must serve the assembled artifact, not re-read the parts.+ for layer in layers where layer.mediaType == "application/octet-stream+lz4" {+ #expect(!FileManager.default.fileExists(atPath: registry.getCachedLayerPath(+ manifestId: manifestId, digest: layer.digest).path))+ }+ let warm = root.appendingPathComponent("warm")+ try FileManager.default.createDirectory(at: warm, withIntermediateDirectories: true)+ try await registry.copyFromCache(manifest: manifest, manifestId: manifestId, to: warm)+ try assertDisk(warm.appendingPathComponent("disk.img"), equals: expected)+ }+ }++ private func assertDisk(_ url: URL, equals expected: Data) throws {+ let actual = try Data(contentsOf: url)+ #expect(actual.count == expected.count)+ #expect(actual.prefix(32) == expected.prefix(32))+ #expect(actual.suffix(32) == expected.suffix(32))+ #expect(actual.elementsEqual(expected), "assembled disk must preserve every source byte")+ }+}