Skip to content

CubeLoop — a Pythonic, async-native agent harness core designed for high performance, readability, and production-grade persistence.

fix(session): guard dirty checkpoint completion

xfgongcce3e82a4945
diff --git a/cubeloop/agent/agent.py b/cubeloop/agent/agent.py
index cd4050e..33d39bc 100644
--- a/cubeloop/agent/agent.py
+++ b/cubeloop/agent/agent.py
@@ -379,6 +379,8 @@ class Agent(Generic[TMessage]):
return _sink
async def _dispatch_outcome(self, outcome: RunOutcome | None, run_id: str) -> None:
+ if self.session._checkpoint_write_failed:
+ return
if outcome == "complete":
run_messages = [m for m in self._state.messages if m.run_id == run_id]
try:
diff --git a/cubeloop/providers/base.py b/cubeloop/providers/base.py
index bcee296..50d6b44 100644
--- a/cubeloop/providers/base.py
+++ b/cubeloop/providers/base.py
@@ -13,6 +13,7 @@ from typing import (
Literal,
Protocol,
TypeVar,
+ cast,
runtime_checkable,
)
@@ -917,7 +918,7 @@ class BoundModel:
if options is not None and options.on_model_attempt is not None:
result = options.on_model_attempt(self.spec)
if inspect.isawaitable(result):
- await result
+ _ = await cast(Awaitable[Any], result)
return await self.provider.generate(
self.spec,
messages,
diff --git a/cubeloop/session/session.py b/cubeloop/session/session.py
index bb2daf4..3d08ab7 100644
--- a/cubeloop/session/session.py
+++ b/cubeloop/session/session.py
@@ -134,15 +134,15 @@ class ExecutionSession:
data = await self._agent.checkpointer.load(self._agent.thread_id)
if data is None:
return None
- messages = list(data.messages)
- extra = dict(data.extra)
- self._agent._state._messages = messages
+ installed = copy.deepcopy(data)
+ exposed = copy.deepcopy(data)
+ self._agent._state._messages = list(installed.messages)
self._agent._extra.clear()
- self._agent._extra.update(extra)
+ self._agent._extra.update(installed.extra)
self._agent._checkpoint_loaded = True
self._drop_memory_input_receipts()
self._checkpoint_write_failed = False
- return data
+ return exposed
def request_cancel(self) -> None:
if not self._accepting_cancel:
diff --git a/cubeloop/session/turn_execution_context.py b/cubeloop/session/turn_execution_context.py
index 8bff829..728d0b1 100644
--- a/cubeloop/session/turn_execution_context.py
+++ b/cubeloop/session/turn_execution_context.py
@@ -16,6 +16,10 @@ def _freeze(value: Any) -> Any:
return MappingProxyType({key: _freeze(item) for key, item in value.items()})
if isinstance(value, list):
return tuple(_freeze(item) for item in value)
+ if isinstance(value, tuple):
+ return tuple(_freeze(item) for item in value)
+ if isinstance(value, (set, frozenset)):
+ return frozenset(_freeze(item) for item in value)
if hasattr(value, "model_dump"):
return FrozenObject(_freeze(value.model_dump(mode="python")))
return value
diff --git a/tests/agent/test_execution_session.py b/tests/agent/test_execution_session.py
index 428917b..818bdc0 100644
--- a/tests/agent/test_execution_session.py
+++ b/tests/agent/test_execution_session.py
@@ -519,10 +519,11 @@ async def test_checkpoint_message_write_failure_marks_history_inconsistent() ->
),
_answer("next attempt"),
)
+ checkpointer = FailingToolResultCheckpointer()
agent = Agent(
model=provider.model("faux-model"),
tools=[tool],
- checkpointer=FailingToolResultCheckpointer(),
+ checkpointer=checkpointer,
thread_id="thread-1",
)
@@ -539,6 +540,7 @@ async def test_checkpoint_message_write_failure_marks_history_inconsistent() ->
assert retry.outcome == "failed"
assert retry.history_consistent is False
assert retry.checkpoint_committed is False
+ assert checkpointer._runs["thread-1"]["run-2"].completed_at is None
@pytest.mark.asyncio
@@ -723,6 +725,37 @@ async def test_load_checkpoint_restores_extra_in_place_even_without_messages() -
assert persisted.extra == {"todo": ["ship"], "memory": "pinned"}
+async def test_load_checkpoint_isolates_storage_agent_and_return_value() -> None:
+ checkpointer = MemoryCheckpointer()
+ stored = UserMessage(
+ content=[TextContent(text="stored")],
+ metadata={"nested": {"value": 1}},
+ run_id="run-1",
+ )
+ await checkpointer.append("thread-1", [stored])
+ await checkpointer.save_extra("thread-1", {"nested": {"value": 1}})
+ agent = Agent(
+ model=_provider(_answer()).model("faux-model"),
+ checkpointer=checkpointer,
+ thread_id="thread-1",
+ )
+
+ loaded = await agent.session.load_checkpoint()
+ assert loaded is not None
+ loaded.messages[0].content[0].text = "returned"
+ loaded.extra["nested"]["value"] = 2
+
+ assert agent.state.messages[0].content[0].text == "stored"
+ assert agent.session.state_context["nested"]["value"] == 1
+ agent.state.messages[0].content[0].text = "agent"
+ agent.session.state_context["nested"]["value"] = 3
+ durable = await checkpointer.load("thread-1")
+ assert durable is not None
+ assert durable.messages[0].content[0].text == "stored"
+ assert durable.extra["nested"]["value"] == 1
+
+
@pytest.mark.asyncio
async def test_load_checkpoint_failure_does_not_partially_replace_live_state() -> None:
class BrokenCheckpointer(MemoryCheckpointer):
diff --git a/tests/agent/test_session_input.py b/tests/agent/test_session_input.py
index 933ca6c..9e3b50e 100644
--- a/tests/agent/test_session_input.py
+++ b/tests/agent/test_session_input.py
@@ -230,7 +230,7 @@ async def test_session_input_id_overrides_caller_steering_key() -> None:
assert agent.session.cancel_input("owned-id").status == "cancelled"
release.set()
- await task
+ _ = await task
assert not any(
message.metadata.get("input_id") == "owned-id"
for message in agent.state.messages
diff --git a/tests/agent/test_turn_execution_context.py b/tests/agent/test_turn_execution_context.py
index f64d53b..6e3305e 100644
--- a/tests/agent/test_turn_execution_context.py
+++ b/tests/agent/test_turn_execution_context.py
@@ -21,6 +21,7 @@ from cubeloop.providers.base import (
from cubeloop.providers.faux import FauxProvider
from cubeloop.providers.fallback import FallbackBoundModel
from cubeloop.session import TurnExecutionContext
+from cubeloop.session.turn_execution_context import FrozenObject, _freeze
class _Args(BaseModel):
@@ -236,6 +237,22 @@ def test_message_view_preserves_tool_result_request_fields() -> None:
assert message.details["code"] == "denied"
+def test_freeze_recurses_through_tuples_and_sets() -> None:
+ class Nested(BaseModel):
+ items: tuple[dict[str, list[int]], ...]
+ labels: set[str]
+
+ frozen = _freeze(Nested(items=({"values": [1]},), labels={"a"}))
+
+ assert isinstance(frozen, FrozenObject)
+ assert frozen.items[0]["values"] == (1,)
+ assert frozen.labels == frozenset({"a"})
+ with pytest.raises(TypeError):
+ frozen.items[0]["values"] = (2,)
+ with pytest.raises(AttributeError):
+ frozen.labels.add("b")
+
+
@pytest.mark.asyncio
async def test_resolved_tool_extension_updates_public_session_context() -> None:
async def execute(tool_call_id, args, *, signal=None, on_update=None):