Where agent teams gather. Cross-platform team chat where AI agents are first-class teammates — with cloud or bring-your-own (Claude Code / Codex) brains.
TypeScript
fix(embeddings): stop backfill retry loop (#56)
LILAC903ec667efb4
diff --git a/server/src/__tests__/agents-embeddings.test.ts b/server/src/__tests__/agents-embeddings.test.tsnew file mode 100644index 0000000..b5bcd19--- /dev/null+++ b/server/src/__tests__/agents-embeddings.test.ts@@ -0,0 +1,56 @@+import { after, afterEach, test } from 'node:test'+import assert from 'node:assert/strict'++process.env.OPENAI_API_KEY ??= 'test-key'++const { pool } = await import('../db/pool.js')+const {+ __setEmbedTextOverrideForTesting,+ backfillMemoryEmbeddings,+} = await import('../agents/embeddings.js')++type PoolQueryFn = typeof pool.query+const savedQuery = pool.query++afterEach(() => {+ __setEmbedTextOverrideForTesting(null)+ ;(pool as unknown as { query: PoolQueryFn }).query = savedQuery+})++after(async () => {+ await pool.end()+})++test('backfillMemoryEmbeddings advances past a full batch of failed embeddings', async () => {+ const attempts = new Map<string, number>()+ let pageQueries = 0++ __setEmbedTextOverrideForTesting((body) => {+ attempts.set(body, (attempts.get(body) ?? 0) + 1)+ return null+ })++ ;(pool as unknown as { query: PoolQueryFn }).query = (async (sql: string, params?: unknown[]) => {+ if (sql.includes('FROM pg_extension')) return { rows: [{ exists: true }] }+ if (!sql.includes('FROM agent_workspace')) throw new Error(`unexpected query: ${sql}`)++ pageQueries+++ if (pageQueries === 1) {+ assert.deepEqual(params, [2, null, null])+ return {+ rows: [+ { agent_id: 'agent-a', path: 'memory/a', body: 'first' },+ { agent_id: 'agent-b', path: 'memory/b', body: 'second' },+ ],+ }+ }++ assert.deepEqual(params, [2, 'agent-b', 'memory/b'])+ return { rows: [] }+ }) as unknown as PoolQueryFn++ await backfillMemoryEmbeddings({ batchSize: 2, delayMs: 0 })++ assert.equal(pageQueries, 2)+ assert.deepEqual([...attempts], [['first', 1], ['second', 1]])+})diff --git a/server/src/agents/embeddings.ts b/server/src/agents/embeddings.tsindex fa4e573..afc576a 100644--- a/server/src/agents/embeddings.ts+++ b/server/src/agents/embeddings.ts@@ -83,31 +83,44 @@ export async function backfillMemoryEmbeddings(opts: { batchSize?: number; delayif (!(await hasPgVector())) returnlet processed = 0let failed = 0+ let afterAgentId: string | null = null+ let afterPath: string | null = nullwhile (true) {- const { rows } = await pool.query<{ agent_id: string; path: string; body: string }>(+ const result: { rows: Array<{ agent_id: string; path: string; body: string }> } = await pool.query(`SELECT agent_id, path, bodyFROM agent_workspaceWHERE path LIKE 'memory/%' AND embedding IS NULL AND body <> ''+ AND ($2::text IS NULL OR (agent_id, path) > ($2::text, $3::text))+ ORDER BY agent_id, pathLIMIT $1`,- [batchSize],+ [batchSize, afterAgentId, afterPath],)+ const rows: Array<{ agent_id: string; path: string; body: string }> = result.rowsif (rows.length === 0) breakfor (const r of rows) {- const vec = await embedText(r.body)- if (!vec) { failed++; continue }try {- await pool.query(- `UPDATE agent_workspace SET embedding = $1::vector- WHERE agent_id = $2 AND path = $3`,- [vec, r.agent_id, r.path],- )- processed++- } catch (e) {- failed++- console.warn('[embed:backfill] UPDATE failed for', r.path, e instanceof Error ? e.message : String(e))+ const vec = await embedText(r.body)+ if (!vec) {+ failed+++ continue+ }+ try {+ await pool.query(+ `UPDATE agent_workspace SET embedding = $1::vector+ WHERE agent_id = $2 AND path = $3`,+ [vec, r.agent_id, r.path],+ )+ processed+++ } catch (e) {+ failed+++ console.warn('[embed:backfill] UPDATE failed for', r.path, e instanceof Error ? e.message : String(e))+ }+ } finally {+ if (delayMs > 0) await new Promise((res) => setTimeout(res, delayMs))}- if (delayMs > 0) await new Promise((res) => setTimeout(res, delayMs))}+ afterAgentId = rows[rows.length - 1].agent_id+ afterPath = rows[rows.length - 1].pathif (rows.length < batchSize) break}if (processed + failed > 0) {