Skip to content

armgit / dashy

Public Imported from GitHub
0

πŸš€ A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!

:lock: Properly deregisters event listener on destroy

Alicia Sykes051ed1841c20
diff --git a/src/components/Widgets/EmbedWidget.vue b/src/components/Widgets/EmbedWidget.vue
index 633b74e2..33022688 100644
--- a/src/components/Widgets/EmbedWidget.vue
+++ b/src/components/Widgets/EmbedWidget.vue
@@ -35,13 +35,8 @@ export default {
this.initiate();
},
beforeDestroy() {
- if (this.eventListener) {
- window.removeEventListener(this.eventListener);
- }
+ window.removeEventListener('load', this.injectHtml);
},
- data: () => ({
- eventListener: null,
- }),
methods: {
/* Injects users content */
injectHtml() {
@@ -70,9 +65,7 @@ export default {
if (document.readyState === 'complete' || document.readyState === 'loaded') {
this.injectHtml();
} else {
- this.eventListener = window.addEventListener('load', () => {
- this.injectHtml();
- });
+ window.addEventListener('load', this.injectHtml);
}
},
update() {