Skip to content

armgit / dashy

Public Imported from GitHub
0

πŸš€ A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!

✨ Adds "New Window" as opening method (#1970)

Alicia Sykesb5787020350f
diff --git a/src/assets/interface-icons/open-new-window.svg b/src/assets/interface-icons/open-new-window.svg
new file mode 100644
index 00000000..7f52d713
--- /dev/null
+++ b/src/assets/interface-icons/open-new-window.svg
@@ -0,0 +1 @@
+<svg aria-hidden="true" focusable="false" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path fill="currentColor" d="M464 0H144a48 48 0 0 0-48 48v48H48A48 48 0 0 0 0 144v320a48 48 0 0 0 48 48h320a48 48 0 0 0 48-48v-48h48a48 48 0 0 0 48-48V48a48 48 0 0 0-48-48zM368 464H48V144h48v272a48 48 0 0 0 48 48h272v0h-48zm96-96H144V48h320v320z"/></svg>
\ No newline at end of file
diff --git a/src/assets/locales/en.json b/src/assets/locales/en.json
index e2edc75e..27b3d9a2 100644
--- a/src/assets/locales/en.json
+++ b/src/assets/locales/en.json
@@ -238,6 +238,7 @@
"modal": "Pop-Up Modal",
"workspace": "Workspace View",
"clipboard": "Copy to Clipboard",
+ "newwindow": "New Window",
"options-section-title": "Options",
"edit-item": "Edit",
"move-item": "Copy or Move",
diff --git a/src/components/LinkItems/Item.vue b/src/components/LinkItems/Item.vue
index 5ddc8d87..36ab15f5 100644
--- a/src/components/LinkItems/Item.vue
+++ b/src/components/LinkItems/Item.vue
@@ -120,6 +120,7 @@ export default {
case 'modal': return '"\\f2d0"';
case 'workspace': return '"\\f0b1"';
case 'clipboard': return '"\\f0ea"';
+ case 'newwindow': return '"\\f2d2"';
default: return '"\\f054"';
}
},
diff --git a/src/components/LinkItems/ItemContextMenu.vue b/src/components/LinkItems/ItemContextMenu.vue
index e11ad77d..278c4eaf 100644
--- a/src/components/LinkItems/ItemContextMenu.vue
+++ b/src/components/LinkItems/ItemContextMenu.vue
@@ -27,6 +27,10 @@
<ClipboardOpenIcon />
<span>{{ $t('context-menus.item.clipboard') }}</span>
</li>
+ <li @click="launch('newwindow')">
+ <NewWindowOpenIcon />
+ <span>{{ $t('context-menus.item.newwindow') }}</span>
+ </li>
</ul>
<!-- Edit Options -->
<ul class="menu-section" v-bind:class="{ disabled: !isEditAllowed }">
@@ -60,6 +64,7 @@ import NewTabOpenIcon from '@/assets/interface-icons/open-new-tab.svg';
import IframeOpenIcon from '@/assets/interface-icons/open-iframe.svg';
import WorkspaceOpenIcon from '@/assets/interface-icons/open-workspace.svg';
import ClipboardOpenIcon from '@/assets/interface-icons/open-clipboard.svg';
+import NewWindowOpenIcon from '@/assets/interface-icons/open-new-window.svg';
export default {
name: 'ContextMenu',
@@ -72,6 +77,7 @@ export default {
IframeOpenIcon,
WorkspaceOpenIcon,
ClipboardOpenIcon,
+ NewWindowOpenIcon,
},
props: {
posX: Number, // The X coordinate for positioning
diff --git a/src/components/LinkItems/ItemOpenMethodIcon.vue b/src/components/LinkItems/ItemOpenMethodIcon.vue
index 4909ccf0..83250b50 100644
--- a/src/components/LinkItems/ItemOpenMethodIcon.vue
+++ b/src/components/LinkItems/ItemOpenMethodIcon.vue
@@ -8,6 +8,7 @@
<ParentOpenIcon v-else-if="openingMethod === 'parent'" />
<TopOpenIcon v-else-if="openingMethod === 'top'" />
<ClipboardOpenIcon v-else-if="openingMethod === 'clipboard'" />
+ <NewWindowOpenIcon v-else-if="openingMethod === 'newwindow'" />
<UnknownIcon v-else />
</div>
<div v-if="hotkey" :class="`hotkey-denominator ${makeClass(position, isSmall, isTransparent)}`">
@@ -27,12 +28,13 @@ import WorkspaceOpenIcon from '@/assets/interface-icons/open-workspace.svg';
import ParentOpenIcon from '@/assets/interface-icons/open-parent.svg';
import TopOpenIcon from '@/assets/interface-icons/open-top.svg';
import ClipboardOpenIcon from '@/assets/interface-icons/open-clipboard.svg';
+import NewWindowOpenIcon from '@/assets/interface-icons/open-new-window.svg';
import UnknownIcon from '@/assets/interface-icons/unknown-icon.svg';
export default {
name: 'ItemOpenMethodIcon',
props: {
- openingMethod: String, // newtab | sametab | parent | top | modal | workspace
+ openingMethod: String, // newtab | sametab | parent | top | modal | workspace | newwindow
isSmall: Boolean, // If true, will apply small class
position: String, // Position classes: top, bottom, left, right
isTransparent: Boolean, // If true, will apply opacity
@@ -55,6 +57,7 @@ export default {
ParentOpenIcon,
TopOpenIcon,
ClipboardOpenIcon,
+ NewWindowOpenIcon,
UnknownIcon,
},
};
diff --git a/src/mixins/ItemMixin.js b/src/mixins/ItemMixin.js
index 35518ff4..69e6e6a5 100644
--- a/src/mixins/ItemMixin.js
+++ b/src/mixins/ItemMixin.js
@@ -79,7 +79,7 @@ export default {
const nothing = '#';
const url = this.url || this.item.url || nothing;
if (this.isEditMode) return nothing;
- const noAnchorNeeded = ['modal', 'workspace', 'clipboard'];
+ const noAnchorNeeded = ['modal', 'workspace', 'clipboard', 'newwindow'];
return noAnchorNeeded.includes(this.accumulatedTarget) ? nothing : url;
},
/* Pulls together all user options, returns URL + Get params for ping endpoint */
@@ -181,6 +181,9 @@ export default {
case 'clipboard':
this.copyToClipboard(url);
break;
+ case 'newwindow':
+ window.open(url, '_blank', 'noopener,noreferrer');
+ break;
default: window.open(url, '_blank');
}
},
diff --git a/src/utils/ConfigSchema.json b/src/utils/ConfigSchema.json
index 514c4cf4..c010f73f 100644
--- a/src/utils/ConfigSchema.json
+++ b/src/utils/ConfigSchema.json
@@ -151,7 +151,10 @@
"newtab",
"sametab",
"parent",
- "top"
+ "top",
+ "newwindow",
+ "",
+ null
],
"default": "newtab",
"description": "Where / how the item is opened when it's clicked"
@@ -546,7 +549,7 @@
{ "required": ["password"] }
]
}
- },
+ },
"enableOidc": {
"title": "Enable OIDC?",
"type": "boolean",
@@ -1064,7 +1067,7 @@
},
"target": {
"title": "Opening Method",
- "type": "string",
+ "type": ["string", "null"],
"enum": [
"newtab",
"sametab",
@@ -1072,7 +1075,10 @@
"top",
"modal",
"workspace",
- "clipboard"
+ "clipboard",
+ "newwindow",
+ "",
+ null
],
"default": "newtab",
"description": "Where / how the item is opened when it's clicked"