Skip to content

armgit / dashy

Public Imported from GitHub
0

πŸš€ A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!

🩹 Fix footer hidden after switching views

Alicia Sykese69d3f34c2e1
diff --git a/src/App.vue b/src/App.vue
index 097ba656..21796dac 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -18,6 +18,7 @@ import LoadingScreen from '@/components/PageStrcture/LoadingScreen.vue';
import { welcomeMsg } from '@/utils/logging/CoolConsole';
import ErrorHandler from '@/utils/logging/ErrorHandler';
import { syncPageMeta } from '@/utils/PageMeta';
+import { viewFromPath } from '@/utils/config/ConfigHelpers';
import Keys from '@/utils/StoreMutations';
import {
localStorageKeys,
@@ -59,8 +60,9 @@ export default {
footerText() {
return this.pageInfo && this.pageInfo.footer ? this.pageInfo.footer : '';
},
- /* Footer renders only when the user has set text/html */
+ /* Footer renders only when there's text AND we're not on workspace */
footerVisible() {
+ if (viewFromPath(this.$route.path) === 'workspace') return false;
return !!this.footerText;
},
/* Determine if splash screen should be shown */
diff --git a/src/store.js b/src/store.js
index 8216c2d8..f5ff3056 100644
--- a/src/store.js
+++ b/src/store.js
@@ -462,6 +462,7 @@ const store = createStore({
return { ...emptyConfig };
}
// Inherit shared appConfig + pages from root, but override theme per sub-page
+ // TODO: Actually, need to think about which props it is totally safe for a sub-config to inherit.
const theme = configContent?.appConfig?.theme || root.appConfig?.theme || 'default';
configContent.appConfig = { ...root.appConfig, theme };
configContent.pages = root.pages;
diff --git a/src/views/Workspace.vue b/src/views/Workspace.vue
index 06e43adc..f6ff635b 100644
--- a/src/views/Workspace.vue
+++ b/src/views/Workspace.vue
@@ -101,7 +101,4 @@ export default {
.work-space {
min-height: fit-content;
}
-:global(footer) {
- display: none;
-}
</style>