PostgreSQL backup tool with Point-In-Time-Recovery and restore verification
TypeScript backupbackupsdatabasedatabase-backupdevopsdockergolangkubernetesmariadbmongodbmysqlpgpostgrespostgresqls3self-hostedsystem-administrationtoolsweb-ui
FIX (databases): reject MongoDB <4.2 at connection test/save
Rostislav Dugin09d4f80e96c7
diff --git a/.env.example b/.env.exampleindex 435a80dd..fb3717cd 100644--- a/.env.example+++ b/.env.example@@ -59,6 +59,7 @@ TEST_MARIADB_1011_PORT=33111TEST_MARIADB_114_PORT=33114TEST_MARIADB_118_PORT=33118TEST_MARIADB_120_PORT=33120+TEST_MONGODB_40_PORT=27040TEST_MONGODB_42_PORT=27042TEST_MONGODB_44_PORT=27044TEST_MONGODB_50_PORT=27050diff --git a/README.md b/README.mdindex fe55de03..38990d82 100644--- a/README.md+++ b/README.md@@ -42,7 +42,7 @@- **PostgreSQL**: 12, 13, 14, 15, 16, 17 and 18- **MySQL**: 5.7, 8 and 9- **MariaDB**: 10, 11 and 12-- **MongoDB**: 4, 5, 6, 7 and 8+- **MongoDB**: 4.2+, 5, 6, 7 and 8### 🔄 **Scheduled backups**diff --git a/backend/internal/config/config.go b/backend/internal/config/config.goindex c64b21f3..d94b599a 100644--- a/backend/internal/config/config.go+++ b/backend/internal/config/config.go@@ -101,6 +101,7 @@ type EnvVariables struct {TestMariadb118Port string `env:"TEST_MARIADB_118_PORT"`TestMariadb120Port string `env:"TEST_MARIADB_120_PORT"`+ TestMongodb40Port string `env:"TEST_MONGODB_40_PORT"`TestMongodb42Port string `env:"TEST_MONGODB_42_PORT"`TestMongodb44Port string `env:"TEST_MONGODB_44_PORT"`TestMongodb50Port string `env:"TEST_MONGODB_50_PORT"`diff --git a/backend/internal/features/databases/databases/mongodb/model.go b/backend/internal/features/databases/databases/mongodb/model.goindex 284386ba..2d94ac6b 100644--- a/backend/internal/features/databases/databases/mongodb/model.go+++ b/backend/internal/features/databases/databases/mongodb/model.go@@ -615,16 +615,28 @@ func detectMongodbVersion(ctx context.Context, client *mongo.Client) (tools.Mongreturn "", errors.New("could not parse MongoDB version from buildInfo")}- re := regexp.MustCompile(`^(\d+)\.`)+ re := regexp.MustCompile(`^(\d+)\.(\d+)`)matches := re.FindStringSubmatch(versionStr)- if len(matches) < 2 {+ if len(matches) < 3 {return "", fmt.Errorf("could not parse MongoDB version: %s", versionStr)}- major := matches[1]+ return mapMongodbVersion(matches[1], matches[2])+}+// mapMongodbVersion validates a parsed major.minor against the supported+// matrix. The bundled MongoDB Database Tools (100.16.1) drop wire-protocol+// v7, so the minimum supported server version is 4.2 — matching+// assets/tools/README.md.+func mapMongodbVersion(major, minor string) (tools.MongodbVersion, error) {switch major {case "4":+ if minor == "0" || minor == "1" {+ return "", fmt.Errorf(+ "unsupported MongoDB version: %s.%s (minimum supported: 4.2)",+ major, minor,+ )+ }return tools.MongodbVersion4, nilcase "5":return tools.MongodbVersion5, nil@@ -636,8 +648,8 @@ func detectMongodbVersion(ctx context.Context, client *mongo.Client) (tools.Mongreturn tools.MongodbVersion8, nildefault:return "", fmt.Errorf(- "unsupported MongoDB major version: %s (supported: 4.x, 5.x, 6.x, 7.x, 8.x)",- major,+ "unsupported MongoDB version: %s.%s (supported: 4.2+, 5.x, 6.x, 7.x, 8.x)",+ major, minor,)}}diff --git a/backend/internal/features/databases/databases/mongodb/model_test.go b/backend/internal/features/databases/databases/mongodb/model_test.goindex 914fbb46..1f93e723 100644--- a/backend/internal/features/databases/databases/mongodb/model_test.go+++ b/backend/internal/features/databases/databases/mongodb/model_test.go@@ -836,3 +836,44 @@ func Test_BuildMongodumpURI_WhenSrvAndIsHttpsFalse_ContainsTlsFalse(t *testing.Tassert.NotContains(t, uri, "tls=true")assert.NotContains(t, uri, "tlsInsecure")}++func Test_MapMongodbVersion_VersionMatrix_ReturnsExpected(t *testing.T) {+ t.Parallel()++ cases := []struct {+ name string+ major string+ minor string+ wantErr bool+ wantVersion tools.MongodbVersion+ errContains string+ }{+ {"3.6 rejected", "3", "6", true, "", "supported: 4.2+"},+ {"4.0 rejected", "4", "0", true, "", "minimum supported: 4.2"},+ {"4.1 rejected", "4", "1", true, "", "minimum supported: 4.2"},+ {"4.2 supported", "4", "2", false, tools.MongodbVersion4, ""},+ {"4.4 supported", "4", "4", false, tools.MongodbVersion4, ""},+ {"5.0 supported", "5", "0", false, tools.MongodbVersion5, ""},+ {"6.0 supported", "6", "0", false, tools.MongodbVersion6, ""},+ {"7.0 supported", "7", "0", false, tools.MongodbVersion7, ""},+ {"8.0 supported", "8", "0", false, tools.MongodbVersion8, ""},+ {"9.0 rejected", "9", "0", true, "", "supported: 4.2+"},+ }++ for _, tc := range cases {+ t.Run(tc.name, func(t *testing.T) {+ t.Parallel()++ got, err := mapMongodbVersion(tc.major, tc.minor)++ if tc.wantErr {+ assert.Error(t, err)+ assert.Contains(t, err.Error(), tc.errContains)+ return+ }++ assert.NoError(t, err)+ assert.Equal(t, tc.wantVersion, got)+ })+ }+}diff --git a/backend/internal/features/tests/mongodb_backup_restore_test.go b/backend/internal/features/tests/mongodb_backup_restore_test.goindex c04440fa..42d28e52 100644--- a/backend/internal/features/tests/mongodb_backup_restore_test.go+++ b/backend/internal/features/tests/mongodb_backup_restore_test.go@@ -50,6 +50,53 @@ type MongodbTestDataItem struct {CreatedAt time.Time `bson:"created_at"`}+func Test_CreateMongodbDatabase_WhenVersionIsBelow42_ReturnsBadRequest(t *testing.T) {+ env := config.GetEnv()+ port := env.TestMongodb40Port+ if port == "" {+ t.Skip("MongoDB 4.0 port not configured")+ }+ portInt, err := strconv.Atoi(port)+ if err != nil {+ t.Fatalf("invalid TEST_MONGODB_40_PORT: %v", err)+ }++ router := createTestRouter()+ user := users_testing.CreateTestUser(users_enums.UserRoleMember)+ workspace := workspaces_testing.CreateTestWorkspace(+ "MongoDB 4.0 reject test", user, router,+ )+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)++ request := databases.Database{+ Name: "MongoDB 4.0 rejected",+ WorkspaceID: &workspace.ID,+ Type: databases.DatabaseTypeMongodb,+ Mongodb: &mongodbtypes.MongodbDatabase{+ Host: env.TestLocalhost,+ Port: &portInt,+ Username: "root",+ Password: "rootpassword",+ Database: "testdb",+ AuthDatabase: "admin",+ Version: tools.MongodbVersion4,+ IsHttps: false,+ IsSrv: false,+ CpuCount: 1,+ },+ }++ w := workspaces_testing.MakeAPIRequest(+ router, "POST", "/api/v1/databases/create",+ "Bearer "+user.Token, request,+ )++ assert.Equal(t, http.StatusBadRequest, w.Code,+ "creating a MongoDB 4.0 database should be rejected; got body: %s", w.Body.String())+ assert.Contains(t, w.Body.String(), "4.2",+ "error should reference the 4.2 minimum supported version")+}+func Test_BackupAndRestoreMongodb_RestoreIsSuccessful(t *testing.T) {env := config.GetEnv()cases := []struct {diff --git a/docker-compose.yml b/docker-compose.ymlindex 297456f9..361d5aeb 100644--- a/docker-compose.yml+++ b/docker-compose.yml@@ -539,6 +539,22 @@ services:retries: 10# Test MongoDB containers+ test-mongodb-40:+ image: mongo:4.0+ container_name: test-mongodb-40+ ports:+ - "${TEST_MONGODB_40_PORT}:27017"+ environment:+ MONGO_INITDB_ROOT_USERNAME: root+ MONGO_INITDB_ROOT_PASSWORD: rootpassword+ MONGO_INITDB_DATABASE: testdb+ command: mongod --auth+ healthcheck:+ test: ["CMD", "mongo", "--eval", "db.adminCommand('ping')"]+ interval: 5s+ timeout: 5s+ retries: 10+test-mongodb-42:image: mongo:4.2container_name: test-mongodb-42