PostgreSQL backup tool with Point-In-Time-Recovery and restore verification
TypeScript backupbackupsdatabasedatabase-backupdevopsdockergolangkubernetesmariadbmongodbmysqlpgpostgrespostgresqls3self-hostedsystem-administrationtoolsweb-ui
FIX (mysql & mariadb): Fix creation of backups with exremely large SQL statements to avoid OOM
Rostislav Dugin35180360e57e
diff --git a/backend/internal/features/backups/backups/usecases/mariadb/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/mariadb/create_backup_uc.goindex c285a332..eef9d43e 100644--- a/backend/internal/features/backups/backups/usecases/mariadb/create_backup_uc.go+++ b/backend/internal/features/backups/backups/usecases/mariadb/create_backup_uc.go@@ -108,6 +108,7 @@ func (uc *CreateMariadbBackupUsecase) buildMariadbDumpArgs("--single-transaction","--routines","--quick",+ "--skip-extended-insert","--verbose",}diff --git a/backend/internal/features/backups/backups/usecases/mysql/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/mysql/create_backup_uc.goindex 6dfea7c7..2dd690db 100644--- a/backend/internal/features/backups/backups/usecases/mysql/create_backup_uc.go+++ b/backend/internal/features/backups/backups/usecases/mysql/create_backup_uc.go@@ -107,6 +107,7 @@ func (uc *CreateMysqlBackupUsecase) buildMysqldumpArgs(my *mysqltypes.MysqlDatab"--routines","--set-gtid-purged=OFF","--quick",+ "--skip-extended-insert","--verbose",}diff --git a/backend/internal/features/restores/controller_test.go b/backend/internal/features/restores/controller_test.goindex 3a780ef0..9fca0334 100644--- a/backend/internal/features/restores/controller_test.go+++ b/backend/internal/features/restores/controller_test.go@@ -32,7 +32,6 @@ import (tasks_cancellation "databasus-backend/internal/features/tasks/cancellation"users_dto "databasus-backend/internal/features/users/dto"users_enums "databasus-backend/internal/features/users/enums"- users_services "databasus-backend/internal/features/users/services"users_testing "databasus-backend/internal/features/users/testing"workspaces_models "databasus-backend/internal/features/workspaces/models"workspaces_testing "databasus-backend/internal/features/workspaces/testing"@@ -358,7 +357,7 @@ func Test_RestoreBackup_DiskSpaceValidation(t *testing.T) {_, err = configService.SaveBackupConfig(config)assert.NoError(t, err)- backup = createTestBackup(mysqlDB, owner)+ backup = createTestBackup(mysqlDB, storage)request = restores_core.RestoreBackupRequest{MysqlDatabase: &mysql.MysqlDatabase{@@ -610,7 +609,7 @@ func createTestDatabaseWithBackupForRestore(panic(err)}- backup := createTestBackup(database, owner)+ backup := createTestBackup(database, storage)return database, backup}@@ -727,24 +726,14 @@ func createTestStorage(workspaceID uuid.UUID) *storages.Storage {func createTestBackup(database *databases.Database,- owner *users_dto.SignInResponseDTO,+ storage *storages.Storage,) *backups_core.Backup {fieldEncryptor := util_encryption.GetFieldEncryptor()- userService := users_services.GetUserService()- user, err := userService.GetUserFromToken(owner.Token)- if err != nil {- panic(err)- }-- storages, err := storages.GetStorageService().GetStorages(user, *database.WorkspaceID)- if err != nil || len(storages) == 0 {- panic("No storage found for workspace")- }backup := &backups_core.Backup{ID: uuid.New(),DatabaseID: database.ID,- StorageID: storages[0].ID,+ StorageID: storage.ID,Status: backups_core.BackupStatusCompleted,BackupSizeMb: 10.5,BackupDurationMs: 1000,@@ -759,7 +748,7 @@ func createTestBackup(dummyContent := []byte("dummy backup content for testing")reader := strings.NewReader(string(dummyContent))logger := slog.New(slog.NewTextHandler(io.Discard, nil))- if err := storages[0].SaveFile(+ if err := storage.SaveFile(context.Background(),fieldEncryptor,logger,