Skip to content

PostgreSQL backup tool with Point-In-Time-Recovery and restore verification

FIX (backups): Use system's temp directory instead of mounter directory to fix access permissions on TrueNAS

Rostislav Dugin44ddcb836ec0
diff --git a/backend/internal/features/backups/backups/usecases/mariadb/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/mariadb/create_backup_uc.go
index ddccf628..a5d3615f 100644
--- a/backend/internal/features/backups/backups/usecases/mariadb/create_backup_uc.go
+++ b/backend/internal/features/backups/backups/usecases/mariadb/create_backup_uc.go
@@ -281,15 +281,9 @@ func (uc *CreateMariadbBackupUsecase) createTempMyCnfFile(
mdbConfig *mariadbtypes.MariadbDatabase,
password string,
) (string, error) {
- tempFolder := config.GetEnv().TempFolder
- if err := os.MkdirAll(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to ensure temp folder exists: %w", err)
- }
- if err := os.Chmod(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to set temp folder permissions: %w", err)
- }
-
- tempDir, err := os.MkdirTemp(tempFolder, "mycnf_"+uuid.New().String())
+ // Credential files use OS temp dir (/tmp) because some filesystems
+ // (e.g. ZFS on TrueNAS) ignore chmod, causing "group or world access" errors.
+ tempDir, err := os.MkdirTemp(os.TempDir(), "mycnf_"+uuid.New().String())
if err != nil {
return "", fmt.Errorf("failed to create temp directory: %w", err)
}
diff --git a/backend/internal/features/backups/backups/usecases/mysql/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/mysql/create_backup_uc.go
index 5dca1935..9567eb83 100644
--- a/backend/internal/features/backups/backups/usecases/mysql/create_backup_uc.go
+++ b/backend/internal/features/backups/backups/usecases/mysql/create_backup_uc.go
@@ -300,15 +300,9 @@ func (uc *CreateMysqlBackupUsecase) createTempMyCnfFile(
myConfig *mysqltypes.MysqlDatabase,
password string,
) (string, error) {
- tempFolder := config.GetEnv().TempFolder
- if err := os.MkdirAll(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to ensure temp folder exists: %w", err)
- }
- if err := os.Chmod(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to set temp folder permissions: %w", err)
- }
-
- tempDir, err := os.MkdirTemp(tempFolder, "mycnf_"+uuid.New().String())
+ // Credential files use OS temp dir (/tmp) because some filesystems
+ // (e.g. ZFS on TrueNAS) ignore chmod, causing "group or world access" errors.
+ tempDir, err := os.MkdirTemp(os.TempDir(), "mycnf_"+uuid.New().String())
if err != nil {
return "", fmt.Errorf("failed to create temp directory: %w", err)
}
diff --git a/backend/internal/features/backups/backups/usecases/postgresql/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/postgresql/create_backup_uc.go
index 3d4fafd0..60961cfd 100644
--- a/backend/internal/features/backups/backups/usecases/postgresql/create_backup_uc.go
+++ b/backend/internal/features/backups/backups/usecases/postgresql/create_backup_uc.go
@@ -747,15 +747,9 @@ func (uc *CreatePostgresqlBackupUsecase) createTempPgpassFile(
escapedPassword,
)
- tempFolder := config.GetEnv().TempFolder
- if err := os.MkdirAll(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to ensure temp folder exists: %w", err)
- }
- if err := os.Chmod(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to set temp folder permissions: %w", err)
- }
-
- tempDir, err := os.MkdirTemp(tempFolder, "pgpass_"+uuid.New().String())
+ // Credential files use OS temp dir (/tmp) because some filesystems
+ // (e.g. ZFS on TrueNAS) ignore chmod, causing "group or world access" errors.
+ tempDir, err := os.MkdirTemp(os.TempDir(), "pgpass_"+uuid.New().String())
if err != nil {
return "", fmt.Errorf("failed to create temporary directory: %w", err)
}
diff --git a/backend/internal/features/restores/usecases/mariadb/restore_backup_uc.go b/backend/internal/features/restores/usecases/mariadb/restore_backup_uc.go
index 059e5367..1897c382 100644
--- a/backend/internal/features/restores/usecases/mariadb/restore_backup_uc.go
+++ b/backend/internal/features/restores/usecases/mariadb/restore_backup_uc.go
@@ -287,15 +287,9 @@ func (uc *RestoreMariadbBackupUsecase) createTempMyCnfFile(
mdbConfig *mariadbtypes.MariadbDatabase,
password string,
) (string, error) {
- tempFolder := config.GetEnv().TempFolder
- if err := os.MkdirAll(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to ensure temp folder exists: %w", err)
- }
- if err := os.Chmod(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to set temp folder permissions: %w", err)
- }
-
- tempDir, err := os.MkdirTemp(tempFolder, "mycnf_"+uuid.New().String())
+ // Credential files use OS temp dir (/tmp) because some filesystems
+ // (e.g. ZFS on TrueNAS) ignore chmod, causing "group or world access" errors.
+ tempDir, err := os.MkdirTemp(os.TempDir(), "mycnf_"+uuid.New().String())
if err != nil {
return "", fmt.Errorf("failed to create temp directory: %w", err)
}
diff --git a/backend/internal/features/restores/usecases/mysql/restore_backup_uc.go b/backend/internal/features/restores/usecases/mysql/restore_backup_uc.go
index f0682fea..db605add 100644
--- a/backend/internal/features/restores/usecases/mysql/restore_backup_uc.go
+++ b/backend/internal/features/restores/usecases/mysql/restore_backup_uc.go
@@ -278,15 +278,9 @@ func (uc *RestoreMysqlBackupUsecase) createTempMyCnfFile(
myConfig *mysqltypes.MysqlDatabase,
password string,
) (string, error) {
- tempFolder := config.GetEnv().TempFolder
- if err := os.MkdirAll(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to ensure temp folder exists: %w", err)
- }
- if err := os.Chmod(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to set temp folder permissions: %w", err)
- }
-
- tempDir, err := os.MkdirTemp(tempFolder, "mycnf_"+uuid.New().String())
+ // Credential files use OS temp dir (/tmp) because some filesystems
+ // (e.g. ZFS on TrueNAS) ignore chmod, causing "group or world access" errors.
+ tempDir, err := os.MkdirTemp(os.TempDir(), "mycnf_"+uuid.New().String())
if err != nil {
return "", fmt.Errorf("failed to create temp directory: %w", err)
}
diff --git a/backend/internal/features/restores/usecases/postgresql/restore_backup_uc.go b/backend/internal/features/restores/usecases/postgresql/restore_backup_uc.go
index b074d3ed..7221aa66 100644
--- a/backend/internal/features/restores/usecases/postgresql/restore_backup_uc.go
+++ b/backend/internal/features/restores/usecases/postgresql/restore_backup_uc.go
@@ -995,15 +995,9 @@ func (uc *RestorePostgresqlBackupUsecase) createTempPgpassFile(
escapedPassword,
)
- tempFolder := config.GetEnv().TempFolder
- if err := os.MkdirAll(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to ensure temp folder exists: %w", err)
- }
- if err := os.Chmod(tempFolder, 0o700); err != nil {
- return "", fmt.Errorf("failed to set temp folder permissions: %w", err)
- }
-
- tempDir, err := os.MkdirTemp(tempFolder, "pgpass_"+uuid.New().String())
+ // Credential files use OS temp dir (/tmp) because some filesystems
+ // (e.g. ZFS on TrueNAS) ignore chmod, causing "group or world access" errors.
+ tempDir, err := os.MkdirTemp(os.TempDir(), "pgpass_"+uuid.New().String())
if err != nil {
return "", fmt.Errorf("failed to create temporary directory: %w", err)
}