Skip to content

PostgreSQL backup tool with Point-In-Time-Recovery and restore verification

FIX (readonly user): Improve complexity of readonly user passwords to pass Google Cloud requirements

Rostislav Dugin615fd9d5748f
diff --git a/backend/internal/features/databases/databases/mariadb/model.go b/backend/internal/features/databases/databases/mariadb/model.go
index 1ad0a70a..0623c082 100644
--- a/backend/internal/features/databases/databases/mariadb/model.go
+++ b/backend/internal/features/databases/databases/mariadb/model.go
@@ -265,7 +265,7 @@ func (m *MariadbDatabase) CreateReadOnlyUser(
for attempt := range maxRetries {
// MariaDB 5.5 has a 16-character username limit, use shorter prefix
newUsername := fmt.Sprintf("pgs-%s", uuid.New().String()[:8])
- newPassword := uuid.New().String()
+ newPassword := encryption.GenerateComplexPassword()
tx, err := db.BeginTx(ctx, nil)
if err != nil {
diff --git a/backend/internal/features/databases/databases/mongodb/model.go b/backend/internal/features/databases/databases/mongodb/model.go
index 4aeedfd8..51d5ccc8 100644
--- a/backend/internal/features/databases/databases/mongodb/model.go
+++ b/backend/internal/features/databases/databases/mongodb/model.go
@@ -5,6 +5,7 @@ import (
"errors"
"fmt"
"log/slog"
+ "net/url"
"regexp"
"time"
@@ -290,7 +291,7 @@ func (m *MongodbDatabase) CreateReadOnlyUser(
maxRetries := 3
for attempt := range maxRetries {
newUsername := fmt.Sprintf("databasus-%s", uuid.New().String()[:8])
- newPassword := uuid.New().String()
+ newPassword := encryption.GenerateComplexPassword()
adminDB := client.Database(authDB)
err = adminDB.RunCommand(ctx, bson.D{
@@ -339,8 +340,8 @@ func (m *MongodbDatabase) buildConnectionURI(password string) string {
return fmt.Sprintf(
"mongodb://%s:%s@%s:%d/%s?authSource=%s&tls=%s&connectTimeoutMS=15000",
- m.Username,
- password,
+ url.QueryEscape(m.Username),
+ url.QueryEscape(password),
m.Host,
m.Port,
m.Database,
@@ -363,8 +364,8 @@ func (m *MongodbDatabase) BuildMongodumpURI(password string) string {
return fmt.Sprintf(
"mongodb://%s:%s@%s:%d/?authSource=%s&tls=%s&connectTimeoutMS=15000",
- m.Username,
- password,
+ url.QueryEscape(m.Username),
+ url.QueryEscape(password),
m.Host,
m.Port,
authDB,
diff --git a/backend/internal/features/databases/databases/mongodb/readonly_user_test.go b/backend/internal/features/databases/databases/mongodb/readonly_user_test.go
index fbd7ae36..b3ca0d5f 100644
--- a/backend/internal/features/databases/databases/mongodb/readonly_user_test.go
+++ b/backend/internal/features/databases/databases/mongodb/readonly_user_test.go
@@ -4,6 +4,7 @@ import (
"context"
"fmt"
"log/slog"
+ "net/url"
"os"
"strconv"
"strings"
@@ -281,7 +282,8 @@ func connectWithCredentials(
) *mongo.Client {
uri := fmt.Sprintf(
"mongodb://%s:%s@%s:%d/%s?authSource=%s",
- username, password, container.Host, container.Port,
+ url.QueryEscape(username), url.QueryEscape(password),
+ container.Host, container.Port,
container.Database, container.AuthDatabase,
)
diff --git a/backend/internal/features/databases/databases/mysql/model.go b/backend/internal/features/databases/databases/mysql/model.go
index 47073abe..18af6d6a 100644
--- a/backend/internal/features/databases/databases/mysql/model.go
+++ b/backend/internal/features/databases/databases/mysql/model.go
@@ -259,7 +259,7 @@ func (m *MysqlDatabase) CreateReadOnlyUser(
maxRetries := 3
for attempt := range maxRetries {
newUsername := fmt.Sprintf("databasus-%s", uuid.New().String()[:8])
- newPassword := uuid.New().String()
+ newPassword := encryption.GenerateComplexPassword()
tx, err := db.BeginTx(ctx, nil)
if err != nil {
diff --git a/backend/internal/features/databases/databases/postgresql/model.go b/backend/internal/features/databases/databases/postgresql/model.go
index dc51a5f4..af2cd1eb 100644
--- a/backend/internal/features/databases/databases/postgresql/model.go
+++ b/backend/internal/features/databases/databases/postgresql/model.go
@@ -383,7 +383,7 @@ func (p *PostgresqlDatabase) CreateReadOnlyUser(
}
}
- newPassword := uuid.New().String()
+ newPassword := encryption.GenerateComplexPassword()
tx, err := conn.Begin(ctx)
if err != nil {
diff --git a/backend/internal/util/encryption/password_generator.go b/backend/internal/util/encryption/password_generator.go
new file mode 100644
index 00000000..2c4cf761
--- /dev/null
+++ b/backend/internal/util/encryption/password_generator.go
@@ -0,0 +1,59 @@
+package encryption
+
+import (
+ "crypto/rand"
+ "math/big"
+)
+
+// GenerateComplexPassword creates a password that meets common cloud provider requirements:
+// - At least one lowercase letter
+// - At least one uppercase letter
+// - At least one digit
+// - At least one special character
+// - 24 characters for security
+func GenerateComplexPassword() string {
+ const (
+ lowercase = "abcdefghijklmnopqrstuvwxyz"
+ uppercase = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
+ digits = "0123456789"
+ special = "!@#$%^&*()-_=+"
+ all = lowercase + uppercase + digits + special
+ )
+
+ password := make([]byte, 24)
+
+ // Ensure at least one character from each required set
+ password[0] = randomChar(lowercase)
+ password[1] = randomChar(uppercase)
+ password[2] = randomChar(digits)
+ password[3] = randomChar(special)
+
+ // Fill the rest with random characters from all sets
+ for i := 4; i < len(password); i++ {
+ password[i] = randomChar(all)
+ }
+
+ // Shuffle the password to avoid predictable positions
+ shuffleBytes(password)
+
+ return string(password)
+}
+
+func randomChar(charset string) byte {
+ n, err := rand.Int(rand.Reader, big.NewInt(int64(len(charset))))
+ if err != nil {
+ return charset[0]
+ }
+ return charset[n.Int64()]
+}
+
+func shuffleBytes(b []byte) {
+ for i := len(b) - 1; i > 0; i-- {
+ n, err := rand.Int(rand.Reader, big.NewInt(int64(i+1)))
+ if err != nil {
+ continue
+ }
+ j := n.Int64()
+ b[i], b[j] = b[j], b[i]
+ }
+}