Skip to content

PostgreSQL backup tool with Point-In-Time-Recovery and restore verification

FIX (backups): Validate data and temp directory exist on app start (not only for LocalStorage)

Rostislav Dugin65c7178f916c
diff --git a/backend/cmd/main.go b/backend/cmd/main.go
index 54eaf10f..167b2c85 100644
--- a/backend/cmd/main.go
+++ b/backend/cmd/main.go
@@ -50,6 +50,12 @@ func main() {
runMigrations(log)
+ // create directories that used for backups and restore
+ files_utils.EnsureDirectories([]string{
+ config.GetEnv().TempFolder,
+ config.GetEnv().DataFolder,
+ })
+
// Handle password reset if flag is provided
newPassword := flag.String("new-password", "", "Set a new password for the user")
flag.Parse()
diff --git a/backend/internal/features/storages/models/local/model.go b/backend/internal/features/storages/models/local/model.go
index d84b8048..f92ea7ea 100644
--- a/backend/internal/features/storages/models/local/model.go
+++ b/backend/internal/features/storages/models/local/model.go
@@ -25,11 +25,6 @@ func (l *LocalStorage) TableName() string {
func (l *LocalStorage) SaveFile(logger *slog.Logger, fileID uuid.UUID, file io.Reader) error {
logger.Info("Starting to save file to local storage", "fileId", fileID.String())
- if err := l.ensureDirectories(); err != nil {
- logger.Error("Failed to ensure directories", "fileId", fileID.String(), "error", err)
- return err
- }
-
tempFilePath := filepath.Join(config.GetEnv().TempFolder, fileID.String())
logger.Debug("Creating temp file", "fileId", fileID.String(), "tempPath", tempFilePath)
@@ -134,14 +129,11 @@ func (l *LocalStorage) DeleteFile(fileID uuid.UUID) error {
}
func (l *LocalStorage) Validate() error {
- return l.ensureDirectories()
+ // nothing to validate
+ return nil
}
func (l *LocalStorage) TestConnection() error {
- if err := l.ensureDirectories(); err != nil {
- return err
- }
-
testFile := filepath.Join(config.GetEnv().TempFolder, "test_connection")
f, err := os.Create(testFile)
if err != nil {
@@ -157,19 +149,3 @@ func (l *LocalStorage) TestConnection() error {
return nil
}
-
-func (l *LocalStorage) ensureDirectories() error {
- // Standard permissions for directories: owner
- // can read/write/execute, others can read/execute
- const directoryPermissions = 0755
-
- if err := os.MkdirAll(config.GetEnv().DataFolder, directoryPermissions); err != nil {
- return fmt.Errorf("failed to create backups directory: %w", err)
- }
-
- if err := os.MkdirAll(config.GetEnv().TempFolder, directoryPermissions); err != nil {
- return fmt.Errorf("failed to create temp directory: %w", err)
- }
-
- return nil
-}
diff --git a/backend/internal/util/files/creator.go b/backend/internal/util/files/creator.go
new file mode 100644
index 00000000..63cc6560
--- /dev/null
+++ b/backend/internal/util/files/creator.go
@@ -0,0 +1,20 @@
+package files_utils
+
+import (
+ "fmt"
+ "os"
+)
+
+func EnsureDirectories(directories []string) error {
+ // Standard permissions for directories: owner
+ // can read/write/execute, others can read/execute
+ const directoryPermissions = 0755
+
+ for _, directory := range directories {
+ if err := os.MkdirAll(directory, directoryPermissions); err != nil {
+ return fmt.Errorf("failed to create directory %s: %w", directory, err)
+ }
+ }
+
+ return nil
+}