PostgreSQL backup tool with Point-In-Time-Recovery and restore verification
TypeScript backupbackupsdatabasedatabase-backupdevopsdockergolangkubernetesmariadbmongodbmysqlpgpostgrespostgresqls3self-hostedsystem-administrationtoolsweb-ui
FIX (backups): Fix backup size rounding when less than 1 MB
Rostislav Dugin6cd887fc4682
diff --git a/backend/internal/features/telemetry/service.go b/backend/internal/features/telemetry/service.goindex 3c796a54..7dcc9f2c 100644--- a/backend/internal/features/telemetry/service.go+++ b/backend/internal/features/telemetry/service.go@@ -158,11 +158,11 @@ func (s *TelemetryService) attachBackupSizes(}if backup.BackupSizeMb > 0 {- entry.BackupSizeMb = int64(math.Round(backup.BackupSizeMb))+ entry.BackupSizeMb = int64(math.Ceil(backup.BackupSizeMb))}if backup.BackupRawDbSizeMb > 0 {- entry.RawSizeMb = int64(math.Round(backup.BackupRawDbSizeMb))+ entry.RawSizeMb = int64(math.Ceil(backup.BackupRawDbSizeMb))}return nildiff --git a/backend/internal/features/telemetry/service_test.go b/backend/internal/features/telemetry/service_test.goindex 5986cbed..a7950f1f 100644--- a/backend/internal/features/telemetry/service_test.go+++ b/backend/internal/features/telemetry/service_test.go@@ -391,10 +391,41 @@ func Test_BuildAndSend_WhenLatestBackupHasBothSizes_IncludesBoth(t *testing.T) {require.Len(t, sender.calls[0].Databases, 1)entry := sender.calls[0].Databases[0]- assert.Equal(t, int64(870), entry.BackupSizeMb)+ assert.Equal(t, int64(871), entry.BackupSizeMb)assert.Equal(t, int64(4322), entry.RawSizeMb)}+func Test_BuildAndSend_WhenSizesAreSubMb_RoundsUpToOne(t *testing.T) {+ db := postgresDatabase("pg", availableStatus())++ sender := &fakeSender{}+ service := newServiceUnderTest(+ t,+ &fakeDatabaseLister{databases: []*databases.Database{db}},+ &fakeStorageLister{},+ &fakeNotifierLister{},+ &fakeBackupChecker{+ latestBackups: map[uuid.UUID]*backups_core.Backup{+ db.ID: {BackupSizeMb: 0.3, BackupRawDbSizeMb: 0.1},+ },+ },+ sender,+ )++ require.NoError(t, service.BuildAndSend(context.Background()))+ require.Len(t, sender.calls, 1)+ require.Len(t, sender.calls[0].Databases, 1)++ entry := sender.calls[0].Databases[0]+ assert.Equal(t, int64(1), entry.BackupSizeMb)+ assert.Equal(t, int64(1), entry.RawSizeMb)++ encoded, err := json.Marshal(entry)+ require.NoError(t, err)+ assert.Contains(t, string(encoded), "backupSizeMb")+ assert.Contains(t, string(encoded), "rawSizeMb")+}+func Test_BuildAndSend_WhenRawSizeZero_IncludesOnlyBackupSize(t *testing.T) {db := postgresDatabase("pg", availableStatus())