Skip to content

PostgreSQL backup tool with Point-In-Time-Recovery and restore verification

FIX (mysql\mariadb): Use custom TLS handler to skip verification instead of build-in

Rostislav Dugin7c6f0ab4bad7
diff --git a/backend/internal/features/databases/databases/mariadb/model.go b/backend/internal/features/databases/databases/mariadb/model.go
index b80237dd..65fe9edf 100644
--- a/backend/internal/features/databases/databases/mariadb/model.go
+++ b/backend/internal/features/databases/databases/mariadb/model.go
@@ -2,6 +2,7 @@ package mariadb
import (
"context"
+ "crypto/tls"
"database/sql"
"errors"
"fmt"
@@ -14,7 +15,7 @@ import (
"databasus-backend/internal/util/encryption"
"databasus-backend/internal/util/tools"
- _ "github.com/go-sql-driver/mysql"
+ "github.com/go-sql-driver/mysql"
"github.com/google/uuid"
)
@@ -398,8 +399,16 @@ func HasPrivilege(privileges, priv string) bool {
func (m *MariadbDatabase) buildDSN(password string, database string) string {
tlsConfig := "false"
+
if m.IsHttps {
- tlsConfig = "skip-verify"
+ err := mysql.RegisterTLSConfig("mariadb-skip-verify", &tls.Config{
+ InsecureSkipVerify: true,
+ })
+ if err != nil {
+ // Config might already be registered, which is fine
+ _ = err
+ }
+ tlsConfig = "mariadb-skip-verify"
}
return fmt.Sprintf(
diff --git a/backend/internal/features/databases/databases/mysql/model.go b/backend/internal/features/databases/databases/mysql/model.go
index 51d848c4..ae7a53cc 100644
--- a/backend/internal/features/databases/databases/mysql/model.go
+++ b/backend/internal/features/databases/databases/mysql/model.go
@@ -2,6 +2,7 @@ package mysql
import (
"context"
+ "crypto/tls"
"database/sql"
"errors"
"fmt"
@@ -14,7 +15,7 @@ import (
"databasus-backend/internal/util/encryption"
"databasus-backend/internal/util/tools"
- _ "github.com/go-sql-driver/mysql"
+ "github.com/go-sql-driver/mysql"
"github.com/google/uuid"
)
@@ -399,8 +400,17 @@ func HasPrivilege(privileges, priv string) bool {
func (m *MysqlDatabase) buildDSN(password string, database string) string {
tlsConfig := "false"
+
if m.IsHttps {
- tlsConfig = "skip-verify"
+ err := mysql.RegisterTLSConfig("mysql-skip-verify", &tls.Config{
+ InsecureSkipVerify: true,
+ })
+ if err != nil {
+ // Config might already be registered, which is fine
+ _ = err
+ }
+
+ tlsConfig = "mysql-skip-verify"
}
return fmt.Sprintf(