PostgreSQL backup tool with Point-In-Time-Recovery and restore verification
TypeScript backupbackupsdatabasedatabase-backupdevopsdockergolangkubernetesmariadbmongodbmysqlpgpostgrespostgresqls3self-hostedsystem-administrationtoolsweb-ui
FIX (tests): Improve cleaning up of backups and workspaces
Rostislav Dugin9b413e407624
diff --git a/AGENTS.md b/AGENTS.mdindex bbe04485..479b2db1 100644--- a/AGENTS.md+++ b/AGENTS.md@@ -573,15 +573,15 @@ var (func SetupDependencies() {wasAlreadySetup := isSetup.Load()-+setupOnce.Do(func() {// Initialize dependencies heresomeService.SetDependency(otherService)anotherService.AddListener(listener)-+isSetup.Store(true)})-+if wasAlreadySetup {logger.GetLogger().Warn("SetupDependencies called multiple times, ignoring subsequent call")}@@ -630,14 +630,14 @@ type BackgroundService struct {func (s *BackgroundService) Run(ctx context.Context) {wasAlreadyRun := s.hasRun.Load()-+s.runOnce.Do(func() {s.hasRun.Store(true)-+// Existing infinite loop logicticker := time.NewTicker(1 * time.Minute)defer ticker.Stop()-+for {select {case <-ctx.Done():@@ -647,7 +647,7 @@ func (s *BackgroundService) Run(ctx context.Context) {}}})-+if wasAlreadyRun {panic(fmt.Sprintf("%T.Run() called multiple times", s))}@@ -766,6 +766,43 @@ Use these naming patterns:- Consolidate similar test patterns across different test files- Make tests more readable and maintainable for other developers+**Clean Up Test Data:**++- If the feature supports cleanup operations (DELETE endpoints, cleanup methods), use them in tests+- Clean up resources after test execution to avoid test data pollution+- Use `defer` statements or explicit cleanup calls at the end of tests+- Prioritize using API methods for cleanup (not direct database deletion)+- Examples:+ - CRUD features: delete created records via DELETE endpoint+ - File uploads: remove uploaded files+ - Background jobs: stop schedulers or cancel running tasks+- Skip cleanup only when:+ - Tests run in isolated transactions that auto-rollback+ - Cleanup endpoint doesn't exist yet+ - Test explicitly validates failure scenarios where cleanup isn't possible++**Example:**++```go+func Test_BackupLifecycle_CreateAndDelete(t *testing.T) {+ router := createTestRouter()+ workspace := workspaces_testing.CreateTestWorkspace("Test", owner)++ // Create backup config+ config := createBackupConfig(t, router, workspace.ID, owner.Token)++ // Cleanup at end of test+ defer deleteBackupConfig(t, router, workspace.ID, config.ID, owner.Token)++ // Test operations...+ triggerBackup(t, router, workspace.ID, config.ID, owner.Token)++ // Verify backup was created+ backups := getBackups(t, router, workspace.ID, owner.Token)+ assert.NotEmpty(t, backups)+}+```+#### Testing Utilities Structure**Create `testing.go` or `testing/testing.go` files with common utilities:**diff --git a/backend/internal/features/backups/backups/backuping/cleaner_test.go b/backend/internal/features/backups/backups/backuping/cleaner_test.goindex 942f6c8c..0b45f369 100644--- a/backend/internal/features/backups/backups/backuping/cleaner_test.go+++ b/backend/internal/features/backups/backups/backuping/cleaner_test.go@@ -28,6 +28,19 @@ func Test_CleanOldBackups_DeletesBackupsOlderThanStorePeriod(t *testing.T) {notifier := notifiers.CreateTestNotifier(workspace.ID)database := databases.CreateTestDatabase(workspace.ID, storage, notifier)+ defer func() {+ backups, _ := backupRepository.FindByDatabaseID(database.ID)+ for _, backup := range backups {+ backupRepository.DeleteByID(backup.ID)+ }++ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+// Create backup intervalinterval := createTestInterval()@@ -96,6 +109,19 @@ func Test_CleanOldBackups_SkipsDatabaseWithForeverStorePeriod(t *testing.T) {notifier := notifiers.CreateTestNotifier(workspace.ID)database := databases.CreateTestDatabase(workspace.ID, storage, notifier)+ defer func() {+ backups, _ := backupRepository.FindByDatabaseID(database.ID)+ for _, backup := range backups {+ backupRepository.DeleteByID(backup.ID)+ }++ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+// Create backup intervalinterval := createTestInterval()@@ -142,6 +168,19 @@ func Test_CleanExceededBackups_WhenUnderLimit_NoBackupsDeleted(t *testing.T) {notifier := notifiers.CreateTestNotifier(workspace.ID)database := databases.CreateTestDatabase(workspace.ID, storage, notifier)+ defer func() {+ backups, _ := backupRepository.FindByDatabaseID(database.ID)+ for _, backup := range backups {+ backupRepository.DeleteByID(backup.ID)+ }++ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+// Create backup intervalinterval := createTestInterval()@@ -190,6 +229,19 @@ func Test_CleanExceededBackups_WhenOverLimit_DeletesOldestBackups(t *testing.T)notifier := notifiers.CreateTestNotifier(workspace.ID)database := databases.CreateTestDatabase(workspace.ID, storage, notifier)+ defer func() {+ backups, _ := backupRepository.FindByDatabaseID(database.ID)+ for _, backup := range backups {+ backupRepository.DeleteByID(backup.ID)+ }++ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+// Create backup intervalinterval := createTestInterval()@@ -252,6 +304,19 @@ func Test_CleanExceededBackups_SkipsInProgressBackups(t *testing.T) {notifier := notifiers.CreateTestNotifier(workspace.ID)database := databases.CreateTestDatabase(workspace.ID, storage, notifier)+ defer func() {+ backups, _ := backupRepository.FindByDatabaseID(database.ID)+ for _, backup := range backups {+ backupRepository.DeleteByID(backup.ID)+ }++ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+// Create backup intervalinterval := createTestInterval()@@ -328,6 +393,19 @@ func Test_CleanExceededBackups_WithZeroLimit_SkipsDatabase(t *testing.T) {notifier := notifiers.CreateTestNotifier(workspace.ID)database := databases.CreateTestDatabase(workspace.ID, storage, notifier)+ defer func() {+ backups, _ := backupRepository.FindByDatabaseID(database.ID)+ for _, backup := range backups {+ backupRepository.DeleteByID(backup.ID)+ }++ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+// Create backup intervalinterval := createTestInterval()@@ -376,6 +454,19 @@ func Test_GetTotalSizeByDatabase_CalculatesCorrectly(t *testing.T) {notifier := notifiers.CreateTestNotifier(workspace.ID)database := databases.CreateTestDatabase(workspace.ID, storage, notifier)+ defer func() {+ backups, _ := backupRepository.FindByDatabaseID(database.ID)+ for _, backup := range backups {+ backupRepository.DeleteByID(backup.ID)+ }++ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+// Create completed backupscompletedBackup1 := &backups_core.Backup{ID: uuid.New(),@@ -454,6 +545,19 @@ func Test_DeleteBackup_WhenStorageDeleteFails_BackupStillRemovedFromDatabase(t *notifier := notifiers.CreateTestNotifier(workspace.ID)database := databases.CreateTestDatabase(workspace.ID, testStorage, notifier)+ defer func() {+ backups, _ := backupRepository.FindByDatabaseID(database.ID)+ for _, backup := range backups {+ backupRepository.DeleteByID(backup.ID)+ }++ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ storages.RemoveTestStorage(testStorage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+backup := &backups_core.Backup{ID: uuid.New(),DatabaseID: database.ID,diff --git a/backend/internal/features/backups/backups/backuping/scheduler.go b/backend/internal/features/backups/backups/backuping/scheduler.goindex f774fec9..df24ce2e 100644--- a/backend/internal/features/backups/backups/backuping/scheduler.go+++ b/backend/internal/features/backups/backups/backuping/scheduler.go@@ -103,49 +103,6 @@ func (s *BackupsScheduler) IsSchedulerRunning() bool {return s.lastBackupTime.After(time.Now().UTC().Add(-schedulerHealthcheckThreshold))}-func (s *BackupsScheduler) failBackupsInProgress() error {- backupsInProgress, err := s.backupRepository.FindByStatus(backups_core.BackupStatusInProgress)- if err != nil {- return err- }-- for _, backup := range backupsInProgress {- if err := s.taskCancelManager.CancelTask(backup.ID); err != nil {- s.logger.Error(- "Failed to cancel backup via task cancel manager",- "backupId",- backup.ID,- "error",- err,- )- }-- backupConfig, err := s.backupConfigService.GetBackupConfigByDbId(backup.DatabaseID)- if err != nil {- s.logger.Error("Failed to get backup config by database ID", "error", err)- continue- }-- failMessage := "Backup failed due to application restart"- backup.FailMessage = &failMessage- backup.Status = backups_core.BackupStatusFailed- backup.BackupSizeMb = 0-- s.backuperNode.SendBackupNotification(- backupConfig,- backup,- backups_config.NotificationBackupFailed,- &failMessage,- )-- if err := s.backupRepository.Save(backup); err != nil {- return err- }- }-- return nil-}-func (s *BackupsScheduler) StartBackup(databaseID uuid.UUID, isCallNotifier bool) {backupConfig, err := s.backupConfigService.GetBackupConfigByDbId(databaseID)if err != nil {@@ -197,6 +154,7 @@ func (s *BackupsScheduler) StartBackup(databaseID uuid.UUID, isCallNotifier boolreturn}+ fmt.Println("make backup")backup := &backups_core.Backup{DatabaseID: backupConfig.DatabaseID,StorageID: *backupConfig.StorageID,@@ -369,6 +327,49 @@ func (s *BackupsScheduler) runPendingBackups() error {return nil}+func (s *BackupsScheduler) failBackupsInProgress() error {+ backupsInProgress, err := s.backupRepository.FindByStatus(backups_core.BackupStatusInProgress)+ if err != nil {+ return err+ }++ for _, backup := range backupsInProgress {+ if err := s.taskCancelManager.CancelTask(backup.ID); err != nil {+ s.logger.Error(+ "Failed to cancel backup via task cancel manager",+ "backupId",+ backup.ID,+ "error",+ err,+ )+ }++ backupConfig, err := s.backupConfigService.GetBackupConfigByDbId(backup.DatabaseID)+ if err != nil {+ s.logger.Error("Failed to get backup config by database ID", "error", err)+ continue+ }++ failMessage := "Backup failed due to application restart"+ backup.FailMessage = &failMessage+ backup.Status = backups_core.BackupStatusFailed+ backup.BackupSizeMb = 0++ s.backuperNode.SendBackupNotification(+ backupConfig,+ backup,+ backups_config.NotificationBackupFailed,+ &failMessage,+ )++ if err := s.backupRepository.Save(backup); err != nil {+ return err+ }+ }++ return nil+}+func (s *BackupsScheduler) calculateLeastBusyNode() (*uuid.UUID, error) {nodes, err := s.backupNodesRegistry.GetAvailableNodes()if err != nil {diff --git a/backend/internal/features/backups/backups/controller_test.go b/backend/internal/features/backups/backups/controller_test.goindex 140e472d..9c316f87 100644--- a/backend/internal/features/backups/backups/controller_test.go+++ b/backend/internal/features/backups/backups/controller_test.go@@ -80,7 +80,7 @@ func Test_GetBackups_PermissionsEnforced(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- database, _ := createTestDatabaseWithBackups(workspace, owner, router)+ database, _, storage := createTestDatabaseWithBackups(workspace, owner, router)var testUserToken stringif tt.isGlobalAdmin {@@ -122,6 +122,12 @@ func Test_GetBackups_PermissionsEnforced(t *testing.T) {} else {assert.Contains(t, string(testResp.Body), "insufficient permissions")}++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -218,6 +224,10 @@ func Test_CreateBackup_PermissionsEnforced(t *testing.T) {} else {assert.Contains(t, string(testResp.Body), "insufficient permissions")}++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -261,6 +271,10 @@ func Test_CreateBackup_AuditLogWritten(t *testing.T) {}}assert.True(t, found, "Audit log for backup creation not found")++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_DeleteBackup_PermissionsEnforced(t *testing.T) {@@ -314,7 +328,7 @@ func Test_DeleteBackup_PermissionsEnforced(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- database, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)var testUserToken stringif tt.isGlobalAdmin {@@ -358,6 +372,12 @@ func Test_DeleteBackup_PermissionsEnforced(t *testing.T) {assert.NoError(t, err)assert.Equal(t, 0, len(response.Backups))}++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -367,7 +387,7 @@ func Test_DeleteBackup_AuditLogWritten(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- database, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)test_utils.MakeDeleteRequest(t,@@ -398,6 +418,12 @@ func Test_DeleteBackup_AuditLogWritten(t *testing.T) {}}assert.True(t, found, "Audit log for backup deletion not found")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_GenerateDownloadToken_PermissionsEnforced(t *testing.T) {@@ -444,7 +470,7 @@ func Test_GenerateDownloadToken_PermissionsEnforced(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- _, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)var testUserToken stringif tt.isGlobalAdmin {@@ -488,6 +514,12 @@ func Test_GenerateDownloadToken_PermissionsEnforced(t *testing.T) {} else {assert.Contains(t, string(testResp.Body), "insufficient permissions")}++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -497,7 +529,7 @@ func Test_DownloadBackup_WithValidToken_Success(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- _, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)// Generate download tokenvar tokenResponse backups_download.GenerateDownloadTokenResponse@@ -524,6 +556,12 @@ func Test_DownloadBackup_WithValidToken_Success(t *testing.T) {contentDisposition := testResp.Headers.Get("Content-Disposition")assert.Contains(t, contentDisposition, "attachment")assert.Contains(t, contentDisposition, tokenResponse.Filename)++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_DownloadBackup_WithoutToken_Unauthorized(t *testing.T) {@@ -531,7 +569,7 @@ func Test_DownloadBackup_WithoutToken_Unauthorized(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- _, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)// Try to download without tokentestResp := test_utils.MakeGetRequest(@@ -543,6 +581,12 @@ func Test_DownloadBackup_WithoutToken_Unauthorized(t *testing.T) {)assert.Contains(t, string(testResp.Body), "download token is required")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_DownloadBackup_WithInvalidToken_Unauthorized(t *testing.T) {@@ -550,7 +594,7 @@ func Test_DownloadBackup_WithInvalidToken_Unauthorized(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- _, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)// Try to download with invalid tokentestResp := test_utils.MakeGetRequest(@@ -562,6 +606,12 @@ func Test_DownloadBackup_WithInvalidToken_Unauthorized(t *testing.T) {)assert.Contains(t, string(testResp.Body), "invalid or expired download token")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_DownloadBackup_WithExpiredToken_Unauthorized(t *testing.T) {@@ -569,7 +619,7 @@ func Test_DownloadBackup_WithExpiredToken_Unauthorized(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- database, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)// Get user for token generationuserService := users_services.GetUserService()@@ -611,6 +661,12 @@ func Test_DownloadBackup_WithExpiredToken_Unauthorized(t *testing.T) {}}assert.False(t, found, "Audit log should NOT be created for failed download with expired token")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_DownloadBackup_TokenUsedOnce_CannotReuseToken(t *testing.T) {@@ -618,7 +674,7 @@ func Test_DownloadBackup_TokenUsedOnce_CannotReuseToken(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- _, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)// Generate download tokenvar tokenResponse backups_download.GenerateDownloadTokenResponse@@ -651,6 +707,12 @@ func Test_DownloadBackup_TokenUsedOnce_CannotReuseToken(t *testing.T) {)assert.Contains(t, string(testResp.Body), "invalid or expired download token")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_DownloadBackup_WithDifferentBackupToken_Unauthorized(t *testing.T) {@@ -705,6 +767,13 @@ func Test_DownloadBackup_WithDifferentBackupToken_Unauthorized(t *testing.T) {)assert.Contains(t, string(testResp.Body), "invalid or expired download token")++ // Cleanup+ databases.RemoveTestDatabase(database1)+ databases.RemoveTestDatabase(database2)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_DownloadBackup_AuditLogWritten(t *testing.T) {@@ -712,7 +781,7 @@ func Test_DownloadBackup_AuditLogWritten(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- database, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)// Generate download tokenvar tokenResponse backups_download.GenerateDownloadTokenResponse@@ -756,6 +825,12 @@ func Test_DownloadBackup_AuditLogWritten(t *testing.T) {}}assert.True(t, found, "Audit log for backup download not found")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_DownloadBackup_ProperFilenameForPostgreSQL(t *testing.T) {@@ -856,6 +931,12 @@ func Test_DownloadBackup_ProperFilenameForPostgreSQL(t *testing.T) {contentDisposition,"Filename should contain timestamp",)++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -948,6 +1029,12 @@ func Test_CancelBackup_InProgressBackup_SuccessfullyCancelled(t *testing.T) {}}assert.True(t, foundCancelLog, "Cancel audit log should be created")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_ConcurrentDownloadPrevention(t *testing.T) {@@ -955,7 +1042,7 @@ func Test_ConcurrentDownloadPrevention(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- database, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)var token1Response backups_download.GenerateDownloadTokenResponsetest_utils.MakePostRequestAndUnmarshal(@@ -1003,6 +1090,12 @@ func Test_ConcurrentDownloadPrevention(t *testing.T) {if !service.IsDownloadInProgress(owner.UserID) {t.Log("Warning: First download completed before we could test concurrency")<-downloadComplete++ // Cleanup before early return+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)return}@@ -1049,6 +1142,12 @@ func Test_ConcurrentDownloadPrevention(t *testing.T) {t.Log("Successfully prevented concurrent downloads and allowed subsequent downloads after completion",)++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_GenerateDownloadToken_BlockedWhenDownloadInProgress(t *testing.T) {@@ -1056,7 +1155,7 @@ func Test_GenerateDownloadToken_BlockedWhenDownloadInProgress(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- database, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)var token1Response backups_download.GenerateDownloadTokenResponsetest_utils.MakePostRequestAndUnmarshal(@@ -1092,6 +1191,12 @@ func Test_GenerateDownloadToken_BlockedWhenDownloadInProgress(t *testing.T) {if !service.IsDownloadInProgress(owner.UserID) {t.Log("Warning: First download completed before we could test token generation blocking")<-downloadComplete++ // Cleanup before early return+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)return}@@ -1131,6 +1236,12 @@ func Test_GenerateDownloadToken_BlockedWhenDownloadInProgress(t *testing.T) {t.Log("Successfully blocked token generation during download and allowed generation after completion",)++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func createTestRouter() *gin.Engine {@@ -1222,7 +1333,7 @@ func createTestDatabaseWithBackups(workspace *workspaces_models.Workspace,owner *users_dto.SignInResponseDTO,router *gin.Engine,-) (*databases.Database, *backups_core.Backup) {+) (*databases.Database, *backups_core.Backup, *storages.Storage) {database := createTestDatabase("Test Database", workspace.ID, owner.Token, router)storage := createTestStorage(workspace.ID)@@ -1242,7 +1353,7 @@ func createTestDatabaseWithBackups(backup := createTestBackup(database, owner)- return database, backup+ return database, backup, storage}func createTestBackup(@@ -1320,7 +1431,7 @@ func Test_BandwidthThrottling_SingleDownload_Uses75Percent(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)- _, backup := createTestDatabaseWithBackups(workspace, owner, router)+ database, backup, storage := createTestDatabaseWithBackups(workspace, owner, router)bandwidthManager := backups_download.GetBandwidthManager()initialCount := bandwidthManager.GetActiveDownloadCount()@@ -1370,6 +1481,12 @@ func Test_BandwidthThrottling_SingleDownload_Uses75Percent(t *testing.T) {time.Sleep(50 * time.Millisecond)finalCount := bandwidthManager.GetActiveDownloadCount()assert.Equal(t, initialCount, finalCount, "Download should be unregistered after completion")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_BandwidthThrottling_MultipleDownloads_ShareBandwidth(t *testing.T) {@@ -1489,6 +1606,12 @@ func Test_BandwidthThrottling_MultipleDownloads_ShareBandwidth(t *testing.T) {time.Sleep(100 * time.Millisecond)finalCount := bandwidthManager.GetActiveDownloadCount()assert.Equal(t, initialCount, finalCount, "All downloads should be unregistered")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_BandwidthThrottling_DynamicAdjustment(t *testing.T) {@@ -1577,4 +1700,10 @@ func Test_BandwidthThrottling_DynamicAdjustment(t *testing.T) {time.Sleep(100 * time.Millisecond)finalCount := bandwidthManager.GetActiveDownloadCount()assert.Equal(t, initialCount, finalCount, "All downloads completed and unregistered")++ // Cleanup+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}diff --git a/backend/internal/features/backups/config/controller_test.go b/backend/internal/features/backups/config/controller_test.goindex 662487e4..7190c81d 100644--- a/backend/internal/features/backups/config/controller_test.go+++ b/backend/internal/features/backups/config/controller_test.go@@ -6,6 +6,7 @@ import ("net/http""strconv""testing"+ "time""github.com/gin-gonic/gin""github.com/google/uuid"@@ -92,6 +93,11 @@ func Test_SaveBackupConfig_PermissionsEnforced(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+var testUserToken stringif tt.isGlobalAdmin {admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)@@ -155,6 +161,11 @@ func Test_SaveBackupConfig_WhenUserIsNotWorkspaceMember_ReturnsForbidden(t *testdatabase := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+nonMember := users_testing.CreateTestUser(users_enums.UserRoleMember)timeOfDay := "04:00"@@ -245,6 +256,11 @@ func Test_GetBackupConfigByDbID_PermissionsEnforced(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+var testUserToken stringif tt.isGlobalAdmin {admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)@@ -293,6 +309,11 @@ func Test_GetBackupConfigByDbID_ReturnsDefaultConfigForNewDatabase(t *testing.T)database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+var response BackupConfigtest_utils.MakeGetRequestAndUnmarshal(t,@@ -331,6 +352,11 @@ func Test_GetDatabasePlan_ForNewDatabase_PlanAlwaysReturned(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+var response plans.DatabasePlantest_utils.MakeGetRequestAndUnmarshal(t,@@ -354,6 +380,11 @@ func Test_SaveBackupConfig_WhenPlanLimitsAreAdjusted_ValidationEnforced(t *testidatabase := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+// Get plan via API (triggers auto-creation)var plan plans.DatabasePlantest_utils.MakeGetRequestAndUnmarshal(@@ -533,6 +564,10 @@ func Test_IsStorageUsing_PermissionsEnforced(t *testing.T) {)storage := createTestStorage(workspace.ID)+ defer func() {+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+var testUserToken stringif tt.isStorageOwner {testUserToken = storageOwner.Token@@ -565,10 +600,6 @@ func Test_IsStorageUsing_PermissionsEnforced(t *testing.T) {)assert.Contains(t, string(testResp.Body), "error")}-- // Cleanup- storages.RemoveTestStorage(storage.ID)- workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -580,6 +611,11 @@ func Test_SaveBackupConfig_WithEncryptionNone_ConfigSaved(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+timeOfDay := "04:00"request := BackupConfig{DatabaseID: database.ID,@@ -619,6 +655,11 @@ func Test_SaveBackupConfig_WithEncryptionEncrypted_ConfigSaved(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+timeOfDay := "04:00"request := BackupConfig{DatabaseID: database.ID,@@ -729,6 +770,15 @@ func Test_TransferDatabase_PermissionsEnforced(t *testing.T) {targetStorage := createTestStorage(targetWorkspace.ID)+ defer func() {+ // Cleanup in correct order to avoid foreign key violations+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond) // Wait for cascade delete of backup_config+ storages.RemoveTestStorage(targetStorage.ID)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+var testUserToken stringif tt.isGlobalAdmin {admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)@@ -821,6 +871,12 @@ func Test_TransferDatabase_NonMemberInSourceWorkspace_CannotTransfer(t *testing.router,)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+request := TransferDatabaseRequest{TargetWorkspaceID: targetWorkspace.ID,}@@ -861,6 +917,12 @@ func Test_TransferDatabase_NonMemberInTargetWorkspace_CannotTransfer(t *testing.router,)+ defer func() {+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+request := TransferDatabaseRequest{TargetWorkspaceID: targetWorkspace.ID,}@@ -888,6 +950,13 @@ func Test_TransferDatabase_ToNewStorage_DatabaseTransferd(t *testing.T) {sourceStorage := createTestStorage(sourceWorkspace.ID)targetStorage := createTestStorage(targetWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ time.Sleep(200 * time.Millisecond) // Wait for cascading deletes+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+timeOfDay := "04:00"backupConfigRequest := BackupConfig{DatabaseID: database.ID,@@ -967,6 +1036,13 @@ func Test_TransferDatabase_WithExistingStorage_DatabaseAndStorageTransferd(t *tedatabase := createTestDatabaseViaAPI("Test Database", sourceWorkspace.ID, owner.Token, router)storage := createTestStorage(sourceWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ time.Sleep(200 * time.Millisecond) // Wait for cascading deletes+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+timeOfDay := "04:00"backupConfigRequest := BackupConfig{DatabaseID: database.ID,@@ -1056,6 +1132,14 @@ func Test_TransferDatabase_StorageHasOtherDBs_CannotTransfer(t *testing.T) {)storage := createTestStorage(sourceWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database1)+ databases.RemoveTestDatabase(database2)+ time.Sleep(200 * time.Millisecond) // Wait for cascading deletes+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+timeOfDay := "04:00"backupConfigRequest1 := BackupConfig{DatabaseID: database1.ID,@@ -1138,6 +1222,14 @@ func Test_TransferDatabase_WithNotifiers_NotifiersTransferred(t *testing.T) {targetStorage := createTestStorage(targetWorkspace.ID)notifier := notifiers.CreateTestNotifier(sourceWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ time.Sleep(200 * time.Millisecond)+ notifiers.RemoveTestNotifier(notifier)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+database.Notifiers = []notifiers.Notifier{*notifier}var updatedDatabase databases.Databasetest_utils.MakePostRequestAndUnmarshal(@@ -1241,6 +1333,15 @@ func Test_TransferDatabase_NotifierHasOtherDBs_NotifierSkipped(t *testing.T) {targetStorage := createTestStorage(targetWorkspace.ID)sharedNotifier := notifiers.CreateTestNotifier(sourceWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database1)+ databases.RemoveTestDatabase(database2)+ time.Sleep(200 * time.Millisecond)+ notifiers.RemoveTestNotifier(sharedNotifier)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+database1.Notifiers = []notifiers.Notifier{*sharedNotifier}test_utils.MakePostRequest(t,@@ -1353,6 +1454,16 @@ func Test_TransferDatabase_WithMultipleNotifiers_OnlyExclusiveOnesTransferred(texclusiveNotifier := notifiers.CreateTestNotifier(sourceWorkspace.ID)sharedNotifier := notifiers.CreateTestNotifier(sourceWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database1)+ databases.RemoveTestDatabase(database2)+ time.Sleep(200 * time.Millisecond)+ notifiers.RemoveTestNotifier(exclusiveNotifier)+ notifiers.RemoveTestNotifier(sharedNotifier)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+database1.Notifiers = []notifiers.Notifier{*exclusiveNotifier, *sharedNotifier}test_utils.MakePostRequest(t,@@ -1464,6 +1575,14 @@ func Test_TransferDatabase_WithTargetNotifiers_NotifiersAssigned(t *testing.T) {targetStorage := createTestStorage(targetWorkspace.ID)targetNotifier := notifiers.CreateTestNotifier(targetWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ time.Sleep(200 * time.Millisecond)+ notifiers.RemoveTestNotifier(targetNotifier)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+timeOfDay := "04:00"backupConfigRequest := BackupConfig{DatabaseID: database.ID,@@ -1535,6 +1654,15 @@ func Test_TransferDatabase_TargetNotifierFromDifferentWorkspace_ReturnsBadRequestargetStorage := createTestStorage(targetWorkspace.ID)wrongNotifier := notifiers.CreateTestNotifier(otherWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ time.Sleep(200 * time.Millisecond)+ notifiers.RemoveTestNotifier(wrongNotifier)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(otherWorkspace, router)+ }()+timeOfDay := "04:00"backupConfigRequest := BackupConfig{DatabaseID: database.ID,@@ -1592,6 +1720,14 @@ func Test_TransferDatabase_TargetStorageFromDifferentWorkspace_ReturnsBadRequestsourceStorage := createTestStorage(sourceWorkspace.ID)wrongStorage := createTestStorage(otherWorkspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ time.Sleep(200 * time.Millisecond)+ workspaces_testing.RemoveTestWorkspace(sourceWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ workspaces_testing.RemoveTestWorkspace(otherWorkspace, router)+ }()+timeOfDay := "04:00"backupConfigRequest := BackupConfig{DatabaseID: database.ID,@@ -1737,7 +1873,12 @@ func Test_SaveBackupConfig_WithSystemStorage_CanBeUsedByAnyDatabase(t *testing.Tassert.Equal(t, savedSystemStorage.ID, *savedConfig.StorageID)assert.True(t, savedConfig.IsBackupsEnabled)+ // Cleanup: database first (cascades to backup_config), then storages, then workspaces+ databases.RemoveTestDatabase(databaseA)storages.RemoveTestStorage(regularStorageB.ID)+ storages.RemoveTestStorage(savedSystemStorage.ID)+ workspaces_testing.RemoveTestWorkspace(workspaceA, router)+ workspaces_testing.RemoveTestWorkspace(workspaceB, router)}func createTestDatabaseViaAPI(diff --git a/backend/internal/features/backups/config/notifiers_test.go b/backend/internal/features/backups/config/notifiers_test.goindex 48b4dc4b..a4ed5a4e 100644--- a/backend/internal/features/backups/config/notifiers_test.go+++ b/backend/internal/features/backups/config/notifiers_test.go@@ -26,6 +26,12 @@ func Test_AttachNotifierFromSameWorkspace_SuccessfullyAttached(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)notifier := notifiers.CreateTestNotifier(workspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ notifiers.RemoveTestNotifier(notifier)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+database.Notifiers = []notifiers.Notifier{*notifier}var response databases.Database@@ -55,6 +61,13 @@ func Test_AttachNotifierFromDifferentWorkspace_ReturnsForbidden(t *testing.T) {workspace2 := workspaces_testing.CreateTestWorkspace("Workspace 2", owner2, router)notifier := notifiers.CreateTestNotifier(workspace2.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ notifiers.RemoveTestNotifier(notifier)+ workspaces_testing.RemoveTestWorkspace(workspace1, router)+ workspaces_testing.RemoveTestWorkspace(workspace2, router)+ }()+database.Notifiers = []notifiers.Notifier{*notifier}testResp := test_utils.MakePostRequest(@@ -77,6 +90,12 @@ func Test_DeleteNotifierWithAttachedDatabases_CannotDelete(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)notifier := notifiers.CreateTestNotifier(workspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ notifiers.RemoveTestNotifier(notifier)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+database.Notifiers = []notifiers.Notifier{*notifier}var response databases.Database@@ -114,6 +133,13 @@ func Test_TransferNotifierWithAttachedDatabase_CannotTransfer(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)notifier := notifiers.CreateTestNotifier(workspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ notifiers.RemoveTestNotifier(notifier)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+database.Notifiers = []notifiers.Notifier{*notifier}var response databases.Databasediff --git a/backend/internal/features/backups/config/storages_test.go b/backend/internal/features/backups/config/storages_test.goindex 6ee07535..82153b9f 100644--- a/backend/internal/features/backups/config/storages_test.go+++ b/backend/internal/features/backups/config/storages_test.go@@ -27,6 +27,12 @@ func Test_AttachStorageFromSameWorkspace_SuccessfullyAttached(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)storage := createTestStorage(workspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+timeOfDay := "04:00"request := BackupConfig{DatabaseID: database.ID,@@ -72,6 +78,13 @@ func Test_AttachStorageFromDifferentWorkspace_ReturnsForbidden(t *testing.T) {workspace2 := workspaces_testing.CreateTestWorkspace("Workspace 2", owner2, router)storage := createTestStorage(workspace2.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace1, router)+ workspaces_testing.RemoveTestWorkspace(workspace2, router)+ }()+timeOfDay := "04:00"request := BackupConfig{DatabaseID: database.ID,@@ -110,6 +123,12 @@ func Test_DeleteStorageWithAttachedDatabases_CannotDelete(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)storage := createTestStorage(workspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ }()+timeOfDay := "04:00"request := BackupConfig{DatabaseID: database.ID,@@ -163,6 +182,13 @@ func Test_TransferStorageWithAttachedDatabase_CannotTransfer(t *testing.T) {database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)storage := createTestStorage(workspace.ID)+ defer func() {+ databases.RemoveTestDatabase(database)+ storages.RemoveTestStorage(storage.ID)+ workspaces_testing.RemoveTestWorkspace(workspace, router)+ workspaces_testing.RemoveTestWorkspace(targetWorkspace, router)+ }()+timeOfDay := "04:00"request := BackupConfig{DatabaseID: database.ID,diff --git a/backend/internal/features/databases/controller_test.go b/backend/internal/features/databases/controller_test.goindex 157eabe0..394686e8 100644--- a/backend/internal/features/databases/controller_test.go+++ b/backend/internal/features/databases/controller_test.go@@ -25,80 +25,6 @@ import ("databasus-backend/internal/util/tools")-func createTestRouter() *gin.Engine {- router := workspaces_testing.CreateTestRouter(- workspaces_controllers.GetWorkspaceController(),- workspaces_controllers.GetMembershipController(),- GetDatabaseController(),- )- return router-}--func getTestPostgresConfig() *postgresql.PostgresqlDatabase {- env := config.GetEnv()- port, err := strconv.Atoi(env.TestPostgres16Port)- if err != nil {- panic(fmt.Sprintf("Failed to parse TEST_POSTGRES_16_PORT: %v", err))- }-- testDbName := "testdb"- return &postgresql.PostgresqlDatabase{- Version: tools.PostgresqlVersion16,- Host: config.GetEnv().TestLocalhost,- Port: port,- Username: "testuser",- Password: "testpassword",- Database: &testDbName,- CpuCount: 1,- }-}--func getTestMariadbConfig() *mariadb.MariadbDatabase {- env := config.GetEnv()- portStr := env.TestMariadb1011Port- if portStr == "" {- portStr = "33111"- }- port, err := strconv.Atoi(portStr)- if err != nil {- panic(fmt.Sprintf("Failed to parse TEST_MARIADB_1011_PORT: %v", err))- }-- testDbName := "testdb"- return &mariadb.MariadbDatabase{- Version: tools.MariadbVersion1011,- Host: config.GetEnv().TestLocalhost,- Port: port,- Username: "testuser",- Password: "testpassword",- Database: &testDbName,- }-}--func getTestMongodbConfig() *mongodb.MongodbDatabase {- env := config.GetEnv()- portStr := env.TestMongodb70Port- if portStr == "" {- portStr = "27070"- }- port, err := strconv.Atoi(portStr)- if err != nil {- panic(fmt.Sprintf("Failed to parse TEST_MONGODB_70_PORT: %v", err))- }-- return &mongodb.MongodbDatabase{- Version: tools.MongodbVersion7,- Host: config.GetEnv().TestLocalhost,- Port: port,- Username: "root",- Password: "rootpassword",- Database: "testdb",- AuthDatabase: "admin",- IsHttps: false,- CpuCount: 1,- }-}-func Test_CreateDatabase_PermissionsEnforced(t *testing.T) {tests := []struct {name string@@ -142,6 +68,7 @@ func Test_CreateDatabase_PermissionsEnforced(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)var testUserToken stringif tt.isGlobalAdmin {@@ -180,6 +107,7 @@ func Test_CreateDatabase_PermissionsEnforced(t *testing.T) {)if tt.expectSuccess {+ defer RemoveTestDatabase(&response)assert.Equal(t, "Test Database", response.Name)assert.NotEqual(t, uuid.Nil, response.ID)} else {@@ -193,6 +121,7 @@ func Test_CreateDatabase_WhenUserIsNotWorkspaceMember_ReturnsForbidden(t *testinrouter := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)nonMember := users_testing.CreateTestUser(users_enums.UserRoleMember)@@ -258,8 +187,10 @@ func Test_UpdateDatabase_PermissionsEnforced(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(database)var testUserToken stringif tt.isGlobalAdmin {@@ -305,8 +236,10 @@ func Test_UpdateDatabase_WhenUserIsNotWorkspaceMember_ReturnsForbidden(t *testinrouter := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(database)nonMember := users_testing.CreateTestUser(users_enums.UserRoleMember)database.Name = "Hacked Name"@@ -366,6 +299,7 @@ func Test_DeleteDatabase_PermissionsEnforced(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)@@ -396,6 +330,7 @@ func Test_DeleteDatabase_PermissionsEnforced(t *testing.T) {)if !tt.expectSuccess {+ defer RemoveTestDatabase(database)assert.Contains(t, string(testResp.Body), "insufficient permissions")}})@@ -439,8 +374,10 @@ func Test_GetDatabase_PermissionsEnforced(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(database)var testUser stringif tt.isGlobalAdmin {@@ -517,9 +454,12 @@ func Test_GetDatabasesByWorkspace_PermissionsEnforced(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)- createTestDatabaseViaAPI("Database 1", workspace.ID, owner.Token, router)- createTestDatabaseViaAPI("Database 2", workspace.ID, owner.Token, router)+ db1 := createTestDatabaseViaAPI("Database 1", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(db1)+ db2 := createTestDatabaseViaAPI("Database 2", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(db2)var testUser stringif tt.isGlobalAdmin {@@ -561,10 +501,14 @@ func Test_GetDatabasesByWorkspace_WhenMultipleDatabasesExist_ReturnsCorrectCountrouter := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)- createTestDatabaseViaAPI("Database 1", workspace.ID, owner.Token, router)- createTestDatabaseViaAPI("Database 2", workspace.ID, owner.Token, router)- createTestDatabaseViaAPI("Database 3", workspace.ID, owner.Token, router)+ db1 := createTestDatabaseViaAPI("Database 1", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(db1)+ db2 := createTestDatabaseViaAPI("Database 2", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(db2)+ db3 := createTestDatabaseViaAPI("Database 3", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(db3)var response []Databasetest_utils.MakeGetRequestAndUnmarshal(@@ -583,14 +527,19 @@ func Test_GetDatabasesByWorkspace_EnsuresCrossWorkspaceIsolation(t *testing.T) {router := createTestRouter()owner1 := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace1 := workspaces_testing.CreateTestWorkspace("Workspace 1", owner1, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace1, router)owner2 := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace2 := workspaces_testing.CreateTestWorkspace("Workspace 2", owner2, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace2, router)- createTestDatabaseViaAPI("Workspace1 DB1", workspace1.ID, owner1.Token, router)- createTestDatabaseViaAPI("Workspace1 DB2", workspace1.ID, owner1.Token, router)+ workspace1Db1 := createTestDatabaseViaAPI("Workspace1 DB1", workspace1.ID, owner1.Token, router)+ defer RemoveTestDatabase(workspace1Db1)+ workspace1Db2 := createTestDatabaseViaAPI("Workspace1 DB2", workspace1.ID, owner1.Token, router)+ defer RemoveTestDatabase(workspace1Db2)- createTestDatabaseViaAPI("Workspace2 DB1", workspace2.ID, owner2.Token, router)+ workspace2Db1 := createTestDatabaseViaAPI("Workspace2 DB1", workspace2.ID, owner2.Token, router)+ defer RemoveTestDatabase(workspace2Db1)var workspace1Dbs []Databasetest_utils.MakeGetRequestAndUnmarshal(@@ -667,8 +616,10 @@ func Test_CopyDatabase_PermissionsEnforced(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(database)var testUserToken stringif tt.isGlobalAdmin {@@ -700,6 +651,7 @@ func Test_CopyDatabase_PermissionsEnforced(t *testing.T) {)if tt.expectSuccess {+ defer RemoveTestDatabase(&response)assert.NotEqual(t, database.ID, response.ID)assert.Contains(t, response.Name, "(Copy)")} else {@@ -713,8 +665,10 @@ func Test_CopyDatabase_CopyStaysInSameWorkspace(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(database)var response Databasetest_utils.MakePostRequestAndUnmarshal(@@ -727,139 +681,14 @@ func Test_CopyDatabase_CopyStaysInSameWorkspace(t *testing.T) {&response,)+ defer RemoveTestDatabase(&response)+assert.NotEqual(t, database.ID, response.ID)assert.Equal(t, "Test Database (Copy)", response.Name)assert.Equal(t, workspace.ID, *response.WorkspaceID)assert.Equal(t, database.Type, response.Type)}-func Test_TestConnection_PermissionsEnforced(t *testing.T) {- tests := []struct {- name string- isMember bool- isGlobalAdmin bool- expectAccessGranted bool- expectedStatusCodeOnErr int- }{- {- name: "workspace member can test connection",- isMember: true,- isGlobalAdmin: false,- expectAccessGranted: true,- expectedStatusCodeOnErr: http.StatusBadRequest,- },- {- name: "non-member cannot test connection",- isMember: false,- isGlobalAdmin: false,- expectAccessGranted: false,- expectedStatusCodeOnErr: http.StatusBadRequest,- },- {- name: "global admin can test connection",- isMember: false,- isGlobalAdmin: true,- expectAccessGranted: true,- expectedStatusCodeOnErr: http.StatusBadRequest,- },- }-- for _, tt := range tests {- t.Run(tt.name, func(t *testing.T) {- router := createTestRouter()- owner := users_testing.CreateTestUser(users_enums.UserRoleMember)- workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)-- database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)-- var testUser string- if tt.isGlobalAdmin {- admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)- testUser = admin.Token- } else if tt.isMember {- testUser = owner.Token- } else {- nonMember := users_testing.CreateTestUser(users_enums.UserRoleMember)- testUser = nonMember.Token- }-- w := workspaces_testing.MakeAPIRequest(- router,- "POST",- "/api/v1/databases/"+database.ID.String()+"/test-connection",- "Bearer "+testUser,- nil,- )-- body := w.Body.String()-- if tt.expectAccessGranted {- assert.True(- t,- w.Code == http.StatusOK ||- (w.Code == http.StatusBadRequest && strings.Contains(body, "connect")),- "Expected 200 OK or 400 with connection error, got %d: %s",- w.Code,- body,- )- } else {- assert.Equal(t, tt.expectedStatusCodeOnErr, w.Code)- assert.Contains(t, body, "insufficient permissions")- }- })- }-}--func createTestDatabaseViaAPI(- name string,- workspaceID uuid.UUID,- token string,- router *gin.Engine,-) *Database {- env := config.GetEnv()- port, err := strconv.Atoi(env.TestPostgres16Port)- if err != nil {- panic(fmt.Sprintf("Failed to parse TEST_POSTGRES_16_PORT: %v", err))- }-- testDbName := "testdb"- request := Database{- Name: name,- WorkspaceID: &workspaceID,- Type: DatabaseTypePostgres,- Postgresql: &postgresql.PostgresqlDatabase{- Version: tools.PostgresqlVersion16,- Host: config.GetEnv().TestLocalhost,- Port: port,- Username: "testuser",- Password: "testpassword",- Database: &testDbName,- CpuCount: 1,- },- }-- w := workspaces_testing.MakeAPIRequest(- router,- "POST",- "/api/v1/databases/create",- "Bearer "+token,- request,- )-- if w.Code != http.StatusCreated {- panic(- fmt.Sprintf("Failed to create database. Status: %d, Body: %s", w.Code, w.Body.String()),- )- }-- var database Database- if err := json.Unmarshal(w.Body.Bytes(), &database); err != nil {- panic(err)- }-- return &database-}-func Test_CreateDatabase_PasswordIsEncryptedInDB(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)@@ -1141,3 +970,206 @@ func Test_DatabaseSensitiveDataLifecycle_AllTypes(t *testing.T) {})}}++func Test_TestConnection_PermissionsEnforced(t *testing.T) {+ tests := []struct {+ name string+ isMember bool+ isGlobalAdmin bool+ expectAccessGranted bool+ expectedStatusCodeOnErr int+ }{+ {+ name: "workspace member can test connection",+ isMember: true,+ isGlobalAdmin: false,+ expectAccessGranted: true,+ expectedStatusCodeOnErr: http.StatusBadRequest,+ },+ {+ name: "non-member cannot test connection",+ isMember: false,+ isGlobalAdmin: false,+ expectAccessGranted: false,+ expectedStatusCodeOnErr: http.StatusBadRequest,+ },+ {+ name: "global admin can test connection",+ isMember: false,+ isGlobalAdmin: true,+ expectAccessGranted: true,+ expectedStatusCodeOnErr: http.StatusBadRequest,+ },+ }++ for _, tt := range tests {+ t.Run(tt.name, func(t *testing.T) {+ router := createTestRouter()+ owner := users_testing.CreateTestUser(users_enums.UserRoleMember)+ workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)++ database := createTestDatabaseViaAPI("Test Database", workspace.ID, owner.Token, router)+ defer RemoveTestDatabase(database)++ var testUser string+ if tt.isGlobalAdmin {+ admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)+ testUser = admin.Token+ } else if tt.isMember {+ testUser = owner.Token+ } else {+ nonMember := users_testing.CreateTestUser(users_enums.UserRoleMember)+ testUser = nonMember.Token+ }++ w := workspaces_testing.MakeAPIRequest(+ router,+ "POST",+ "/api/v1/databases/"+database.ID.String()+"/test-connection",+ "Bearer "+testUser,+ nil,+ )++ body := w.Body.String()++ if tt.expectAccessGranted {+ assert.True(+ t,+ w.Code == http.StatusOK ||+ (w.Code == http.StatusBadRequest && strings.Contains(body, "connect")),+ "Expected 200 OK or 400 with connection error, got %d: %s",+ w.Code,+ body,+ )+ } else {+ assert.Equal(t, tt.expectedStatusCodeOnErr, w.Code)+ assert.Contains(t, body, "insufficient permissions")+ }+ })+ }+}++func createTestDatabaseViaAPI(+ name string,+ workspaceID uuid.UUID,+ token string,+ router *gin.Engine,+) *Database {+ env := config.GetEnv()+ port, err := strconv.Atoi(env.TestPostgres16Port)+ if err != nil {+ panic(fmt.Sprintf("Failed to parse TEST_POSTGRES_16_PORT: %v", err))+ }++ testDbName := "testdb"+ request := Database{+ Name: name,+ WorkspaceID: &workspaceID,+ Type: DatabaseTypePostgres,+ Postgresql: &postgresql.PostgresqlDatabase{+ Version: tools.PostgresqlVersion16,+ Host: config.GetEnv().TestLocalhost,+ Port: port,+ Username: "testuser",+ Password: "testpassword",+ Database: &testDbName,+ CpuCount: 1,+ },+ }++ w := workspaces_testing.MakeAPIRequest(+ router,+ "POST",+ "/api/v1/databases/create",+ "Bearer "+token,+ request,+ )++ if w.Code != http.StatusCreated {+ panic(+ fmt.Sprintf("Failed to create database. Status: %d, Body: %s", w.Code, w.Body.String()),+ )+ }++ var database Database+ if err := json.Unmarshal(w.Body.Bytes(), &database); err != nil {+ panic(err)+ }++ return &database+}++func createTestRouter() *gin.Engine {+ router := workspaces_testing.CreateTestRouter(+ workspaces_controllers.GetWorkspaceController(),+ workspaces_controllers.GetMembershipController(),+ GetDatabaseController(),+ )+ return router+}++func getTestPostgresConfig() *postgresql.PostgresqlDatabase {+ env := config.GetEnv()+ port, err := strconv.Atoi(env.TestPostgres16Port)+ if err != nil {+ panic(fmt.Sprintf("Failed to parse TEST_POSTGRES_16_PORT: %v", err))+ }++ testDbName := "testdb"+ return &postgresql.PostgresqlDatabase{+ Version: tools.PostgresqlVersion16,+ Host: config.GetEnv().TestLocalhost,+ Port: port,+ Username: "testuser",+ Password: "testpassword",+ Database: &testDbName,+ CpuCount: 1,+ }+}++func getTestMariadbConfig() *mariadb.MariadbDatabase {+ env := config.GetEnv()+ portStr := env.TestMariadb1011Port+ if portStr == "" {+ portStr = "33111"+ }+ port, err := strconv.Atoi(portStr)+ if err != nil {+ panic(fmt.Sprintf("Failed to parse TEST_MARIADB_1011_PORT: %v", err))+ }++ testDbName := "testdb"+ return &mariadb.MariadbDatabase{+ Version: tools.MariadbVersion1011,+ Host: config.GetEnv().TestLocalhost,+ Port: port,+ Username: "testuser",+ Password: "testpassword",+ Database: &testDbName,+ }+}++func getTestMongodbConfig() *mongodb.MongodbDatabase {+ env := config.GetEnv()+ portStr := env.TestMongodb70Port+ if portStr == "" {+ portStr = "27070"+ }+ port, err := strconv.Atoi(portStr)+ if err != nil {+ panic(fmt.Sprintf("Failed to parse TEST_MONGODB_70_PORT: %v", err))+ }++ return &mongodb.MongodbDatabase{+ Version: tools.MongodbVersion7,+ Host: config.GetEnv().TestLocalhost,+ Port: port,+ Username: "root",+ Password: "rootpassword",+ Database: "testdb",+ AuthDatabase: "admin",+ IsHttps: false,+ CpuCount: 1,+ }+}diff --git a/backend/internal/features/healthcheck/attempt/controller_test.go b/backend/internal/features/healthcheck/attempt/controller_test.goindex e0aaea41..89f096b3 100644--- a/backend/internal/features/healthcheck/attempt/controller_test.go+++ b/backend/internal/features/healthcheck/attempt/controller_test.go@@ -144,6 +144,10 @@ func Test_GetAttemptsByDatabase_PermissionsEnforced(t *testing.T) {)assert.Contains(t, string(testResp.Body), "forbidden")}++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -181,6 +185,10 @@ func Test_GetAttemptsByDatabase_FiltersByAfterDate(t *testing.T) {for _, attempt := range response {assert.True(t, attempt.CreatedAt.After(afterDate) || attempt.CreatedAt.Equal(afterDate))}++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_GetAttemptsByDatabase_ReturnsEmptyListForNewDatabase(t *testing.T) {@@ -201,6 +209,10 @@ func Test_GetAttemptsByDatabase_ReturnsEmptyListForNewDatabase(t *testing.T) {)assert.Equal(t, 0, len(response))++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func createTestDatabaseViaAPI(diff --git a/backend/internal/features/healthcheck/config/controller_test.go b/backend/internal/features/healthcheck/config/controller_test.goindex 1b50e692..235f5ca7 100644--- a/backend/internal/features/healthcheck/config/controller_test.go+++ b/backend/internal/features/healthcheck/config/controller_test.go@@ -130,6 +130,10 @@ func Test_SaveHealthcheckConfig_PermissionsEnforced(t *testing.T) {)assert.Contains(t, string(testResp.Body), "insufficient permissions")}++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -162,6 +166,10 @@ func Test_SaveHealthcheckConfig_WhenUserIsNotWorkspaceMember_ReturnsForbidden(t)assert.Contains(t, string(testResp.Body), "insufficient permissions")++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func Test_GetHealthcheckConfig_PermissionsEnforced(t *testing.T) {@@ -268,6 +276,10 @@ func Test_GetHealthcheckConfig_PermissionsEnforced(t *testing.T) {)assert.Contains(t, string(testResp.Body), "insufficient permissions")}++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}@@ -295,6 +307,10 @@ func Test_GetHealthcheckConfig_ReturnsDefaultConfigForNewDatabase(t *testing.T)assert.Equal(t, 1, response.IntervalMinutes)assert.Equal(t, 3, response.AttemptsBeforeConcideredAsDown)assert.Equal(t, 7, response.StoreAttemptsDays)++ // Cleanup+ databases.RemoveTestDatabase(database)+ workspaces_testing.RemoveTestWorkspace(workspace, router)}func createTestDatabaseViaAPI(diff --git a/backend/internal/features/restores/controller_test.go b/backend/internal/features/restores/controller_test.goindex 33790b78..3a780ef0 100644--- a/backend/internal/features/restores/controller_test.go+++ b/backend/internal/features/restores/controller_test.go@@ -46,8 +46,10 @@ func Test_GetRestores_WhenUserIsWorkspaceMember_RestoresReturned(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)database, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)var restores []*restores_core.Restoretest_utils.MakeGetRequestAndUnmarshal(@@ -68,8 +70,10 @@ func Test_GetRestores_WhenUserIsNotWorkspaceMember_ReturnsForbidden(t *testing.Trouter := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)- _, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ database, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)nonMember := users_testing.CreateTestUser(users_enums.UserRoleMember)@@ -88,8 +92,10 @@ func Test_GetRestores_WhenUserIsGlobalAdmin_RestoresReturned(t *testing.T) {router := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)- _, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ database, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)@@ -114,8 +120,10 @@ func Test_RestoreBackup_WhenUserIsWorkspaceMember_RestoreInitiated(t *testing.T)owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)- _, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ database, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)request := restores_core.RestoreBackupRequest{PostgresqlDatabase: &postgresql.PostgresqlDatabase{@@ -143,8 +151,10 @@ func Test_RestoreBackup_WhenUserIsNotWorkspaceMember_ReturnsForbidden(t *testingrouter := createTestRouter()owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)- _, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ database, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)nonMember := users_testing.CreateTestUser(users_enums.UserRoleMember)@@ -178,8 +188,10 @@ func Test_RestoreBackup_WithIsExcludeExtensions_FlagPassedCorrectly(t *testing.Towner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)- _, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ database, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)request := restores_core.RestoreBackupRequest{PostgresqlDatabase: &postgresql.PostgresqlDatabase{@@ -212,8 +224,10 @@ func Test_RestoreBackup_AuditLogWritten(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)database, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)request := restores_core.RestoreBackupRequest{PostgresqlDatabase: &postgresql.PostgresqlDatabase{@@ -296,12 +310,16 @@ func Test_RestoreBackup_DiskSpaceValidation(t *testing.T) {owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+ var database *databases.Databasevar backup *backups_core.Backup+ var storage *storages.Storagevar request restores_core.RestoreBackupRequestif tc.dbType == databases.DatabaseTypePostgres {- _, backup = createTestDatabaseWithBackupForRestore(workspace, owner, router)+ database, backup = createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)request = restores_core.RestoreBackupRequest{PostgresqlDatabase: &postgresql.PostgresqlDatabase{Version: tools.PostgresqlVersion16,@@ -319,7 +337,16 @@ func Test_RestoreBackup_DiskSpaceValidation(t *testing.T) {owner.Token,router,)- storage := createTestStorage(workspace.ID)+ database = mysqlDB+ storage = createTestStorage(workspace.ID)++ defer func() {+ // Cleanup in dependency order: backup -> database -> storage+ cleanupBackup(backup)+ databases.RemoveTestDatabase(mysqlDB)+ time.Sleep(50 * time.Millisecond)+ storages.RemoveTestStorage(storage.ID)+ }()configService := backups_config.GetBackupConfigService()config, err := configService.GetBackupConfigByDbId(mysqlDB.ID)@@ -332,6 +359,7 @@ func Test_RestoreBackup_DiskSpaceValidation(t *testing.T) {assert.NoError(t, err)backup = createTestBackup(mysqlDB, owner)+request = restores_core.RestoreBackupRequest{MysqlDatabase: &mysql.MysqlDatabase{Version: tools.MysqlVersion80,@@ -519,8 +547,10 @@ func Test_RestoreBackup_WithParallelRestoreInProgress_ReturnsError(t *testing.T)owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)- _, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ database, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)+ defer cleanupDatabaseWithBackup(database, backup)request := restores_core.RestoreBackupRequest{PostgresqlDatabase: &postgresql.PostgresqlDatabase{@@ -741,3 +771,22 @@ func createTestBackup(return backup}++func cleanupDatabaseWithBackup(database *databases.Database, backup *backups_core.Backup) {+ // Clean up in reverse dependency order+ cleanupBackup(backup)+ databases.RemoveTestDatabase(database)+ time.Sleep(50 * time.Millisecond)++ // Clean up storage last (after database and backup are removed)+ configService := backups_config.GetBackupConfigService()+ config, err := configService.GetBackupConfigByDbId(database.ID)+ if err == nil && config.StorageID != nil {+ storages.RemoveTestStorage(*config.StorageID)+ }+}++func cleanupBackup(backup *backups_core.Backup) {+ repo := &backups_core.BackupRepository{}+ repo.DeleteByID(backup.ID)+}diff --git a/backend/internal/features/storages/controller_test.go b/backend/internal/features/storages/controller_test.goindex ec9fda7a..7d10dd22 100644--- a/backend/internal/features/storages/controller_test.go+++ b/backend/internal/features/storages/controller_test.go@@ -1653,6 +1653,10 @@ func Test_StorageSensitiveDataLifecycle_AllTypes(t *testing.T) {&finalRetrieved,)tc.verifyHiddenData(t, &finalRetrieved)++ // Cleanup+ deleteStorage(t, router, createdStorage.ID, owner.Token)+ workspaces_testing.RemoveTestWorkspace(workspace, router)})}}diff --git a/backend/internal/features/workspaces/controllers/membership_controller_test.go b/backend/internal/features/workspaces/controllers/membership_controller_test.goindex b117adef..cb73439b 100644--- a/backend/internal/features/workspaces/controllers/membership_controller_test.go+++ b/backend/internal/features/workspaces/controllers/membership_controller_test.go@@ -82,6 +82,8 @@ func Test_GetWorkspaceMembers_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)var testUserToken stringif tt.isGlobalAdmin {@@ -210,6 +212,8 @@ func Test_AddMemberToWorkspace_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)var testUserToken stringif tt.isGlobalAdmin {@@ -270,6 +274,8 @@ func Test_AddMemberToWorkspace_WhenUserIsAlreadyMember_ReturnsBadRequest(t *testmember := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,member,@@ -302,6 +308,7 @@ func Test_AddMemberToWorkspace_WithNonExistentUser_ReturnsInvited(t *testing.T)owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)request := workspaces_dto.AddMemberRequestDTO{Email: uuid.New().String() + "@example.com", // Non-existent user@@ -332,6 +339,8 @@ func Test_AddMemberToWorkspace_WhenWorkspaceAdminTriesToAddAdmin_ReturnsBadRequenewMember := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,workspaceAdmin,@@ -368,6 +377,8 @@ func Test_AddMemberToWorkspace_WhenWorkspaceAdminTriesToAddWorkspaceAdmin_ReturnnewMember := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,workspaceAdmin,@@ -450,6 +461,8 @@ func Test_AddWorkspaceAdmin_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)var testUserToken stringif tt.isGlobalAdmin {@@ -561,6 +574,7 @@ func Test_InviteMemberToWorkspace_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)var testUserToken stringif tt.isGlobalAdmin {@@ -672,6 +686,7 @@ func Test_ChangeMemberRole_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,@@ -774,6 +789,7 @@ func Test_ChangeMemberRoleToAdmin_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,@@ -832,6 +848,7 @@ func Test_ChangeMemberRole_WhenChangingOwnRole_ReturnsBadRequest(t *testing.T) {)owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)request := workspaces_dto.ChangeMemberRoleRequestDTO{Role: users_enums.WorkspaceRoleMember,@@ -861,6 +878,7 @@ func Test_ChangeMemberRole_WhenChangingOwnerRole_ReturnsBadRequest(t *testing.T)owner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)request := workspaces_dto.ChangeMemberRoleRequestDTO{Role: users_enums.WorkspaceRoleMember,@@ -941,6 +959,7 @@ func Test_RemoveMemberFromWorkspace_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,@@ -995,6 +1014,7 @@ func Test_RemoveMemberFromWorkspace_WhenRemovingOwner_ReturnsBadRequest(t *testiowner := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)resp := test_utils.MakeRequest(t, router, test_utils.RequestOptions{Method: "DELETE",@@ -1061,6 +1081,7 @@ func Test_RemoveWorkspaceAdmin_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,@@ -1165,6 +1186,7 @@ func Test_TransferWorkspaceOwnership_PermissionsEnforced(t *testing.T) {owner,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,@@ -1225,6 +1247,7 @@ func Test_TransferWorkspaceOwnership_WhenNewOwnerIsNotMember_ReturnsBadRequest(tnonMember := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)request := workspaces_dto.TransferOwnershipRequestDTO{NewOwnerEmail: nonMember.Email,@@ -1250,6 +1273,8 @@ func Test_TransferWorkspaceOwnership_ThereIsOnlyOneOwner_OldOwnerBecomeAdmin(t *member := users_testing.CreateTestUser(users_enums.UserRoleMember)workspace, _ := workspaces_testing.CreateTestWorkspaceViaAPI("Test Workspace", owner, router)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+workspaces_testing.AddMemberToWorkspaceViaOwner(workspace,member,diff --git a/backend/internal/features/workspaces/controllers/workspace_controller_test.go b/backend/internal/features/workspaces/controllers/workspace_controller_test.goindex c381f275..826de085 100644--- a/backend/internal/features/workspaces/controllers/workspace_controller_test.go+++ b/backend/internal/features/workspaces/controllers/workspace_controller_test.go@@ -91,6 +91,10 @@ func Test_CreateWorkspace_PermissionsEnforced(t *testing.T) {assert.Equal(t, workspaceName, response.Name)assert.NotEqual(t, uuid.Nil, response.ID)assert.Equal(t, users_enums.WorkspaceRoleOwner, *response.UserRole)++ // Cleanup created workspace+ workspace := &workspaces_models.Workspace{ID: response.ID}+ workspaces_testing.RemoveTestWorkspace(workspace, router)} else {resp := test_utils.MakePostRequest(t,@@ -160,11 +164,14 @@ func Test_GetUserWorkspaces_WhenUserHasWorkspaces_ReturnsWorkspacesList(t *testiuser.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace1, router)+workspace2, _ := workspaces_testing.CreateTestWorkspaceWithToken("Workspace 2",user.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace2, router)var response workspaces_dto.ListWorkspacesResponseDTOtest_utils.MakeGetRequestAndUnmarshal(@@ -258,6 +265,7 @@ func Test_GetSingleWorkspace_PermissionsEnforced(t *testing.T) {owner.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)var testUserToken stringif tt.isGlobalAdmin {@@ -369,6 +377,7 @@ func Test_UpdateWorkspace_PermissionsEnforced(t *testing.T) {owner.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)var testUserToken stringif tt.workspaceRole == users_enums.WorkspaceRoleOwner {@@ -472,6 +481,10 @@ func Test_DeleteWorkspace_PermissionsEnforced(t *testing.T) {owner.Token,router,)+ // Only cleanup if the test doesn't successfully delete the workspace+ if !tt.expectSuccess {+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)+ }var testUserToken stringif tt.isGlobalAdmin {@@ -526,6 +539,7 @@ func Test_GetWorkspaceAuditLogs_WhenUserIsWorkspaceAdmin_ReturnsAuditLogs(t *tesowner.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)workspaces_testing.AddMemberToWorkspace(workspace,@@ -565,11 +579,14 @@ func Test_GetWorkspaceAuditLogs_WithMultipleWorkspaces_ReturnsOnlyWorkspaceSpeciowner1.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace1, router)+workspace2, _ := workspaces_testing.CreateTestWorkspaceWithToken(workspaceName2,owner2.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace2, router)updateWorkspace1 := workspaces_models.Workspace{Name: "Updated " + workspace1.Name,@@ -656,6 +673,7 @@ func Test_GetWorkspaceAuditLogs_WithDifferentUserRoles_EnforcesPermissionsCorrecowner.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)workspaces_testing.AddMemberToWorkspace(workspace,@@ -703,6 +721,7 @@ func Test_GetWorkspaceAuditLogs_WithoutAuthToken_ReturnsUnauthorized(t *testing.owner.Token,router,)+ defer workspaces_testing.RemoveTestWorkspace(workspace, router)test_utils.MakeGetRequest(t, router,"/api/v1/workspaces/"+workspace.ID.String()+"/audit-logs",diff --git a/backend/internal/features/workspaces/testing/testing.go b/backend/internal/features/workspaces/testing/testing.goindex e11f06b2..b4fb60eb 100644--- a/backend/internal/features/workspaces/testing/testing.go+++ b/backend/internal/features/workspaces/testing/testing.go@@ -375,7 +375,13 @@ func RemoveTestWorkspace(workspace *workspaces_models.Workspace, router *gin.EngmembershipRepo := &workspaces_repositories.MembershipRepository{}workspaceMembers, err := membershipRepo.GetWorkspaceMembers(workspace.ID)if err != nil {- panic("Failed to get workspace members: " + err.Error())+ // Workspace might already be deleted or doesn't exist, silently return+ return+ }++ if len(workspaceMembers) == 0 {+ // No members found, workspace might have been deleted, silently return+ return}var ownerToken string@@ -385,12 +391,16 @@ func RemoveTestWorkspace(workspace *workspaces_models.Workspace, router *gin.Engowner, err := userService.GetUserByID(m.UserID)if err != nil {- panic("Failed to get owner user: " + err.Error())+ // Owner user not found, workspace might be in inconsistent state, try direct deletion+ _ = RemoveTestWorkspaceDirect(workspace.ID)+ return}tokenResponse, err := userService.GenerateAccessToken(owner)if err != nil {- panic("Failed to generate owner token: " + err.Error())+ // Cannot generate token, try direct deletion+ _ = RemoveTestWorkspaceDirect(workspace.ID)+ return}ownerToken = tokenResponse.Token@@ -399,7 +409,9 @@ func RemoveTestWorkspace(workspace *workspaces_models.Workspace, router *gin.Eng}if ownerToken == "" {- panic("No workspace owner found")+ // No owner found, try direct deletion+ _ = RemoveTestWorkspaceDirect(workspace.ID)+ return}DeleteWorkspace(workspace, ownerToken, router)