Skip to content

PostgreSQL backup tool with Point-In-Time-Recovery and restore verification

FIX (storages): Restrict rclone storage management to admin users

Rostislav Dugin9d89cd978223
diff --git a/backend/internal/features/storages/controller.go b/backend/internal/features/storages/controller.go
index 5828ae0e..dde5541d 100644
--- a/backend/internal/features/storages/controller.go
+++ b/backend/internal/features/storages/controller.go
@@ -59,7 +59,8 @@ func (c *StorageController) SaveStorage(ctx *gin.Context) {
if err := c.storageService.SaveStorage(user, request.WorkspaceID, &request); err != nil {
if errors.Is(err, ErrInsufficientPermissionsToManageStorage) ||
- errors.Is(err, ErrLocalStorageNotAllowedInCloudMode) {
+ errors.Is(err, ErrLocalStorageNotAllowedInCloudMode) ||
+ errors.Is(err, ErrRcloneStorageRequiresAdmin) {
ctx.JSON(http.StatusForbidden, gin.H{"error": err.Error()})
return
}
@@ -327,7 +328,8 @@ func (c *StorageController) TestStorageConnectionDirect(ctx *gin.Context) {
}
if err := c.storageService.TestStorageConnectionDirect(user, &request); err != nil {
- if errors.Is(err, ErrLocalStorageNotAllowedInCloudMode) {
+ if errors.Is(err, ErrLocalStorageNotAllowedInCloudMode) ||
+ errors.Is(err, ErrRcloneStorageRequiresAdmin) {
ctx.JSON(http.StatusForbidden, gin.H{"error": err.Error()})
return
}
diff --git a/backend/internal/features/storages/controller_test.go b/backend/internal/features/storages/controller_test.go
index 67ff53f4..6681ce6e 100644
--- a/backend/internal/features/storages/controller_test.go
+++ b/backend/internal/features/storages/controller_test.go
@@ -167,6 +167,160 @@ func Test_CreateSystemStorage_OnlyAdminCanCreate_MemberGetsForbidden(t *testing.
workspaces_testing.RemoveTestWorkspace(workspace, router)
}
+func Test_CreateRcloneStorage_OnlyAdminCanCreate_MemberGetsForbidden(t *testing.T) {
+ admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)
+ member := users_testing.CreateTestUser(users_enums.UserRoleMember)
+ router := createRouter()
+ adminWorkspace := workspaces_testing.CreateTestWorkspace("Admin Workspace", admin, router)
+ memberWorkspace := workspaces_testing.CreateTestWorkspace("Member Workspace", member, router)
+
+ adminStorage := createNewRcloneStorage(adminWorkspace.ID)
+ var savedStorage Storage
+ test_utils.MakePostRequestAndUnmarshal(
+ t,
+ router,
+ "/api/v1/storages",
+ "Bearer "+admin.Token,
+ *adminStorage,
+ http.StatusOK,
+ &savedStorage,
+ )
+
+ assert.NotEmpty(t, savedStorage.ID)
+ assert.Equal(t, StorageTypeRclone, savedStorage.Type)
+
+ memberStorage := createNewRcloneStorage(memberWorkspace.ID)
+ resp := test_utils.MakePostRequest(
+ t,
+ router,
+ "/api/v1/storages",
+ "Bearer "+member.Token,
+ *memberStorage,
+ http.StatusForbidden,
+ )
+ assert.Contains(t, string(resp.Body), "rclone storage can only be managed by administrators")
+
+ deleteStorage(t, router, savedStorage.ID, admin.Token)
+ workspaces_testing.RemoveTestWorkspace(adminWorkspace, router)
+ workspaces_testing.RemoveTestWorkspace(memberWorkspace, router)
+}
+
+func Test_UpdateStorageTypeToRclone_OnlyAdminCanUpdate_MemberGetsForbidden(t *testing.T) {
+ admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)
+ member := users_testing.CreateTestUser(users_enums.UserRoleMember)
+ router := createRouter()
+ adminWorkspace := workspaces_testing.CreateTestWorkspace("Admin Workspace", admin, router)
+ memberWorkspace := workspaces_testing.CreateTestWorkspace("Member Workspace", member, router)
+
+ adminS3Storage := &Storage{
+ WorkspaceID: adminWorkspace.ID,
+ Type: StorageTypeS3,
+ Name: "Admin S3 Storage " + uuid.New().String(),
+ S3Storage: &s3_storage.S3Storage{
+ S3Bucket: "test-bucket",
+ S3Region: "us-east-1",
+ S3AccessKey: "access-key",
+ S3SecretKey: "secret-key",
+ },
+ }
+ var adminSaved Storage
+ test_utils.MakePostRequestAndUnmarshal(
+ t,
+ router,
+ "/api/v1/storages",
+ "Bearer "+admin.Token,
+ *adminS3Storage,
+ http.StatusOK,
+ &adminSaved,
+ )
+
+ adminSwitchToRclone := &Storage{
+ ID: adminSaved.ID,
+ WorkspaceID: adminWorkspace.ID,
+ Type: StorageTypeRclone,
+ Name: adminSaved.Name,
+ RcloneStorage: &rclone_storage.RcloneStorage{
+ ConfigContent: "[remote]\ntype = s3\nprovider = AWS\naccess_key_id = x\nsecret_access_key = y\n",
+ },
+ }
+ var adminUpdated Storage
+ test_utils.MakePostRequestAndUnmarshal(
+ t,
+ router,
+ "/api/v1/storages",
+ "Bearer "+admin.Token,
+ *adminSwitchToRclone,
+ http.StatusOK,
+ &adminUpdated,
+ )
+ assert.Equal(t, StorageTypeRclone, adminUpdated.Type)
+
+ memberS3Storage := &Storage{
+ WorkspaceID: memberWorkspace.ID,
+ Type: StorageTypeS3,
+ Name: "Member S3 Storage " + uuid.New().String(),
+ S3Storage: &s3_storage.S3Storage{
+ S3Bucket: "test-bucket",
+ S3Region: "us-east-1",
+ S3AccessKey: "access-key",
+ S3SecretKey: "secret-key",
+ },
+ }
+ var memberSaved Storage
+ test_utils.MakePostRequestAndUnmarshal(
+ t,
+ router,
+ "/api/v1/storages",
+ "Bearer "+member.Token,
+ *memberS3Storage,
+ http.StatusOK,
+ &memberSaved,
+ )
+
+ memberSwitchToRclone := &Storage{
+ ID: memberSaved.ID,
+ WorkspaceID: memberWorkspace.ID,
+ Type: StorageTypeRclone,
+ Name: memberSaved.Name,
+ RcloneStorage: &rclone_storage.RcloneStorage{
+ ConfigContent: "[remote]\ntype = s3\nprovider = AWS\naccess_key_id = x\nsecret_access_key = y\n",
+ },
+ }
+ resp := test_utils.MakePostRequest(
+ t,
+ router,
+ "/api/v1/storages",
+ "Bearer "+member.Token,
+ *memberSwitchToRclone,
+ http.StatusForbidden,
+ )
+ assert.Contains(t, string(resp.Body), "rclone storage can only be managed by administrators")
+
+ deleteStorage(t, router, adminSaved.ID, admin.Token)
+ deleteStorage(t, router, memberSaved.ID, member.Token)
+ workspaces_testing.RemoveTestWorkspace(adminWorkspace, router)
+ workspaces_testing.RemoveTestWorkspace(memberWorkspace, router)
+}
+
+func Test_TestStorageConnectionDirect_RcloneAsMember_ReturnsForbidden(t *testing.T) {
+ member := users_testing.CreateTestUser(users_enums.UserRoleMember)
+ router := createRouter()
+ workspace := workspaces_testing.CreateTestWorkspace("Member Workspace", member, router)
+
+ payload := createNewRcloneStorage(workspace.ID)
+ resp := test_utils.MakePostRequest(
+ t,
+ router,
+ "/api/v1/storages/direct-test",
+ "Bearer "+member.Token,
+ *payload,
+ http.StatusForbidden,
+ )
+ assert.Contains(t, string(resp.Body), "rclone storage can only be managed by administrators")
+
+ workspaces_testing.RemoveTestWorkspace(workspace, router)
+}
+
func Test_UpdateStorageIsSystem_OnlyAdminCanUpdate_MemberGetsForbidden(t *testing.T) {
admin := users_testing.CreateTestUser(users_enums.UserRoleAdmin)
member := users_testing.CreateTestUser(users_enums.UserRoleMember)
@@ -1502,7 +1656,11 @@ func Test_StorageSensitiveDataLifecycle_AllTypes(t *testing.T) {
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
- owner := users_testing.CreateTestUser(users_enums.UserRoleMember)
+ ownerRole := users_enums.UserRoleMember
+ if tc.storageType == StorageTypeRclone {
+ ownerRole = users_enums.UserRoleAdmin
+ }
+ owner := users_testing.CreateTestUser(ownerRole)
router := createRouter()
workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)
@@ -2061,6 +2219,17 @@ func createNewStorage(workspaceID uuid.UUID) *Storage {
}
}
+func createNewRcloneStorage(workspaceID uuid.UUID) *Storage {
+ return &Storage{
+ WorkspaceID: workspaceID,
+ Type: StorageTypeRclone,
+ Name: "Test Rclone Storage " + uuid.New().String(),
+ RcloneStorage: &rclone_storage.RcloneStorage{
+ ConfigContent: "[remote]\ntype = s3\nprovider = AWS\naccess_key_id = x\nsecret_access_key = y\n",
+ },
+ }
+}
+
func verifyStorageData(t *testing.T, expected, actual *Storage) {
assert.Equal(t, expected.Name, actual.Name)
assert.Equal(t, expected.Type, actual.Type)
diff --git a/backend/internal/features/storages/errors.go b/backend/internal/features/storages/errors.go
index 6c510e6f..d96bc28c 100644
--- a/backend/internal/features/storages/errors.go
+++ b/backend/internal/features/storages/errors.go
@@ -42,4 +42,13 @@ var (
ErrLocalStorageNotAllowedInCloudMode = errors.New(
"local storage can only be managed by administrators in cloud mode",
)
+ // Rclone accepts a freeform config blob whose `type =` may select backends
+ // that read arbitrary local files (`local`, `alias`, `combine`, `union`,
+ // `crypt`, `chunker`, `cache`) or initiate outbound connections to arbitrary
+ // hosts (`http`, `webdav`, `sftp`, `ftp`) — LFI and SSRF surface that we
+ // cannot expose to untrusted callers. Restrict to admins, who are the
+ // instance operators and won't harm their own deployment.
+ ErrRcloneStorageRequiresAdmin = errors.New(
+ "rclone storage can only be managed by administrators",
+ )
)
diff --git a/backend/internal/features/storages/service.go b/backend/internal/features/storages/service.go
index 104eb9f6..5d8fb49a 100644
--- a/backend/internal/features/storages/service.go
+++ b/backend/internal/features/storages/service.go
@@ -69,6 +69,10 @@ func (s *StorageService) SaveStorage(
return ErrLocalStorageNotAllowedInCloudMode
}
+ if storage.Type == StorageTypeRclone && user.Role != users_enums.UserRoleAdmin {
+ return ErrRcloneStorageRequiresAdmin
+ }
+
isUpdate := storage.ID != uuid.Nil
if storage.IsSystem && user.Role != users_enums.UserRoleAdmin {
@@ -288,6 +292,10 @@ func (s *StorageService) TestStorageConnectionDirect(
return ErrLocalStorageNotAllowedInCloudMode
}
+ if storage.Type == StorageTypeRclone && user.Role != users_enums.UserRoleAdmin {
+ return ErrRcloneStorageRequiresAdmin
+ }
+
var usingStorage *Storage
if storage.ID != uuid.Nil {