PostgreSQL backup tool with Point-In-Time-Recovery and restore verification
TypeScript backupbackupsdatabasedatabase-backupdevopsdockergolangkubernetesmariadbmongodbmysqlpgpostgrespostgresqls3self-hostedsystem-administrationtoolsweb-ui
FIX (security): Resolve semgrep findings so the code scanning workflow passes
Rostislav Duginaed10ec003a2
diff --git a/.agent-hooks/review_gate.py b/.agent-hooks/review_gate.pyindex c209aca4..c27cd2e0 100755--- a/.agent-hooks/review_gate.py+++ b/.agent-hooks/review_gate.py@@ -543,6 +543,8 @@ def build_review_prompt(session, gate, subject, candidate, paths):)baseline_paths = "\n".join(f"- {path}" for path in request.get("baseline_paths") or []) or "- none"changed_paths = "\n".join(f"- {path}" for path in paths) or "- none"+ # This builds a reviewer prompt, not an HTTP response.+ # nosemgrep: python.flask.security.audit.directly-returned-format-string.directly-returned-format-stringreturn f"""{instructions}Under review: {subject}@@ -946,6 +948,8 @@ def run_checks(root, checks, check_timeout_seconds=CHECK_TIMEOUT_SECONDS, total_timeout_seconds, exceeded_limit = remaining_seconds, f"the total limit of {total_timeout_seconds} seconds for all checks"try:+ # The hooks run on Python 3.6 or newer.+ # nosemgrep: python.lang.compatibility.python36.python36-compatibility-Popen1process = subprocess.Popen(list(check.arguments),cwd=root / check.directory,@@ -1034,6 +1038,8 @@ def build_full_review_prompt(session, full_review, change_dir, role, details):])candidate = str(get_field(session.payload, "last_assistant_message", "lastAssistantMessage") or "(not available)")+ # This builds a reviewer prompt, not an HTTP response.+ # nosemgrep: python.flask.security.audit.directly-returned-format-string.directly-returned-format-stringreturn f"""{instructions}OpenSpec change: {change_dir.relative_to(session.root)}diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.ymlindex b598d5db..d03dd812 100644--- a/.github/workflows/codeql.yml+++ b/.github/workflows/codeql.yml@@ -104,5 +104,9 @@ jobs:- name: Check out codeuses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1+ # Private keys are left to gitleaks, which keeps the allowlist of test keys in .gitleaksignore.- name: Run semgrep- run: semgrep scan --error --metrics=off --config p/default --config p/github-actions --config p/dockerfile+ run: >-+ semgrep scan --error --metrics=off+ --config p/default --config p/github-actions --config p/dockerfile+ --exclude-rule generic.secrets.security.detected-private-key.detected-private-keydiff --git a/Dockerfile b/Dockerfileindex 51d4cad5..5d90a98b 100644--- a/Dockerfile+++ b/Dockerfile@@ -198,5 +198,8 @@ HEALTHCHECK --interval=30s --timeout=5s --start-period=60s --retries=3 \# Volume for PostgreSQL dataVOLUME ["/databasus-data"]+# start.sh starts as root to prepare the data volume, then re-executes itself as the databasus user through gosu.+# nosemgrep: dockerfile.security.missing-user-entrypoint.missing-user-entrypointENTRYPOINT ["/app/start.sh"]+# nosemgrep: dockerfile.security.missing-user.missing-userCMD []diff --git a/agent/verification/cmd/reexec.go b/agent/verification/cmd/reexec.goindex 4cc49c34..5035aef4 100644--- a/agent/verification/cmd/reexec.go+++ b/agent/verification/cmd/reexec.go@@ -15,6 +15,8 @@ func reexecAfterUpgrade(log *slog.Logger) {log.Info("Re-executing after upgrade...")+ // Replaces the process with the agent's own upgraded executable.+ // nosemgrep: go.lang.security.audit.dangerous-syscall-exec.dangerous-syscall-execif err := syscall.Exec(selfPath, os.Args, os.Environ()); err != nil {log.Error("Failed to re-exec after upgrade", "error", err)os.Exit(1)diff --git a/agent/verification/e2e/mock-server/main.go b/agent/verification/e2e/mock-server/main.goindex bc73393c..e609e458 100644--- a/agent/verification/e2e/mock-server/main.go+++ b/agent/verification/e2e/mock-server/main.go@@ -59,6 +59,8 @@ func main() {addr := ":4050"log.Printf("mock server starting on %s", addr)+ // The mock server only serves the e2e tests over the local Docker network.+ // nosemgrep: go.lang.security.audit.net.use-tls.use-tlsif err := http.ListenAndServe(addr, mux); err != nil {log.Fatalf("server failed: %v", err)}diff --git a/agent/verification/internal/features/runner/runner.go b/agent/verification/internal/features/runner/runner.goindex b18f6d5a..9d6344df 100644--- a/agent/verification/internal/features/runner/runner.go+++ b/agent/verification/internal/features/runner/runner.go@@ -296,6 +296,8 @@ func (r *Runner) executeJob(ctx context.Context, job *api.JobAssignment) {}}+ // RunPgRestore returns Result by value and fills it when it fails with ErrRestoreFailed.+ // nosemgrep: trailofbits.go.invalid-usage-of-modified-variable.invalid-usage-of-modified-variablerestoreResult, err := r.restorer.RunPgRestore(jobCtx, jobContainer, restore.PgRestoreSpec{ArchivePath: archivePath,Conn: jobContainer.GetInContainerConn(),diff --git a/agent/verification/internal/features/start/daemon.go b/agent/verification/internal/features/start/daemon.goindex c34d4782..b69987ad 100644--- a/agent/verification/internal/features/start/daemon.go+++ b/agent/verification/internal/features/start/daemon.go@@ -92,6 +92,8 @@ func spawnDaemon(log *slog.Logger) (int, error) {return 0, fmt.Errorf("failed to get working directory: %w", err)}+ // Starts this agent's own executable in the background, not a user-supplied command.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(context.Background(), execPath, args...)cmd.Dir = cwdcmd.Stderr = logFilediff --git a/agent/verification/internal/features/upgrade/upgrader.go b/agent/verification/internal/features/upgrade/upgrader.goindex a4eccc07..ee7456ea 100644--- a/agent/verification/internal/features/upgrade/upgrader.go+++ b/agent/verification/internal/features/upgrade/upgrader.go@@ -98,6 +98,8 @@ func verifyBinary(binaryPath, expectedVersion string) error {ctx, cancel := context.WithTimeout(context.Background(), verifyBinaryTimeout)defer cancel()+ // Runs the downloaded agent binary to check it before it replaces the current one.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, binaryPath, "version")output, err := cmd.Output()diff --git a/backend/cmd/cleanup_test_db/main.go b/backend/cmd/cleanup_test_db/main.goindex 83fe78be..4fcdcc11 100644--- a/backend/cmd/cleanup_test_db/main.go+++ b/backend/cmd/cleanup_test_db/main.go@@ -82,10 +82,13 @@ func resetMetadataDb(log *slog.Logger, env *config.EnvVariables) error {slotDbName := fmt.Sprintf("%s_w%d", baseDbName, slot)quoted := quoteIdentifier(slotDbName)+ // Identifiers and literals are quoted with quoteIdentifier and quoteLiteral; this tool only resets test databases.+ // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-queryif err := db.Exec(fmt.Sprintf("DROP DATABASE IF EXISTS %s WITH (FORCE)", quoted)).Error; err != nil {return fmt.Errorf("drop database %s: %w", slotDbName, err)}+ // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-queryif err := db.Exec(fmt.Sprintf("CREATE DATABASE %s", quoted)).Error; err != nil {return fmt.Errorf("create database %s: %w", slotDbName, err)}@@ -147,6 +150,8 @@ func resetOnePostgresContainer(ctx context.Context, log *slog.Logger, host, labe}for _, name := range userDbs {+ // Identifiers and literals are quoted with quoteIdentifier and quoteLiteral; this tool only resets test databases.+ // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-queryif _, err := db.ExecContext(ctx, fmt.Sprintf("SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE datname = %s AND pid <> pg_backend_pid()",quoteLiteral(name),@@ -156,6 +161,8 @@ func resetOnePostgresContainer(ctx context.Context, log *slog.Logger, host, labe// No WITH (FORCE) - that's PG 13+ only and we support PG 12.// pg_terminate_backend above already kicked off other sessions.+ // Identifiers and literals are quoted with quoteIdentifier and quoteLiteral; this tool only resets test databases.+ // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-queryif _, err := db.ExecContext(ctx,fmt.Sprintf("DROP DATABASE IF EXISTS %s", quoteIdentifier(name)),@@ -164,6 +171,7 @@ func resetOnePostgresContainer(ctx context.Context, log *slog.Logger, host, labe}}+ // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-queryif _, err := db.ExecContext(ctx,fmt.Sprintf("CREATE DATABASE %s", quoteIdentifier(testPgContainerDb)),@@ -182,9 +190,13 @@ func resetOnePostgresContainer(ctx context.Context, log *slog.Logger, host, labe// REASSIGN/DROP OWNED release any objects still pinned to the role so// DROP ROLE can succeed. Failures here are best-effort - the role may// own nothing, in which case these are no-ops.+ // Identifiers and literals are quoted with quoteIdentifier and quoteLiteral; this tool only resets test databases.+ // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-query_, _ = db.ExecContext(ctx, fmt.Sprintf("REASSIGN OWNED BY %s TO %s", quotedRole, owner))+ // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-query_, _ = db.ExecContext(ctx, fmt.Sprintf("DROP OWNED BY %s", quotedRole))+ // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-queryif _, err := db.ExecContext(ctx, fmt.Sprintf("DROP ROLE IF EXISTS %s", quotedRole)); err != nil {log.WarnContext(ctx, "could not drop role", "role", role, "error", err)}diff --git a/backend/internal/features/backups/backups/usecases/logical/mariadb/compression_probe.go b/backend/internal/features/backups/backups/usecases/logical/mariadb/compression_probe.goindex 425aafb6..cbd34c50 100644--- a/backend/internal/features/backups/backups/usecases/logical/mariadb/compression_probe.go+++ b/backend/internal/features/backups/backups/usecases/logical/mariadb/compression_probe.go@@ -99,6 +99,8 @@ func (uc *CreateMariadbBackupUsecase) isNetworkCompressionAccepted(var probeStderr bytes.Buffer+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(probeCtx, probe.MariadbDumpBin, args...)cmd.Stdout = io.Discardcmd.Stderr = &probeStderrdiff --git a/backend/internal/features/backups/backups/usecases/logical/mariadb/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/logical/mariadb/create_backup_uc.goindex 789c4800..582def6e 100644--- a/backend/internal/features/backups/backups/usecases/logical/mariadb/create_backup_uc.go+++ b/backend/internal/features/backups/backups/usecases/logical/mariadb/create_backup_uc.go@@ -206,6 +206,8 @@ func (uc *CreateMariadbBackupUsecase) streamToStorage(fullArgs := append([]string{"--defaults-file=" + myCnfFile}, compressionArgs...)fullArgs = append(fullArgs, args...)+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, mariadbBin, fullArgs...)uc.logger.InfoContext(parentCtx, "executing MariaDB backup command", "command", cmd.String())diff --git a/backend/internal/features/backups/backups/usecases/logical/mongodb/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/logical/mongodb/create_backup_uc.goindex bff98a70..ef851d7e 100644--- a/backend/internal/features/backups/backups/usecases/logical/mongodb/create_backup_uc.go+++ b/backend/internal/features/backups/backups/usecases/logical/mongodb/create_backup_uc.go@@ -140,6 +140,8 @@ func (uc *CreateMongodbBackupUsecase) streamToStorage(ctx, cancel := backups_core_logical.NewBackupContext(parentCtx)defer cancel(nil)+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, mongodumpBin, args...)safeArgs := make([]string, len(args))diff --git a/backend/internal/features/backups/backups/usecases/logical/mysql/compression_probe.go b/backend/internal/features/backups/backups/usecases/logical/mysql/compression_probe.goindex 975e94f9..435d7e1e 100644--- a/backend/internal/features/backups/backups/usecases/logical/mysql/compression_probe.go+++ b/backend/internal/features/backups/backups/usecases/logical/mysql/compression_probe.go@@ -114,6 +114,8 @@ func (uc *CreateMysqlBackupUsecase) isNetworkCompressionAccepted(var probeStderr bytes.Buffer+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(probeCtx, probe.MysqldumpBin, args...)cmd.Stdout = io.Discardcmd.Stderr = &probeStderrdiff --git a/backend/internal/features/backups/backups/usecases/logical/mysql/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/logical/mysql/create_backup_uc.goindex 6d7b0471..42cc868d 100644--- a/backend/internal/features/backups/backups/usecases/logical/mysql/create_backup_uc.go+++ b/backend/internal/features/backups/backups/usecases/logical/mysql/create_backup_uc.go@@ -203,6 +203,8 @@ func (uc *CreateMysqlBackupUsecase) streamToStorage(fullArgs := append([]string{"--defaults-file=" + myCnfFile}, compressionArgs...)fullArgs = append(fullArgs, args...)+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, mysqlBin, fullArgs...)uc.logger.InfoContext(parentCtx, "executing MySQL backup command", "command", cmd.String())diff --git a/backend/internal/features/backups/backups/usecases/logical/postgresql/create_backup_uc.go b/backend/internal/features/backups/backups/usecases/logical/postgresql/create_backup_uc.goindex 5411e24d..f23b9f35 100644--- a/backend/internal/features/backups/backups/usecases/logical/postgresql/create_backup_uc.go+++ b/backend/internal/features/backups/backups/usecases/logical/postgresql/create_backup_uc.go@@ -144,6 +144,8 @@ func (uc *CreatePostgresqlBackupUsecase) streamToStorage(}defer credentials.Remove()+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, pgBin, args...)uc.logger.InfoContext(parentCtx, "executing PostgreSQL backup command", "command", cmd.String())diff --git a/backend/internal/features/backups/backups/usecases/physical/postgresql/manifest.go b/backend/internal/features/backups/backups/usecases/physical/postgresql/manifest.goindex e9d39f4a..a6d0e87a 100644--- a/backend/internal/features/backups/backups/usecases/physical/postgresql/manifest.go+++ b/backend/internal/features/backups/backups/usecases/physical/postgresql/manifest.go@@ -155,6 +155,8 @@ func walkTarForManifest(hasher.Reset()+ // Each entry is streamed into the hasher, never buffered, so its size does not affect memory.+ // nosemgrep: go.lang.security.decompression_bomb.potential-dos-via-decompression-bombif _, err := io.Copy(hasher, tarReader); err != nil {return nil, fmt.Errorf("hash tar entry %q: %w", header.Name, err)}diff --git a/backend/internal/features/backups/backups/usecases/physical/postgresql/pg_basebackup.go b/backend/internal/features/backups/backups/usecases/physical/postgresql/pg_basebackup.goindex 46630429..bf238eed 100644--- a/backend/internal/features/backups/backups/usecases/physical/postgresql/pg_basebackup.go+++ b/backend/internal/features/backups/backups/usecases/physical/postgresql/pg_basebackup.go@@ -88,6 +88,8 @@ func newPgBasebackupCommand("-U", sourceDB.Username,)+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, pgBin, args...)// -h above stays the real host so the certificate and .pgpass still match; PGHOSTADDR is whatdiff --git a/backend/internal/features/backups/backups/usecases/physical/postgresql/receivewal_process.go b/backend/internal/features/backups/backups/usecases/physical/postgresql/receivewal_process.goindex 77e92ab5..617f7190 100644--- a/backend/internal/features/backups/backups/usecases/physical/postgresql/receivewal_process.go+++ b/backend/internal/features/backups/backups/usecases/physical/postgresql/receivewal_process.go@@ -208,6 +208,8 @@ func newReceivewalCommand(ctx context.Context, spec receivewalCommandSpec) (*exe"-U", spec.SourceDB.Username,}+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, spec.PgBin, args...)// -h above stays the real host so the certificate and .pgpass still match; PGHOSTADDR is whatdiff --git a/backend/internal/features/backups/backups/usecases/physical/postgresql/testing.go b/backend/internal/features/backups/backups/usecases/physical/postgresql/testing.goindex 79d8067c..fc6d433e 100644--- a/backend/internal/features/backups/backups/usecases/physical/postgresql/testing.go+++ b/backend/internal/features/backups/backups/usecases/physical/postgresql/testing.go@@ -438,6 +438,8 @@ func GenerateWalActivity() (int64, error) {tableName := "wal_activity_" + strings.ReplaceAll(uuid.New().String(), "-", "")[:16]+ // Test helper: the table name is generated from a UUID and the setting values come from the server itself.+ // nosemgrep: go.lang.security.audit.sqli.pgx-sqli.pgx-sqliif _, err := conn.Exec(ctx,fmt.Sprintf(`CREATE TABLE %s (id BIGSERIAL PRIMARY KEY, payload TEXT)`, tableName),@@ -446,6 +448,7 @@ func GenerateWalActivity(}defer func() {+ // nosemgrep: go.lang.security.audit.sqli.pgx-sqli.pgx-sqli_, _ = conn.Exec(context.Background(), fmt.Sprintf(`DROP TABLE IF EXISTS %s`, tableName))}()@@ -459,6 +462,8 @@ func GenerateWalActivity(const payloadSize = 1024for {+ // Test helper: the table name is generated from a UUID and the setting values come from the server itself.+ // nosemgrep: go.lang.security.audit.sqli.pgx-sqli.pgx-sqli_, err := conn.Exec(ctx,fmt.Sprintf(@@ -635,6 +640,8 @@ func SetSummarizerEnabled(t *testing.T, conn *pgx.Conn, enabled bool) {return}+ // Test helper: the table name is generated from a UUID and the setting values come from the server itself.+ // nosemgrep: go.lang.security.audit.sqli.pgx-sqli.pgx-sqliif _, err := conn.Exec(ctx,fmt.Sprintf("ALTER SYSTEM SET summarize_wal = '%s'", desired),@@ -650,6 +657,8 @@ func SetSummarizerEnabled(t *testing.T, conn *pgx.Conn, enabled bool) {restoreCtx, restoreCancel := context.WithTimeout(context.Background(), 10*time.Second)defer restoreCancel()+ // Test helper: the table name is generated from a UUID and the setting values come from the server itself.+ // nosemgrep: go.lang.security.audit.sqli.pgx-sqli.pgx-sqliif _, err := conn.Exec(restoreCtx,fmt.Sprintf("ALTER SYSTEM SET summarize_wal = '%s'", previous),); err != nil {@@ -694,6 +703,8 @@ func ExpireWalSummaries(t *testing.T, conn *pgx.Conn) {restoreCtx, restoreCancel := context.WithTimeout(context.Background(), 5*time.Second)defer restoreCancel()+ // Test helper: the table name is generated from a UUID and the setting values come from the server itself.+ // nosemgrep: go.lang.security.audit.sqli.pgx-sqli.pgx-sqliif _, err := conn.Exec(restoreCtx,fmt.Sprintf("ALTER SYSTEM SET wal_summary_keep_time = '%s'", previous),); err != nil {diff --git a/backend/internal/features/databases/databases/mariadb/model.go b/backend/internal/features/databases/databases/mariadb/model.goindex 89f9c11f..f6b4bd73 100644--- a/backend/internal/features/databases/databases/mariadb/model.go+++ b/backend/internal/features/databases/databases/mariadb/model.go@@ -502,7 +502,10 @@ func (m *MariadbDatabase) buildDSN(password, database string) string {tlsConfig := "false"if m.IsHttps {+ // The HTTPS option encrypts the connection without verifying the server certificate.+ // nosemgrep: problem-based-packs.insecure-transport.go-stdlib.bypass-tls-verification.bypass-tls-verificationerr := mysql.RegisterTLSConfig("mariadb-skip-verify", &tls.Config{+ MinVersion: tls.VersionTLS12,InsecureSkipVerify: true,})if err != nil {diff --git a/backend/internal/features/databases/databases/mysql/model.go b/backend/internal/features/databases/databases/mysql/model.goindex 9bd9fa2c..893c3614 100644--- a/backend/internal/features/databases/databases/mysql/model.go+++ b/backend/internal/features/databases/databases/mysql/model.go@@ -517,7 +517,10 @@ func (m *MysqlDatabase) buildDSN(password, database string) string {allowCleartext := ""if m.IsHttps {+ // The HTTPS option encrypts the connection without verifying the server certificate.+ // nosemgrep: problem-based-packs.insecure-transport.go-stdlib.bypass-tls-verification.bypass-tls-verificationerr := mysql.RegisterTLSConfig("mysql-skip-verify", &tls.Config{+ MinVersion: tls.VersionTLS12,InsecureSkipVerify: true,})if err != nil {diff --git a/backend/internal/features/databases/databases/postgresql/physical/model.go b/backend/internal/features/databases/databases/postgresql/physical/model.goindex 27c41911..cd0c278c 100644--- a/backend/internal/features/databases/databases/postgresql/physical/model.go+++ b/backend/internal/features/databases/databases/postgresql/physical/model.go@@ -292,6 +292,8 @@ func (p *PostgresqlPhysicalDatabase) SystemIdentifierUint64() uint64 {return value}+ // pg_control_system() returns system_identifier as a signed bigint; the cast restores its unsigned value bit for bit.+ // nosemgrep: trailofbits.go.string-to-int-signedness-cast.string-to-int-signedness-castif value, err := strconv.ParseInt(*p.SystemIdentifier, 10, 64); err == nil {return uint64(value)}diff --git a/backend/internal/features/notifiers/models/mattermost/model.go b/backend/internal/features/notifiers/models/mattermost/model.goindex a6e30b28..f273c83d 100644--- a/backend/internal/features/notifiers/models/mattermost/model.go+++ b/backend/internal/features/notifiers/models/mattermost/model.go@@ -298,6 +298,8 @@ func (m *MattermostNotifier) newHTTPClient() *http.Client {if m.IsInsecureSkipVerify {client.Transport = &http.Transport{Proxy: http.ProxyFromEnvironment,+ // Verification is skipped only when the user turns on IsInsecureSkipVerify for this notifier.+ // nosemgrep: problem-based-packs.insecure-transport.go-stdlib.bypass-tls-verification.bypass-tls-verificationTLSClientConfig: &tls.Config{MinVersion: tls.VersionTLS12,InsecureSkipVerify: true,diff --git a/backend/internal/features/notifiers/models/testing.go b/backend/internal/features/notifiers/models/testing.goindex 22cc2b38..42263e4d 100644--- a/backend/internal/features/notifiers/models/testing.go+++ b/backend/internal/features/notifiers/models/testing.go@@ -71,6 +71,8 @@ func StartRecordingServer(t *testing.T, response StubResponse) (string, *Requestw.WriteHeader(response.StatusCode)if response.Body != "" {+ // Test server that replays a canned response body.+ // nosemgrep: go.lang.security.audit.xss.no-direct-write-to-responsewriter.no-direct-write-to-responsewriter_, _ = w.Write([]byte(response.Body))}}))diff --git a/backend/internal/features/restores/usecases/mariadb/restore_backup_uc.go b/backend/internal/features/restores/usecases/mariadb/restore_backup_uc.goindex f6c3c96c..24e952e7 100644--- a/backend/internal/features/restores/usecases/mariadb/restore_backup_uc.go+++ b/backend/internal/features/restores/usecases/mariadb/restore_backup_uc.go@@ -191,6 +191,8 @@ func (uc *RestoreMariadbBackupUsecase) executeMariadbRestore() error {fullArgs := append([]string{"--defaults-file=" + myCnfFile}, args...)+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, mariadbBin, fullArgs...)uc.logger.InfoContext(ctx, "executing MariaDB restore command", "command", cmd.String())diff --git a/backend/internal/features/restores/usecases/mongodb/restore_backup_uc.go b/backend/internal/features/restores/usecases/mongodb/restore_backup_uc.goindex 101a0bd2..85dc0ff5 100644--- a/backend/internal/features/restores/usecases/mongodb/restore_backup_uc.go+++ b/backend/internal/features/restores/usecases/mongodb/restore_backup_uc.go@@ -174,6 +174,8 @@ func (uc *RestoreMongodbBackupUsecase) executeMongoRestore(backupReader io.ReadCloser,backup *backups_core_logical.LogicalBackup,) error {+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, mongorestoreBin, args...)safeArgs := make([]string, len(args))diff --git a/backend/internal/features/restores/usecases/mysql/restore_backup_uc.go b/backend/internal/features/restores/usecases/mysql/restore_backup_uc.goindex 90e96298..6fc6c778 100644--- a/backend/internal/features/restores/usecases/mysql/restore_backup_uc.go+++ b/backend/internal/features/restores/usecases/mysql/restore_backup_uc.go@@ -172,6 +172,8 @@ func (uc *RestoreMysqlBackupUsecase) executeMysqlRestore() error {fullArgs := append([]string{"--defaults-file=" + myCnfFile}, args...)+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, mysqlBin, fullArgs...)uc.logger.InfoContext(ctx, "executing MySQL restore command", "command", cmd.String())diff --git a/backend/internal/features/restores/usecases/postgresql/restore_backup_uc.go b/backend/internal/features/restores/usecases/postgresql/restore_backup_uc.goindex fc3cfd6d..ff81eb37 100644--- a/backend/internal/features/restores/usecases/postgresql/restore_backup_uc.go+++ b/backend/internal/features/restores/usecases/postgresql/restore_backup_uc.go@@ -292,6 +292,8 @@ func (uc *RestorePostgresqlBackupUsecase) executePgRestoreViaStdin() error {pgBin := command.pgBin+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, pgBin, command.args...)command.logger.InfoContext(ctx, "executing PostgreSQL restore command via stdin", "command", cmd.String())@@ -685,6 +687,8 @@ func (uc *RestorePostgresqlBackupUsecase) executePgRestore() error {pgBin := command.pgBin+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandcmd := exec.CommandContext(ctx, pgBin, command.args...)command.logger.InfoContext(ctx, "executing pg_restore command", "command", cmd.String())@@ -977,6 +981,8 @@ func (uc *RestorePostgresqlBackupUsecase) generateFilteredTocList(uc.logger.InfoContext(ctx, "generating filtered TOC list", "backup_file", backupFile)// Run pg_restore -l to get the TOC list+ // The binary is a database client from the bundled tools directory, and the arguments go to it as a list, not through a shell.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandlistCmd := exec.CommandContext(ctx, pgBin, "-l", backupFile)uc.setupPgRestoreEnvironment(listCmd, credentials, pgConfig)diff --git a/backend/internal/features/sshtunnel/forwarder.go b/backend/internal/features/sshtunnel/forwarder.goindex dd819b0d..717f4584 100644--- a/backend/internal/features/sshtunnel/forwarder.go+++ b/backend/internal/features/sshtunnel/forwarder.go@@ -107,6 +107,7 @@ func Open(ctx context.Context, spec OpenSpec) (*Forwarder, error) {// Accepted risk: the bastion's host key is not pinned, so the credentials are// presented to whatever answers its address. Config carries no fingerprint to// verify against; this matches the existing SFTP storage backend.+ // nosemgrep: go.lang.security.audit.crypto.insecure_ssh.avoid-ssh-insecure-ignore-host-keyHostKeyCallback: ssh.InsecureIgnoreHostKey(),},bastionAddress: bastionAddress,diff --git a/backend/internal/features/storages/files/worker.go b/backend/internal/features/storages/files/worker.goindex b04942a6..94a437bf 100644--- a/backend/internal/features/storages/files/worker.go+++ b/backend/internal/features/storages/files/worker.go@@ -5,6 +5,8 @@ import ("fmt""log/slog""math"+ // math/rand only adds retry jitter here, not anything secret.+ // nosemgrep: go.lang.security.audit.crypto.math_random.math-random-used"math/rand/v2""sync/atomic""time"diff --git a/backend/internal/features/storages/models/ftp/model.go b/backend/internal/features/storages/models/ftp/model.goindex c92b3ad5..c14cf991 100644--- a/backend/internal/features/storages/models/ftp/model.go+++ b/backend/internal/features/storages/models/ftp/model.go@@ -251,6 +251,7 @@ func (f *FTPStorage) connectWithContext(if f.UseSSL {connections.tlsConfig = &tls.Config{+ MinVersion: tls.VersionTLS12,ServerName: f.Host,InsecureSkipVerify: f.SkipTLSVerify,}diff --git a/backend/internal/features/storages/models/nas/model.go b/backend/internal/features/storages/models/nas/model.goindex f69bfc5c..a7d1c5a0 100644--- a/backend/internal/features/storages/models/nas/model.go+++ b/backend/internal/features/storages/models/nas/model.go@@ -269,6 +269,7 @@ func (n *NASStorage) createConnectionWithContext(ctx context.Context) (net.Conn,if n.UseSSL {tlsConfig := &tls.Config{+ MinVersion: tls.VersionTLS12,ServerName: n.Host,InsecureSkipVerify: false,}diff --git a/backend/internal/features/storages/models/s3/model.go b/backend/internal/features/storages/models/s3/model.goindex dac60273..7965661d 100644--- a/backend/internal/features/storages/models/s3/model.go+++ b/backend/internal/features/storages/models/s3/model.go@@ -723,6 +723,8 @@ func (s *S3Storage) putInnerPart(objectHasher hash.Hash,parts *[]minio.CompletePart,) error {+ // S3 requires a Content-MD5 checksum for each part; it checks integrity, not authenticity.+ // nosemgrep: go.lang.security.audit.crypto.use_of_weak_crypto.use-of-md5partMd5 := md5.Sum(partData)md5Base64 := base64.StdEncoding.EncodeToString(partMd5[:])diff --git a/backend/internal/features/storages/models/s3/transport.go b/backend/internal/features/storages/models/s3/transport.goindex 2f08a531..e03a989c 100644--- a/backend/internal/features/storages/models/s3/transport.go+++ b/backend/internal/features/storages/models/s3/transport.go@@ -35,6 +35,7 @@ func newSharedTransport(isSkipTLSVerify bool) *http.Transport {IdleConnTimeout: s3IdleConnTimeout,MaxIdleConnsPerHost: s3MaxIdleConnsPerHost,TLSClientConfig: &tls.Config{+ MinVersion: tls.VersionTLS12,InsecureSkipVerify: isSkipTLSVerify,},}diff --git a/backend/internal/features/storages/models/sftp/model.go b/backend/internal/features/storages/models/sftp/model.goindex 93356c7a..5e587ff3 100644--- a/backend/internal/features/storages/models/sftp/model.go+++ b/backend/internal/features/storages/models/sftp/model.go@@ -282,6 +282,8 @@ func (s *SFTPStorage) connectWithContext(authMethods = append(authMethods, ssh.PublicKeys(signer))}+ // Accepted risk: the storage config carries no host key fingerprint to verify against.+ // nosemgrep: go.lang.security.audit.crypto.insecure_ssh.avoid-ssh-insecure-ignore-host-keyhostKeyCallback := ssh.InsecureIgnoreHostKey()config := &ssh.ClientConfig{diff --git a/backend/internal/features/telemetry/background_service.go b/backend/internal/features/telemetry/background_service.goindex 67ea6f3c..638fd8e9 100644--- a/backend/internal/features/telemetry/background_service.go+++ b/backend/internal/features/telemetry/background_service.go@@ -4,6 +4,8 @@ import ("context""fmt""log/slog"+ // math/rand only adds schedule jitter here, not anything secret.+ // nosemgrep: go.lang.security.audit.crypto.math_random.math-random-used"math/rand/v2""sync/atomic""time"diff --git a/backend/internal/util/smtp_transport/smtp_transport.go b/backend/internal/util/smtp_transport/smtp_transport.goindex 57b6163d..d3ed7153 100644--- a/backend/internal/util/smtp_transport/smtp_transport.go+++ b/backend/internal/util/smtp_transport/smtp_transport.go@@ -175,6 +175,7 @@ func deliver(client *smtp.Client, envelopeSender, envelopeRecipient string, contfunc buildTLSConfig(connection Connection) *tls.Config {return &tls.Config{+ MinVersion: tls.VersionTLS12,ServerName: connection.Host,InsecureSkipVerify: connection.IsInsecureSkipVerify,}diff --git a/backend/internal/util/testing/containers/testdata/ssh_bastion/Dockerfile b/backend/internal/util/testing/containers/testdata/ssh_bastion/Dockerfileindex a22ec4b9..1229651c 100644--- a/backend/internal/util/testing/containers/testdata/ssh_bastion/Dockerfile+++ b/backend/internal/util/testing/containers/testdata/ssh_bastion/Dockerfile@@ -14,4 +14,5 @@ RUN chown -R testuser:testuser /home/testuser/.ssh \EXPOSE 22+# nosemgrep: dockerfile.security.missing-user.missing-userCMD ["/usr/sbin/sshd", "-D", "-e"]diff --git a/backend/internal/util/tools/common.go b/backend/internal/util/tools/common.goindex 39a80cd8..ecbf08d3 100644--- a/backend/internal/util/tools/common.go+++ b/backend/internal/util/tools/common.go@@ -115,6 +115,8 @@ func runClients(cmdPath := filepath.Join(binDir, cmd)ctx, cancel := context.WithTimeout(context.Background(), clientVersionTimeout)+ // The binary is a database client from the bundled tools directory, run with a fixed --version argument.+ // nosemgrep: go.lang.security.audit.dangerous-exec-command.dangerous-exec-commandoutput, err := exec.CommandContext(ctx, cmdPath, "--version").CombinedOutput()cancel()