Skip to content

PostgreSQL backup tool with Point-In-Time-Recovery and restore verification

FEATURE (restores): Do not allow to make 2 parallel restores for single DB

Rostislav Duginbd329a68cf1b
diff --git a/backend/internal/features/restores/controller_test.go b/backend/internal/features/restores/controller_test.go
index 3e8a3ff5..c437364d 100644
--- a/backend/internal/features/restores/controller_test.go
+++ b/backend/internal/features/restores/controller_test.go
@@ -511,6 +511,49 @@ func Test_CancelRestore_InProgressRestore_SuccessfullyCancelled(t *testing.T) {
time.Sleep(200 * time.Millisecond)
}
+func Test_RestoreBackup_WithParallelRestoreInProgress_ReturnsError(t *testing.T) {
+ router := createTestRouter()
+
+ _, cleanup := SetupMockRestoreNode(t)
+ defer cleanup()
+
+ owner := users_testing.CreateTestUser(users_enums.UserRoleMember)
+ workspace := workspaces_testing.CreateTestWorkspace("Test Workspace", owner, router)
+
+ _, backup := createTestDatabaseWithBackupForRestore(workspace, owner, router)
+
+ request := restores_core.RestoreBackupRequest{
+ PostgresqlDatabase: &postgresql.PostgresqlDatabase{
+ Version: tools.PostgresqlVersion16,
+ Host: "localhost",
+ Port: 5432,
+ Username: "postgres",
+ Password: "postgres",
+ },
+ }
+
+ testResp := test_utils.MakePostRequest(
+ t,
+ router,
+ fmt.Sprintf("/api/v1/restores/%s/restore", backup.ID.String()),
+ "Bearer "+owner.Token,
+ request,
+ http.StatusOK,
+ )
+ assert.Contains(t, string(testResp.Body), "restore started successfully")
+
+ testResp2 := test_utils.MakePostRequest(
+ t,
+ router,
+ fmt.Sprintf("/api/v1/restores/%s/restore", backup.ID.String()),
+ "Bearer "+owner.Token,
+ request,
+ http.StatusBadRequest,
+ )
+
+ assert.Contains(t, string(testResp2.Body), "another restore is already in progress")
+}
+
func createTestRouter() *gin.Engine {
return CreateTestRouter()
}
diff --git a/backend/internal/features/restores/core/repository.go b/backend/internal/features/restores/core/repository.go
index b9f5eba3..7e23bc53 100644
--- a/backend/internal/features/restores/core/repository.go
+++ b/backend/internal/features/restores/core/repository.go
@@ -68,6 +68,24 @@ func (r *RestoreRepository) FindByStatus(status RestoreStatus) ([]*Restore, erro
return restores, nil
}
+func (r *RestoreRepository) FindInProgressRestoresByDatabaseID(
+ databaseID uuid.UUID,
+) ([]*Restore, error) {
+ var restores []*Restore
+
+ if err := storage.
+ GetDb().
+ Preload("Backup").
+ Joins("JOIN backups ON backups.id = restores.backup_id").
+ Where("backups.database_id = ? AND restores.status = ?", databaseID, RestoreStatusInProgress).
+ Order("restores.created_at DESC").
+ Find(&restores).Error; err != nil {
+ return nil, err
+ }
+
+ return restores, nil
+}
+
func (r *RestoreRepository) DeleteByID(id uuid.UUID) error {
return storage.GetDb().Delete(&Restore{}, "id = ?", id).Error
}
diff --git a/backend/internal/features/restores/service.go b/backend/internal/features/restores/service.go
index 812a6f2d..220e8c26 100644
--- a/backend/internal/features/restores/service.go
+++ b/backend/internal/features/restores/service.go
@@ -136,6 +136,11 @@ func (s *RestoreService) RestoreBackupWithAuth(
return err
}
+ // Validate no parallel restores for the same database
+ if err := s.validateNoParallelRestores(backup.DatabaseID); err != nil {
+ return err
+ }
+
// Create restore record with the request configuration
restore := restores_core.Restore{
ID: uuid.New(),
@@ -343,6 +348,22 @@ func (s *RestoreService) validateDiskSpace(
return nil
}
+func (s *RestoreService) validateNoParallelRestores(databaseID uuid.UUID) error {
+ inProgressRestores, err := s.restoreRepository.FindInProgressRestoresByDatabaseID(databaseID)
+ if err != nil {
+ return fmt.Errorf("failed to check for in-progress restores: %w", err)
+ }
+
+ isInProgress := len(inProgressRestores) > 0
+ if isInProgress {
+ return errors.New(
+ "another restore is already in progress for this database. Please wait for it to complete or cancel it before starting a new restore",
+ )
+ }
+
+ return nil
+}
+
func (s *RestoreService) CancelRestore(
user *users_models.User,
restoreID uuid.UUID,