Skip to content

PostgreSQL backup tool with Point-In-Time-Recovery and restore verification

FIX (agent): Emit explicit tls=false in MongoDB URI when IsHttps is false to fix mongodb+srv connections where driver defaults to TLS

Rostislav Duginde7cda66acb6
diff --git a/backend/internal/features/databases/databases/mongodb/model.go b/backend/internal/features/databases/databases/mongodb/model.go
index 60a44ecd..8f317f7b 100644
--- a/backend/internal/features/databases/databases/mongodb/model.go
+++ b/backend/internal/features/databases/databases/mongodb/model.go
@@ -461,6 +461,8 @@ func (m *MongodbDatabase) BuildMongodumpURI(password string) string {
extraParams := ""
if m.IsHttps {
extraParams += "&tls=true&tlsInsecure=true"
+ } else {
+ extraParams += "&tls=false"
}
if m.IsDirectConnection {
extraParams += "&directConnection=true"
@@ -503,6 +505,8 @@ func (m *MongodbDatabase) buildConnectionURI(password string) string {
extraParams := ""
if m.IsHttps {
extraParams += "&tls=true&tlsInsecure=true"
+ } else {
+ extraParams += "&tls=false"
}
if m.IsDirectConnection {
extraParams += "&directConnection=true"
diff --git a/backend/internal/features/databases/databases/mongodb/model_test.go b/backend/internal/features/databases/databases/mongodb/model_test.go
index 64bb8097..37826283 100644
--- a/backend/internal/features/databases/databases/mongodb/model_test.go
+++ b/backend/internal/features/databases/databases/mongodb/model_test.go
@@ -732,3 +732,83 @@ func Test_Validate_StandardConnection_RequiresPort(t *testing.T) {
assert.Error(t, err)
assert.Contains(t, err.Error(), "port is required for standard connections")
}
+
+func Test_BuildConnectionURI_WhenIsHttpsFalse_ContainsTlsFalse(t *testing.T) {
+ port := 27017
+ model := &MongodbDatabase{
+ Host: "localhost",
+ Port: &port,
+ Username: "testuser",
+ Password: "testpass123",
+ Database: "mydb",
+ AuthDatabase: "admin",
+ IsHttps: false,
+ IsSrv: false,
+ }
+
+ uri := model.buildConnectionURI("testpass123")
+
+ assert.Contains(t, uri, "tls=false")
+ assert.NotContains(t, uri, "tls=true")
+ assert.NotContains(t, uri, "tlsInsecure")
+}
+
+func Test_BuildConnectionURI_WhenSrvAndIsHttpsFalse_ContainsTlsFalse(t *testing.T) {
+ model := &MongodbDatabase{
+ Host: "cluster0.example.mongodb.net",
+ Port: nil,
+ Username: "testuser",
+ Password: "testpass123",
+ Database: "mydb",
+ AuthDatabase: "admin",
+ IsHttps: false,
+ IsSrv: true,
+ }
+
+ uri := model.buildConnectionURI("testpass123")
+
+ assert.Contains(t, uri, "mongodb+srv://")
+ assert.Contains(t, uri, "tls=false")
+ assert.NotContains(t, uri, "tls=true")
+ assert.NotContains(t, uri, "tlsInsecure")
+}
+
+func Test_BuildMongodumpURI_WhenIsHttpsFalse_ContainsTlsFalse(t *testing.T) {
+ port := 27017
+ model := &MongodbDatabase{
+ Host: "localhost",
+ Port: &port,
+ Username: "testuser",
+ Password: "testpass123",
+ Database: "mydb",
+ AuthDatabase: "admin",
+ IsHttps: false,
+ IsSrv: false,
+ }
+
+ uri := model.BuildMongodumpURI("testpass123")
+
+ assert.Contains(t, uri, "tls=false")
+ assert.NotContains(t, uri, "tls=true")
+ assert.NotContains(t, uri, "tlsInsecure")
+}
+
+func Test_BuildMongodumpURI_WhenSrvAndIsHttpsFalse_ContainsTlsFalse(t *testing.T) {
+ model := &MongodbDatabase{
+ Host: "cluster0.example.mongodb.net",
+ Port: nil,
+ Username: "testuser",
+ Password: "testpass123",
+ Database: "mydb",
+ AuthDatabase: "admin",
+ IsHttps: false,
+ IsSrv: true,
+ }
+
+ uri := model.BuildMongodumpURI("testpass123")
+
+ assert.Contains(t, uri, "mongodb+srv://")
+ assert.Contains(t, uri, "tls=false")
+ assert.NotContains(t, uri, "tls=true")
+ assert.NotContains(t, uri, "tlsInsecure")
+}