Apache DataFusion SQL Query Engine
fix: Fix a few minor issues with join metrics (#19283)
Heran Lin033116e8a2c2
diff --git a/datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rs b/datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rsindex c821473c67..508be2e398 100644--- a/datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rs+++ b/datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rs@@ -50,6 +50,7 @@ use crate::joins::piecewise_merge_join::utils::{build_visited_indices_map, is_existence_join, is_right_existence_join,};use crate::joins::utils::asymmetric_join_output_partitioning;+use crate::metrics::MetricsSet;use crate::{DisplayAs, DisplayFormatType, ExecutionPlanProperties};use crate::{ExecutionPlan, PlanProperties,@@ -572,6 +573,10 @@ impl ExecutionPlan for PiecewiseMergeJoinExec {)))}}++ fn metrics(&self) -> Option<MetricsSet> {+ Some(self.metrics.clone_inner())+ }}impl DisplayAs for PiecewiseMergeJoinExec {diff --git a/datafusion/physical-plan/src/joins/stream_join_utils.rs b/datafusion/physical-plan/src/joins/stream_join_utils.rsindex 10f212bb4a..22cc82a22d 100644--- a/datafusion/physical-plan/src/joins/stream_join_utils.rs+++ b/datafusion/physical-plan/src/joins/stream_join_utils.rs@@ -695,16 +695,18 @@ pub struct StreamJoinMetrics {impl StreamJoinMetrics {pub fn new(partition: usize, metrics: &ExecutionPlanMetricsSet) -> Self {let input_batches =- MetricBuilder::new(metrics).counter("input_batches", partition);- let input_rows = MetricBuilder::new(metrics).counter("input_rows", partition);+ MetricBuilder::new(metrics).counter("left_input_batches", partition);+ let input_rows =+ MetricBuilder::new(metrics).counter("left_input_rows", partition);let left = StreamJoinSideMetrics {input_batches,input_rows,};let input_batches =- MetricBuilder::new(metrics).counter("input_batches", partition);- let input_rows = MetricBuilder::new(metrics).counter("input_rows", partition);+ MetricBuilder::new(metrics).counter("right_input_batches", partition);+ let input_rows =+ MetricBuilder::new(metrics).counter("right_input_rows", partition);let right = StreamJoinSideMetrics {input_batches,input_rows,