Skip to content

Apache DataFusion SQL Query Engine

test: keep fuzz decimal values within the declared precision (#26774)

Jay Zhan0442090c3d92
diff --git a/test-utils/src/array_gen/decimal.rs b/test-utils/src/array_gen/decimal.rs
index 54fa2269d6..217d55b608 100644
--- a/test-utils/src/array_gen/decimal.rs
+++ b/test-utils/src/array_gen/decimal.rs
@@ -15,7 +15,9 @@
// specific language governing permissions and limitations
// under the License.
-use arrow::array::{ArrayRef, PrimitiveArray, PrimitiveBuilder, UInt32Array};
+use arrow::array::{
+ ArrayRef, ArrowNativeTypeOp, PrimitiveArray, PrimitiveBuilder, UInt32Array,
+};
use arrow::datatypes::DecimalType;
use rand::Rng;
use rand::rngs::StdRng;
@@ -44,13 +46,19 @@ impl DecimalArrayGenerator {
where
D: DecimalType + RandomNativeData,
{
+ // Valid decimals have at most `precision` digits, so draw values in
+ // (-10^precision, 10^precision)
+ let modulus = D::MAX_FOR_EACH_PRECISION[self.precision as usize]
+ .add_wrapping(D::Native::ONE);
+
// table of decimals from which to draw
let distinct_decimals: PrimitiveArray<D> = {
let mut decimal_builder =
PrimitiveBuilder::<D>::with_capacity(self.num_distinct_decimals);
for _ in 0..self.num_distinct_decimals {
- decimal_builder
- .append_option(Some(D::generate_random_native_data(&mut self.rng)));
+ let value =
+ D::generate_random_native_data(&mut self.rng).mod_wrapping(modulus);
+ decimal_builder.append_option(Some(value));
}
decimal_builder