Skip to content

Apache DataFusion SQL Query Engine

chore: enforce clippy::allow_attributes for functions-* crates (#18986)

Carlos Hurtado1f03ac502f48
diff --git a/datafusion/functions-aggregate-common/src/lib.rs b/datafusion/functions-aggregate-common/src/lib.rs
index 468836f3ab..83e2efd0c5 100644
--- a/datafusion/functions-aggregate-common/src/lib.rs
+++ b/datafusion/functions-aggregate-common/src/lib.rs
@@ -33,6 +33,8 @@
// https://github.com/apache/datafusion/issues/18503
#![deny(clippy::needless_pass_by_value)]
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
pub mod accumulator;
pub mod aggregate;
diff --git a/datafusion/functions-aggregate/src/approx_percentile_cont.rs b/datafusion/functions-aggregate/src/approx_percentile_cont.rs
index 42ef835d97..b09d43bd8f 100644
--- a/datafusion/functions-aggregate/src/approx_percentile_cont.rs
+++ b/datafusion/functions-aggregate/src/approx_percentile_cont.rs
@@ -239,7 +239,6 @@ impl AggregateUDFImpl for ApproxPercentileCont {
self
}
- #[allow(rustdoc::private_intra_doc_links)]
/// See [`TDigest::to_scalar_state()`] for a description of the serialized
/// state.
fn state_fields(&self, args: StateFieldsArgs) -> Result<Vec<FieldRef>> {
diff --git a/datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs b/datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs
index adf07dede3..6a86ef2262 100644
--- a/datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs
+++ b/datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs
@@ -251,7 +251,6 @@ impl AggregateUDFImpl for ApproxPercentileContWithWeight {
Ok(Box::new(accumulator))
}
- #[allow(rustdoc::private_intra_doc_links)]
/// See [`TDigest::to_scalar_state()`] for a description of the serialized
/// state.
fn state_fields(&self, args: StateFieldsArgs) -> Result<Vec<FieldRef>> {
diff --git a/datafusion/functions-aggregate/src/lib.rs b/datafusion/functions-aggregate/src/lib.rs
index 5454a902e4..de1e2f46d1 100644
--- a/datafusion/functions-aggregate/src/lib.rs
+++ b/datafusion/functions-aggregate/src/lib.rs
@@ -26,6 +26,8 @@
// Make sure fast / cheap clones on Arc are explicit:
// https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
//! Aggregate Function packages for [DataFusion].
//!
diff --git a/datafusion/functions-aggregate/src/regr.rs b/datafusion/functions-aggregate/src/regr.rs
index 44ce0bd48e..f78d463585 100644
--- a/datafusion/functions-aggregate/src/regr.rs
+++ b/datafusion/functions-aggregate/src/regr.rs
@@ -86,7 +86,6 @@ impl Regr {
}
#[derive(Debug, Clone, PartialEq, Hash, Eq)]
-#[allow(clippy::upper_case_acronyms)]
pub enum RegrType {
/// Variant for `regr_slope` aggregate expression
/// Returns the slope of the linear regression line for non-null pairs in aggregate columns.
diff --git a/datafusion/functions-nested/src/lib.rs b/datafusion/functions-nested/src/lib.rs
index 51210b9ae2..1777198860 100644
--- a/datafusion/functions-nested/src/lib.rs
+++ b/datafusion/functions-nested/src/lib.rs
@@ -26,6 +26,8 @@
// https://github.com/apache/datafusion/issues/18503
#![deny(clippy::needless_pass_by_value)]
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
//! Nested type Functions for [DataFusion].
//!
diff --git a/datafusion/functions-table/src/lib.rs b/datafusion/functions-table/src/lib.rs
index f099a186ec..6d8a7a988c 100644
--- a/datafusion/functions-table/src/lib.rs
+++ b/datafusion/functions-table/src/lib.rs
@@ -26,6 +26,8 @@
// Make sure fast / cheap clones on Arc are explicit:
// https://github.com/apache/datafusion/issues/11143
#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
pub mod generate_series;
diff --git a/datafusion/functions-window-common/src/lib.rs b/datafusion/functions-window-common/src/lib.rs
index c35b9a6c84..56d23d2073 100644
--- a/datafusion/functions-window-common/src/lib.rs
+++ b/datafusion/functions-window-common/src/lib.rs
@@ -26,6 +26,8 @@
// Make sure fast / cheap clones on Arc are explicit:
// https://github.com/apache/datafusion/issues/11143
#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
//! Common user-defined window functionality for [DataFusion]
//!
diff --git a/datafusion/functions-window/src/cume_dist.rs b/datafusion/functions-window/src/cume_dist.rs
index 372086b12d..536526e784 100644
--- a/datafusion/functions-window/src/cume_dist.rs
+++ b/datafusion/functions-window/src/cume_dist.rs
@@ -167,7 +167,7 @@ mod tests {
}
#[test]
- #[allow(clippy::single_range_in_vec_init)]
+ #[expect(clippy::single_range_in_vec_init)]
fn test_cume_dist() -> Result<()> {
test_f64_result(0, vec![], vec![])?;
diff --git a/datafusion/functions-window/src/lead_lag.rs b/datafusion/functions-window/src/lead_lag.rs
index 75a6f1fe43..b3d8a55065 100644
--- a/datafusion/functions-window/src/lead_lag.rs
+++ b/datafusion/functions-window/src/lead_lag.rs
@@ -640,7 +640,7 @@ impl PartitionEvaluator for WindowShiftEvaluator {
// OR
// - ignore nulls mode and current value is null and is within window bounds
// .unwrap() is safe here as there is a none check in front
- #[allow(clippy::unnecessary_unwrap)]
+ #[expect(clippy::unnecessary_unwrap)]
if !(idx.is_none() || (self.ignore_nulls && array.is_null(idx.unwrap()))) {
ScalarValue::try_from_array(array, idx.unwrap())
} else {
diff --git a/datafusion/functions-window/src/lib.rs b/datafusion/functions-window/src/lib.rs
index 1050c1b737..c9ed195ec4 100644
--- a/datafusion/functions-window/src/lib.rs
+++ b/datafusion/functions-window/src/lib.rs
@@ -26,6 +26,8 @@
// Make sure fast / cheap clones on Arc are explicit:
// https://github.com/apache/datafusion/issues/11143
#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
//! Window Function packages for [DataFusion].
//!
diff --git a/datafusion/functions-window/src/rank.rs b/datafusion/functions-window/src/rank.rs
index 6d891e7667..0dc8923849 100644
--- a/datafusion/functions-window/src/rank.rs
+++ b/datafusion/functions-window/src/rank.rs
@@ -381,7 +381,7 @@ mod tests {
test_i32_result(expr, vec![0..2, 2..3, 3..6, 6..7, 7..8], expected)
}
- #[allow(clippy::single_range_in_vec_init)]
+ #[expect(clippy::single_range_in_vec_init)]
fn test_without_rank(expr: &Rank, expected: Vec<u64>) -> Result<()> {
test_i32_result(expr, vec![0..8], expected)
}
@@ -434,7 +434,7 @@ mod tests {
}
#[test]
- #[allow(clippy::single_range_in_vec_init)]
+ #[expect(clippy::single_range_in_vec_init)]
fn test_percent_rank() -> Result<()> {
let r = Rank::percent_rank();
diff --git a/datafusion/functions/src/datetime/now.rs b/datafusion/functions/src/datetime/now.rs
index 4723548a45..65f0b8e19b 100644
--- a/datafusion/functions/src/datetime/now.rs
+++ b/datafusion/functions/src/datetime/now.rs
@@ -148,7 +148,7 @@ impl ScalarUDFImpl for NowFunc {
mod tests {
use super::*;
- #[allow(deprecated)]
+ #[expect(deprecated)]
#[test]
fn now_func_default_matches_config() {
let default_config = ConfigOptions::default();
diff --git a/datafusion/functions/src/lib.rs b/datafusion/functions/src/lib.rs
index 252914026b..cfda16db53 100644
--- a/datafusion/functions/src/lib.rs
+++ b/datafusion/functions/src/lib.rs
@@ -26,6 +26,8 @@
// https://github.com/apache/datafusion/issues/18503
#![deny(clippy::needless_pass_by_value)]
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
//! Function packages for [DataFusion].
//!
diff --git a/datafusion/functions/src/macros.rs b/datafusion/functions/src/macros.rs
index 471b0a053e..f0f3f9efa3 100644
--- a/datafusion/functions/src/macros.rs
+++ b/datafusion/functions/src/macros.rs
@@ -84,7 +84,6 @@ macro_rules! export_functions {
#[macro_export]
macro_rules! make_udf_function {
($UDF:ty, $NAME:ident, $CTOR:expr) => {
- #[allow(rustdoc::redundant_explicit_links)]
#[doc = concat!("Return a [`ScalarUDF`](datafusion_expr::ScalarUDF) implementation of ", stringify!($NAME))]
pub fn $NAME() -> std::sync::Arc<datafusion_expr::ScalarUDF> {
// Singleton instance of the function
@@ -109,7 +108,6 @@ macro_rules! make_udf_function {
#[macro_export]
macro_rules! make_udf_function_with_config {
($UDF:ty, $NAME:ident) => {
- #[allow(rustdoc::redundant_explicit_links)]
#[doc = concat!("Return a [`ScalarUDF`](datafusion_expr::ScalarUDF) implementation of ", stringify!($NAME))]
pub fn $NAME(config: &datafusion_common::config::ConfigOptions) -> std::sync::Arc<datafusion_expr::ScalarUDF> {
std::sync::Arc::new(datafusion_expr::ScalarUDF::new_from_impl(
diff --git a/datafusion/functions/src/regex/regexpinstr.rs b/datafusion/functions/src/regex/regexpinstr.rs
index 0115648665..cb32007924 100644
--- a/datafusion/functions/src/regex/regexpinstr.rs
+++ b/datafusion/functions/src/regex/regexpinstr.rs
@@ -286,7 +286,6 @@ fn regexp_instr(
}
}
-#[allow(clippy::too_many_arguments)]
fn regexp_instr_inner<'a, S>(
values: &S,
regex_array: &S,
diff --git a/datafusion/functions/src/utils.rs b/datafusion/functions/src/utils.rs
index 5a2368a38e..74b7fa95cd 100644
--- a/datafusion/functions/src/utils.rs
+++ b/datafusion/functions/src/utils.rs
@@ -334,7 +334,6 @@ pub mod test {
}
use arrow::datatypes::DataType;
- #[allow(unused_imports)]
pub(crate) use test_function;
use super::*;