Apache DataFusion SQL Query Engine
chore: enforce clippy::allow_attributes for physical crates (#19185)
Carlos Hurtado41f7137585d0
diff --git a/datafusion/physical-expr-adapter/src/lib.rs b/datafusion/physical-expr-adapter/src/lib.rsindex ce9b15e3b1..9586372803 100644--- a/datafusion/physical-expr-adapter/src/lib.rs+++ b/datafusion/physical-expr-adapter/src/lib.rs@@ -21,6 +21,8 @@html_favicon_url = "https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg")]#![cfg_attr(docsrs, feature(doc_cfg))]+// https://github.com/apache/datafusion/issues/18881+#![deny(clippy::allow_attributes)]//! Physical expression schema adaptation utilities for DataFusiondiff --git a/datafusion/physical-expr-common/src/lib.rs b/datafusion/physical-expr-common/src/lib.rsindex 76eaed40a7..7665e45613 100644--- a/datafusion/physical-expr-common/src/lib.rs+++ b/datafusion/physical-expr-common/src/lib.rs@@ -24,6 +24,8 @@// https://github.com/apache/datafusion/issues/11143#![deny(clippy::clone_on_ref_ptr)]#![cfg_attr(test, allow(clippy::needless_pass_by_value))]+// https://github.com/apache/datafusion/issues/18881+#![deny(clippy::allow_attributes)]//! Physical Expr Common packages for [DataFusion]//! This package contains high level PhysicalExpr traitdiff --git a/datafusion/physical-optimizer/src/aggregate_statistics.rs b/datafusion/physical-optimizer/src/aggregate_statistics.rsindex eee333926b..19cc0b5070 100644--- a/datafusion/physical-optimizer/src/aggregate_statistics.rs+++ b/datafusion/physical-optimizer/src/aggregate_statistics.rs@@ -33,7 +33,7 @@ use crate::{OptimizerContext, PhysicalOptimizerRule};pub struct AggregateStatistics {}impl AggregateStatistics {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self {}}@@ -41,6 +41,7 @@ impl AggregateStatistics {impl PhysicalOptimizerRule for AggregateStatistics {#[cfg_attr(feature = "recursive_protection", recursive::recursive)]+ #[expect(clippy::allow_attributes)] // See https://github.com/apache/datafusion/issues/18881#issuecomment-3621545670#[allow(clippy::only_used_in_recursion)] // See https://github.com/rust-lang/rust-clippy/issues/14566fn optimize_plan(&self,diff --git a/datafusion/physical-optimizer/src/coalesce_batches.rs b/datafusion/physical-optimizer/src/coalesce_batches.rsindex 1ad8146edf..e3f2df93fb 100644--- a/datafusion/physical-optimizer/src/coalesce_batches.rs+++ b/datafusion/physical-optimizer/src/coalesce_batches.rs@@ -38,7 +38,7 @@ use datafusion_common::tree_node::{Transformed, TransformedResult, TreeNode};pub struct CoalesceBatches {}impl CoalesceBatches {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self::default()}diff --git a/datafusion/physical-optimizer/src/combine_partial_final_agg.rs b/datafusion/physical-optimizer/src/combine_partial_final_agg.rsindex f189a7f3f0..5aea611f4c 100644--- a/datafusion/physical-optimizer/src/combine_partial_final_agg.rs+++ b/datafusion/physical-optimizer/src/combine_partial_final_agg.rs@@ -39,7 +39,7 @@ use datafusion_physical_expr::{physical_exprs_equal, PhysicalExpr};pub struct CombinePartialFinalAggregate {}impl CombinePartialFinalAggregate {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self {}}diff --git a/datafusion/physical-optimizer/src/enforce_distribution.rs b/datafusion/physical-optimizer/src/enforce_distribution.rsindex 78e5c4edb2..571c07ff80 100644--- a/datafusion/physical-optimizer/src/enforce_distribution.rs+++ b/datafusion/physical-optimizer/src/enforce_distribution.rs@@ -184,7 +184,7 @@ use itertools::izip;pub struct EnforceDistribution {}impl EnforceDistribution {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self {}}diff --git a/datafusion/physical-optimizer/src/enforce_sorting/mod.rs b/datafusion/physical-optimizer/src/enforce_sorting/mod.rsindex 69593697e2..69090f8ef6 100644--- a/datafusion/physical-optimizer/src/enforce_sorting/mod.rs+++ b/datafusion/physical-optimizer/src/enforce_sorting/mod.rs@@ -79,7 +79,7 @@ use itertools::izip;pub struct EnforceSorting {}impl EnforceSorting {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self {}}diff --git a/datafusion/physical-optimizer/src/filter_pushdown.rs b/datafusion/physical-optimizer/src/filter_pushdown.rsindex 671c16c897..eacffa9198 100644--- a/datafusion/physical-optimizer/src/filter_pushdown.rs+++ b/datafusion/physical-optimizer/src/filter_pushdown.rs@@ -429,7 +429,6 @@ impl PhysicalOptimizerRule for FilterPushdown {)}- #[allow(deprecated)]fn optimize(&self,plan: Arc<dyn ExecutionPlan>,diff --git a/datafusion/physical-optimizer/src/join_selection.rs b/datafusion/physical-optimizer/src/join_selection.rsindex b6ff8344a3..8f337bc8d9 100644--- a/datafusion/physical-optimizer/src/join_selection.rs+++ b/datafusion/physical-optimizer/src/join_selection.rs@@ -47,7 +47,7 @@ use std::sync::Arc;pub struct JoinSelection {}impl JoinSelection {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self {}}diff --git a/datafusion/physical-optimizer/src/lib.rs b/datafusion/physical-optimizer/src/lib.rsindex 07f61d3d04..d1bf375bd0 100644--- a/datafusion/physical-optimizer/src/lib.rs+++ b/datafusion/physical-optimizer/src/lib.rs@@ -24,6 +24,8 @@// https://github.com/apache/datafusion/issues/11143#![deny(clippy::clone_on_ref_ptr)]#![cfg_attr(test, allow(clippy::needless_pass_by_value))]+// https://github.com/apache/datafusion/issues/18881+#![deny(clippy::allow_attributes)]pub mod aggregate_statistics;pub mod coalesce_batches;diff --git a/datafusion/physical-optimizer/src/limit_pushdown.rs b/datafusion/physical-optimizer/src/limit_pushdown.rsindex d70e8da9dd..74f1af2ff5 100644--- a/datafusion/physical-optimizer/src/limit_pushdown.rs+++ b/datafusion/physical-optimizer/src/limit_pushdown.rs@@ -52,7 +52,7 @@ pub struct GlobalRequirements {}impl LimitPushdown {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self {}}diff --git a/datafusion/physical-optimizer/src/optimizer.rs b/datafusion/physical-optimizer/src/optimizer.rsindex 0f3467bfbb..4524947135 100644--- a/datafusion/physical-optimizer/src/optimizer.rs+++ b/datafusion/physical-optimizer/src/optimizer.rs@@ -95,7 +95,7 @@ pub trait PhysicalOptimizerRule: Debug {context: &OptimizerContext,) -> Result<Arc<dyn ExecutionPlan>> {// Default implementation: delegate to the old method for backwards compatibility- #[allow(deprecated)]+ #[expect(deprecated)]self.optimize(plan, context.session_config().options())}diff --git a/datafusion/physical-optimizer/src/projection_pushdown.rs b/datafusion/physical-optimizer/src/projection_pushdown.rsindex fa562825c6..89a595f61b 100644--- a/datafusion/physical-optimizer/src/projection_pushdown.rs+++ b/datafusion/physical-optimizer/src/projection_pushdown.rs@@ -49,7 +49,7 @@ use datafusion_physical_plan::ExecutionPlan;pub struct ProjectionPushdown {}impl ProjectionPushdown {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self {}}diff --git a/datafusion/physical-optimizer/src/sanity_checker.rs b/datafusion/physical-optimizer/src/sanity_checker.rsindex fc9187ba54..7e81ba5f15 100644--- a/datafusion/physical-optimizer/src/sanity_checker.rs+++ b/datafusion/physical-optimizer/src/sanity_checker.rs@@ -47,7 +47,7 @@ use itertools::izip;pub struct SanityCheckPlan {}impl SanityCheckPlan {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self {}}diff --git a/datafusion/physical-optimizer/src/update_aggr_exprs.rs b/datafusion/physical-optimizer/src/update_aggr_exprs.rsindex 39852a2293..604bc6c3e1 100644--- a/datafusion/physical-optimizer/src/update_aggr_exprs.rs+++ b/datafusion/physical-optimizer/src/update_aggr_exprs.rs@@ -48,7 +48,7 @@ use crate::{OptimizerContext, PhysicalOptimizerRule};pub struct OptimizeAggregateOrder {}impl OptimizeAggregateOrder {- #[allow(missing_docs)]+ #[expect(missing_docs)]pub fn new() -> Self {Self::default()}