Skip to content

Apache DataFusion SQL Query Engine

fix: don't allow zero-argument first_value/last_value/nth_value window functions (#24595)

Justus Flerlage482d1fd1fe26
diff --git a/datafusion/functions-window/src/nth_value.rs b/datafusion/functions-window/src/nth_value.rs
index 0651872d74..b3678e80f2 100644
--- a/datafusion/functions-window/src/nth_value.rs
+++ b/datafusion/functions-window/src/nth_value.rs
@@ -98,11 +98,7 @@ impl NthValue {
pub fn new(kind: NthValueKind) -> Self {
Self {
signature: Signature::one_of(
- vec![
- TypeSignature::Nullary,
- TypeSignature::Any(1),
- TypeSignature::Any(2),
- ],
+ vec![TypeSignature::Any(1), TypeSignature::Any(2)],
Volatility::Immutable,
),
kind,
@@ -272,6 +268,10 @@ impl WindowUDFImpl for NthValue {
&self,
partition_evaluator_args: PartitionEvaluatorArgs,
) -> Result<Box<dyn PartitionEvaluator>> {
+ if partition_evaluator_args.input_exprs().is_empty() {
+ return exec_err!("{} requires at least one argument", self.kind.name());
+ }
+
let state = NthValueState {
finalized_result: None,
kind: self.kind,
@@ -691,4 +691,22 @@ mod tests {
"Execution error: The second argument of nth_value must not be i64::MIN"
));
}
+
+ #[test]
+ fn zero_arguments_returns_error() {
+ let err = NthValue::first()
+ .partition_evaluator(PartitionEvaluatorArgs::new(
+ &[],
+ &[Field::new("f", DataType::Int32, true).into()],
+ false,
+ false,
+ ))
+ .unwrap_err();
+
+ assert!(
+ err.to_string().starts_with(
+ "Execution error: first_value requires at least one argument"
+ )
+ );
+ }
}
diff --git a/datafusion/sqllogictest/test_files/window.slt b/datafusion/sqllogictest/test_files/window.slt
index fe8bbdc345..6238361af0 100644
--- a/datafusion/sqllogictest/test_files/window.slt
+++ b/datafusion/sqllogictest/test_files/window.slt
@@ -7014,3 +7014,12 @@ ORDER BY x
false 3
true 2
true 2
+
+statement error DataFusion error: Error during planning: 'first_value' does not support zero arguments
+SELECT first_value() OVER () FROM (VALUES (1), (2), (3)) t(x)
+
+statement error DataFusion error: Error during planning: 'last_value' does not support zero arguments
+SELECT last_value() OVER () FROM (VALUES (1), (2), (3)) t(x)
+
+statement error DataFusion error: Error during planning: 'nth_value' does not support zero arguments
+SELECT nth_value() OVER () FROM (VALUES (1), (2), (3)) t(x)