Apache DataFusion SQL Query Engine
Minor: Disallow async function in lambdas (#22097)
gstvg4fac70d9b274
diff --git a/datafusion/physical-expr/src/expressions/lambda.rs b/datafusion/physical-expr/src/expressions/lambda.rsindex 5e6dca1a62..9275821ae9 100644--- a/datafusion/physical-expr/src/expressions/lambda.rs+++ b/datafusion/physical-expr/src/expressions/lambda.rs@@ -21,6 +21,7 @@ use std::hash::Hash;use std::sync::Arc;use crate::{+ ScalarFunctionExpr,expressions::{Column, LambdaVariable},physical_expr::PhysicalExpr,};@@ -61,11 +62,16 @@ impl Hash for LambdaExpr {impl LambdaExpr {/// Create a new lambda expression with the given parameters and bodypub fn try_new(params: Vec<String>, body: Arc<dyn PhysicalExpr>) -> Result<Self> {- if all_unique(¶ms) {- Ok(Self::new(params, body))- } else {- plan_err!("lambda params must be unique, got ({})", params.join(", "))+ if !all_unique(¶ms) {+ return plan_err!(+ "lambda params must be unique, got ({})",+ params.join(", ")+ );}++ check_async_udf(&body)?;++ Ok(Self::new(params, body))}fn new(params: Vec<String>, body: Arc<dyn PhysicalExpr>) -> Self {@@ -179,6 +185,8 @@ impl PhysicalExpr for LambdaExpr {);};+ check_async_udf(body)?;+Ok(Arc::new(Self::new(self.params.clone(), Arc::clone(body))))}@@ -210,6 +218,20 @@ fn all_unique(params: &[String]) -> bool {}}+fn check_async_udf(body: &Arc<dyn PhysicalExpr>) -> Result<()> {+ if body.exists(|expr| {+ Ok(expr+ .downcast_ref::<ScalarFunctionExpr>()+ .is_some_and(|udf| udf.fun().as_async().is_some()))+ })? {+ return plan_err!(+ "Async functions in lambdas aren't supported, see https://github.com/apache/datafusion/issues/22091"+ );+ }++ Ok(())+}+#[cfg(test)]mod tests {use crate::expressions::{NoOp, lambda::lambda};diff --git a/datafusion/sqllogictest/test_files/async_udf.slt b/datafusion/sqllogictest/test_files/async_udf.sltindex 0708b59e51..678b2f7d8b 100644--- a/datafusion/sqllogictest/test_files/async_udf.slt+++ b/datafusion/sqllogictest/test_files/async_udf.slt@@ -99,3 +99,13 @@ physical_plan01)ProjectionExec: expr=[__async_fn_0@1 as async_abs(data.x)]02)--AsyncFuncExec: async_expr=[async_expr(name=__async_fn_0, expr=async_abs(x@0))]03)----DataSourceExec: partitions=1, partition_sizes=[1]++statement ok+set datafusion.sql_parser.dialect = databricks;++# Async udf can't be used in lambdas+query error DataFusion error: Error during planning: Async functions in lambdas aren't supported, see https://github\.com/apache/datafusion/issues/22091+select array_transform([1], v -> async_abs(v));++statement ok+set datafusion.sql_parser.dialect = generic;