Skip to content

Apache DataFusion SQL Query Engine

chore: use extend instead of manual loop in multi group by (#19429)

Raz Luvaton65a6bc423142
diff --git a/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs b/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs
index 4c9e376fc4..479bff001e 100644
--- a/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs
+++ b/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs
@@ -540,14 +540,13 @@ impl<const STREAMING: bool> GroupValuesColumn<STREAMING> {
// into `vectorized_equal_to_row_indices` and `vectorized_equal_to_group_indices`.
let list_offset = group_index_view.value() as usize;
let group_index_list = &self.group_index_lists[list_offset];
- for &group_index in group_index_list {
- self.vectorized_operation_buffers
- .equal_to_row_indices
- .push(row);
- self.vectorized_operation_buffers
- .equal_to_group_indices
- .push(group_index);
- }
+
+ self.vectorized_operation_buffers
+ .equal_to_group_indices
+ .extend_from_slice(group_index_list);
+ self.vectorized_operation_buffers
+ .equal_to_row_indices
+ .extend(std::iter::repeat_n(row, group_index_list.len()));
} else {
let group_index = group_index_view.value() as usize;
self.vectorized_operation_buffers