Skip to content

Apache DataFusion SQL Query Engine

fix: inverted null_percent logic in in_list benchmark (#19204)

Geoffrey Claude662a3bad6420
diff --git a/datafusion/physical-expr/benches/in_list.rs b/datafusion/physical-expr/benches/in_list.rs
index d3e4fc1684..f1d93644bf 100644
--- a/datafusion/physical-expr/benches/in_list.rs
+++ b/datafusion/physical-expr/benches/in_list.rs
@@ -49,10 +49,12 @@ fn do_benches(
null_percent: f64,
) {
let mut rng = StdRng::seed_from_u64(120320);
+ let non_null_percent = 1.0 - null_percent;
+
for string_length in [5, 10, 20] {
let values: StringArray = (0..array_length)
.map(|_| {
- rng.random_bool(null_percent)
+ rng.random_bool(non_null_percent)
.then(|| random_string(&mut rng, string_length))
})
.collect();
@@ -72,7 +74,7 @@ fn do_benches(
}
let values: Float32Array = (0..array_length)
- .map(|_| rng.random_bool(null_percent).then(|| rng.random()))
+ .map(|_| rng.random_bool(non_null_percent).then(|| rng.random()))
.collect();
let in_list: Vec<_> = (0..in_list_length)
@@ -87,7 +89,7 @@ fn do_benches(
);
let values: Int32Array = (0..array_length)
- .map(|_| rng.random_bool(null_percent).then(|| rng.random()))
+ .map(|_| rng.random_bool(non_null_percent).then(|| rng.random()))
.collect();
let in_list: Vec<_> = (0..in_list_length)