Skip to content

Apache DataFusion SQL Query Engine

fix: unparse Int8 casts as SIGNED for MySQL dialect (#26883)

hozan2368ac6cc37be0
diff --git a/datafusion/sql/src/unparser/dialect.rs b/datafusion/sql/src/unparser/dialect.rs
index e7b3339a12..9f12965ff9 100644
--- a/datafusion/sql/src/unparser/dialect.rs
+++ b/datafusion/sql/src/unparser/dialect.rs
@@ -585,6 +585,10 @@ impl Dialect for MySqlDialect {
ast::DataType::Custom(ObjectName::from(vec![Ident::new("SIGNED")]), vec![])
}
+ fn int8_cast_dtype(&self) -> ast::DataType {
+ ast::DataType::Custom(ObjectName::from(vec![Ident::new("SIGNED")]), vec![])
+ }
+
fn timestamp_cast_dtype(
&self,
time_unit: &TimeUnit,
diff --git a/datafusion/sql/src/unparser/expr.rs b/datafusion/sql/src/unparser/expr.rs
index 093ba80d29..053b1beb63 100644
--- a/datafusion/sql/src/unparser/expr.rs
+++ b/datafusion/sql/src/unparser/expr.rs
@@ -3144,6 +3144,15 @@ mod tests {
Ok(())
}
+ #[test]
+ fn mysql_int8_cast_uses_signed() -> Result<()> {
+ let unparser = Unparser::new(&MySqlDialect {});
+ let expr = Expr::Cast(Cast::new(Box::new(col("a")), Int8));
+ let ast = unparser.expr_to_sql(&expr)?;
+ assert_eq!(format!("{ast}"), "CAST(`a` AS SIGNED)");
+ Ok(())
+ }
+
#[test]
fn custom_dialect_date32_ast_dtype() -> Result<()> {
let default_dialect = CustomDialectBuilder::default().build();