Apache DataFusion SQL Query Engine
fix: Throw coercion error for `LIKE` operations for nested types. (#20212)
Jonathan Chen6a2bfd438bb0
diff --git a/datafusion/expr-common/src/type_coercion/binary.rs b/datafusion/expr-common/src/type_coercion/binary.rsindex 9051f412bd..97ec54b298 100644--- a/datafusion/expr-common/src/type_coercion/binary.rs+++ b/datafusion/expr-common/src/type_coercion/binary.rs@@ -1793,9 +1793,10 @@ fn binary_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataType>/// Coercion rules for like operations./// This is a union of string coercion rules, dictionary coercion rules, and REE coercion rules+/// Note: list_coercion is intentionally NOT included here because LIKE is a string pattern+/// matching operation and is not supported for nested types (List, Struct, etc.)pub fn like_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataType> {string_coercion(lhs_type, rhs_type)- .or_else(|| list_coercion(lhs_type, rhs_type)).or_else(|| binary_to_string_coercion(lhs_type, rhs_type)).or_else(|| dictionary_comparison_coercion(lhs_type, rhs_type, false)).or_else(|| ree_comparison_coercion(lhs_type, rhs_type, false))diff --git a/datafusion/sqllogictest/test_files/type_coercion.slt b/datafusion/sqllogictest/test_files/type_coercion.sltindex e3baa8fedc..8ab5b63e69 100644--- a/datafusion/sqllogictest/test_files/type_coercion.slt+++ b/datafusion/sqllogictest/test_files/type_coercion.slt@@ -254,3 +254,30 @@ DROP TABLE orders;########################################## Test type coercion with UNIONs end ##########################################++# https://github.com/apache/datafusion/issues/15661+# LIKE is a string pattern matching operator and is not supported for nested types.++statement ok+CREATE TABLE t0(v0 BIGINT, v1 STRING, v2 BOOLEAN);++statement ok+INSERT INTO t0(v0, v2) VALUES (123, true);++query error There isn't a common type to coerce .* in .* expression+SELECT true FROM t0 WHERE ((REGEXP_MATCH(t0.v1, t0.v1)) NOT LIKE (REGEXP_MATCH(t0.v1, t0.v1, 'jH')));++query error There isn't a common type to coerce .* in .* expression+SELECT true FROM t0 WHERE (REGEXP_MATCH(t0.v1, t0.v1)) NOT LIKE [];++query error There isn't a common type to coerce .* in .* expression+SELECT true FROM t0 WHERE (REGEXP_MATCH(t0.v1, t0.v1)) LIKE [];++query error There isn't a common type to coerce .* in .* expression+SELECT true FROM t0 WHERE (REGEXP_MATCH(t0.v1, t0.v1)) ILIKE [];++query error There isn't a common type to coerce .* in .* expression+SELECT true FROM t0 WHERE (REGEXP_MATCH(t0.v1, t0.v1)) NOT ILIKE [];++statement ok+DROP TABLE t0;