Skip to content

Apache DataFusion SQL Query Engine

Enable clippy::allow_attributes lint for datafusion-catalog (#18973)

Chakkk79257353be4a
diff --git a/datafusion/catalog/src/information_schema.rs b/datafusion/catalog/src/information_schema.rs
index 35f07084e3..c955819790 100644
--- a/datafusion/catalog/src/information_schema.rs
+++ b/datafusion/catalog/src/information_schema.rs
@@ -1167,7 +1167,7 @@ struct InformationSchemaRoutinesBuilder {
}
impl InformationSchemaRoutinesBuilder {
- #[allow(clippy::too_many_arguments)]
+ #[expect(clippy::too_many_arguments)]
fn add_routine(
&mut self,
catalog_name: impl AsRef<str>,
@@ -1301,7 +1301,7 @@ struct InformationSchemaParametersBuilder {
}
impl InformationSchemaParametersBuilder {
- #[allow(clippy::too_many_arguments)]
+ #[expect(clippy::too_many_arguments)]
fn add_parameter(
&mut self,
specific_catalog: impl AsRef<str>,
diff --git a/datafusion/catalog/src/lib.rs b/datafusion/catalog/src/lib.rs
index da50efbd68..fcdf049943 100644
--- a/datafusion/catalog/src/lib.rs
+++ b/datafusion/catalog/src/lib.rs
@@ -25,6 +25,7 @@
#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
#![deny(clippy::needless_pass_by_value)]
#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+#![deny(clippy::allow_attributes)]
//! Interfaces and default implementations of catalogs and schemas.
//!
diff --git a/datafusion/catalog/src/schema.rs b/datafusion/catalog/src/schema.rs
index 9ba55256f1..222b1d8ed7 100644
--- a/datafusion/catalog/src/schema.rs
+++ b/datafusion/catalog/src/schema.rs
@@ -68,7 +68,7 @@ pub trait SchemaProvider: Debug + Sync + Send {
///
/// If a table of the same name was already registered, returns "Table
/// already exists" error.
- #[allow(unused_variables)]
+ #[expect(unused_variables)]
fn register_table(
&self,
name: String,
@@ -81,7 +81,7 @@ pub trait SchemaProvider: Debug + Sync + Send {
/// schema and returns the previously registered [`TableProvider`], if any.
///
/// If no `name` table exists, returns Ok(None).
- #[allow(unused_variables)]
+ #[expect(unused_variables)]
fn deregister_table(&self, name: &str) -> Result<Option<Arc<dyn TableProvider>>> {
exec_err!("schema provider does not support deregistering tables")
}